[GitHub] brooklyn-server pull request #756: Support recursive option when getting act...

2017-07-05 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/756 Support recursive option when getting activities You can merge this pull request into a Git repository by running: $ git pull https://github.com/ahgittin/brooklyn-server rest-entity

[GitHub] brooklyn-server pull request #755: Added endpoint test boms

2017-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/755 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server issue #755: Added endpoint test boms

2017-07-05 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/755 Thanks @Graeme-Miller merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] brooklyn-server issue #755: Added endpoint test boms

2017-07-05 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/755 Could you add a description to this PR saying what it's adding please @Graeme-Miller? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] brooklyn-server issue #754: Fix REST API response of methods with String ret...

2017-07-05 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/754 Suggest we keep the changes for `PolicyConfigApi.get(...)`, making it work analogously to `EntityConfigApi.get(...)`. The value there can be any object, so it needs to be encoded as JSON.

[GitHub] brooklyn-server issue #754: Fix REST API response of methods with String ret...

2017-07-05 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/754 👍 +1 to your suggestions @iyovcheva If I understand correctly, the changes to add `@Produces(MediaType.TEXT_PLAIN` don't change the responses, but do ensure that the `Content-T

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

2017-07-05 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r125617562 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java --- @@ -153,19 +153,13 @@ public AbstractEntityAdjunct configu

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

2017-07-05 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r125617181 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractLocation.java --- @@ -216,17 +216,14 @@ public AbstractLocation configure(Map

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

2017-07-05 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/734#discussion_r125614883 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/AbstractEntity.java --- @@ -396,6 +396,9 @@ public AbstractEntity configure(Map flags)

[GitHub] brooklyn-server pull request #755: Added endpoint test boms

2017-07-05 Thread Graeme-Miller
GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/755 Added endpoint test boms You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-server add_endpoint_test_boms A

[GitHub] brooklyn-server issue #734: Support ConfigKey deprecated names

2017-07-05 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/734 hi @aledsage sorry missed the update above last week, will look at that presto. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] brooklyn-server issue #754: Fix REST API response of methods with String ret...

2017-07-05 Thread iyovcheva
Github user iyovcheva commented on the issue: https://github.com/apache/brooklyn-server/pull/754 @ahgittin This is a list of the GET requests the change impacts: ``` /activities/{task}/stream/{streamId} /applications/{application}/entities/{entity}/policies/{policy}/config

[GitHub] brooklyn-server issue #754: Fix REST API response of methods with String ret...

2017-07-05 Thread iyovcheva
Github user iyovcheva commented on the issue: https://github.com/apache/brooklyn-server/pull/754 Thanks @geomacy , I updated the test. "retest this please" triggers a rebuild. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w