[jira] [Commented] (BROOKLYN-546) On restart fails to install catalog bundles due to existing bundles installed with different location

[ https://issues.apache.org/jira/browse/BROOKLYN-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222777#comment-16222777 ] ASF GitHub Bot commented on BROOKLYN-546: - Github user aledsage commented on the issue:

[GitHub] brooklyn-server issue #867: BROOKLYN-546: fix rebind of system bundles

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/867 retest this please Excellent, jenkins build successful @ahgittin - I'm getting it to build again to make sure the new tests are reasonably reliable. ---

[jira] [Commented] (BROOKLYN-546) On restart fails to install catalog bundles due to existing bundles installed with different location

[ https://issues.apache.org/jira/browse/BROOKLYN-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222385#comment-16222385 ] ASF GitHub Bot commented on BROOKLYN-546: - Github user aledsage commented on the issue:

[GitHub] brooklyn-server issue #867: BROOKLYN-546: fix rebind of system bundles

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/867 retest this please failure was the unrelated non-deterministic test `org.apache.brooklyn.core.entity.lifecycle.ServiceStateLogicTest.testStopsNicelyToo` ---

Jenkins build is back to normal : brooklyn-master-build #1300

See

[GitHub] brooklyn-server issue #870: Tweaks on 866

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/870 @ahgittin I'm guessing your comment about the failing `BrooklynLauncherUpgradeCatalogOsgiTest.testRemoveLegacyItems` was meant against https://github.com/apache/brooklyn-server/pull/867,

[GitHub] brooklyn-server issue #870: Tweaks on 866

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/870 ran this locally, got a real failure @aledsage: ``` Failed tests:

[GitHub] brooklyn-server issue #870: Tweaks on 866

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/870 retest this please non-deterministic test failure this time is ``` Error Message expected one element but was: <{myKey=myDefault}, {myKey=valIsV1}>

[GitHub] brooklyn-server issue #865: Enable more tests fixed by sensor order guarante...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/865 need to fix `org.apache.brooklyn.core.entity.lifecycle.ServiceStateLogicTest` - this is happening a fair bit now on jenkins (never locally). also

[GitHub] brooklyn-server pull request #869: Reverted code for selecting subnet hostna...

Github user Graeme-Miller closed the pull request at: https://github.com/apache/brooklyn-server/pull/869 ---

[GitHub] brooklyn-server issue #869: Reverted code for selecting subnet hostname for ...

Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/869 Spoke to @aledsage and we have agreed reverting #849 is the way to go. I have created #871 to do this ---

[GitHub] brooklyn-server pull request #871: Revert "Retrieve the right AWS metadata f...

GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/871 Revert "Retrieve the right AWS metadata for private hostname" This reverts commit 8877368aa4c04e21eecd167538f878c4e0681900. Please see discussion on this PR:

[jira] [Commented] (BROOKLYN-546) On restart fails to install catalog bundles due to existing bundles installed with different location

[ https://issues.apache.org/jira/browse/BROOKLYN-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1653#comment-1653 ] ASF GitHub Bot commented on BROOKLYN-546: - Github user ahgittin commented on the issue:

Build failed in Jenkins: brooklyn-master-build #1299

See -- [...truncated 6.91 MB...] [INFO] Brooklyn Server Root ... SUCCESS [ 1.162 s] [INFO] Brooklyn Parent Project SUCCESS

[jira] [Commented] (BROOKLYN-546) On restart fails to install catalog bundles due to existing bundles installed with different location

[ https://issues.apache.org/jira/browse/BROOKLYN-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222195#comment-16222195 ] ASF GitHub Bot commented on BROOKLYN-546: - Github user ahgittin commented on the issue:

[GitHub] brooklyn-server pull request #868: allow types from different bundles if equ...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/868 ---

[GitHub] brooklyn-server issue #868: allow types from different bundles if equivalent

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/868 Thanks @ahgittin - merging. ---

Jenkins build is back to normal : brooklyn-server-master #774

See

[GitHub] brooklyn-server issue #866: catalog-init: add support for item/bundle remova...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/866 @ahgittin we do support and respond to: * `force-remove-bundles: *` - it means ignore from persisted state (i.e. don't rebind) all older versions of this bundle. *

[jira] [Commented] (BROOKLYN-546) On restart fails to install catalog bundles due to existing bundles installed with different location

[ https://issues.apache.org/jira/browse/BROOKLYN-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222183#comment-16222183 ] ASF GitHub Bot commented on BROOKLYN-546: - Github user ahgittin commented on the issue:

[GitHub] brooklyn-server issue #867: BROOKLYN-546: fix rebind of system bundles

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/867 @aledsage conflicts with #866 ^ :( #WhyBigPullReqsArentSoBadWhenCodeIsIntertwined (this is causing pain for the reviewer as well as the author) ---

[jira] [Commented] (BROOKLYN-546) On restart fails to install catalog bundles due to existing bundles installed with different location

[ https://issues.apache.org/jira/browse/BROOKLYN-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222171#comment-16222171 ] ASF GitHub Bot commented on BROOKLYN-546: - Github user ahgittin commented on a diff in the pull

[GitHub] brooklyn-server pull request #866: catalog-init: add support for item/bundle...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/866 ---

[GitHub] brooklyn-server issue #866: catalog-init: add support for item/bundle remova...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/866 [MINOR] I don't understand the messages on the last two commits -- we're not actually supporting these headers yet in that we don't respond. Some minor tidies in #870. Biggest of

[GitHub] brooklyn-server pull request #870: Tweaks on 866

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/870 Tweaks on 866 Builds on #866 - closes it and adds a few tweaks. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-server issue #868: allow types from different bundles if equivalent

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/868 all comments addressed @aledsage - one minor code change re `OsgiManager` build seems stuck. passes locally (just checked) so i think merge now? ---

Re: [PROPOSAL] catalog bundle id:version mandatory in v1.0.0

We jump through quite a few hoops to ensure rebind works, including current PR [1]. (I might feel differently if I haven't just spent too long making those hoops.) Code will be able to be simplified quite a bit in this area if we disallow the so-called "anonymous bundles" - but feels

[GitHub] brooklyn-server pull request #868: allow types from different bundles if equ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/868#discussion_r147362460 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -1492,7 +1503,7 @@ protected

[GitHub] brooklyn-server pull request #868: allow types from different bundles if equ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/868#discussion_r147361400 --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/BasicBrooklynTypeRegistry.java --- @@ -368,13 +399,77 @@ public void

[GitHub] brooklyn-server pull request #868: allow types from different bundles if equ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/868#discussion_r147359682 --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/BasicBrooklynTypeRegistry.java --- @@ -74,28 +92,40 @@ public

[GitHub] brooklyn-server issue #866: catalog-init: add support for item/bundle remova...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/866 retest this please Failure is unrelated, and not obvious why it would fail non-deterministically! Needs to be investigated separately: ``` 2017-10-26 23:12:19,940 INFO

Re: [PROPOSAL] catalog bundle id:version mandatory in v1.0.0

Fair points Alex, you are absolutely right. Although, I still think that forcing to have `bundle:` now in a bom is a better way: It will be annoying for users but easy to fix, whereas the alternative means that it Brooklyn **will be broken on restart/rebind** which is a clear no-go from my point

Re: [PROPOSAL] catalog bundle id:version mandatory in v1.0.0

Thinking about it I'm not convinced that breaking users blueprints is the best way to update their mental model. With a shift to use the CLI with catalog.bom in root and updating exemplar projects, and updating UI to reflect bundles, I expect we'll achieve this in a less disruptive way. At

Re: New `website` branch in brooklyn-docs

Sorry - I really don't like website being hidden on a branch. Why? * It's non-obvious and one more thing to remember (or forget, or explain) * Primary reason for branching (in my view) is lifecycle, and here the two have very similar versioning and release lifecycles: master for both will be

Re: [PROPOSAL] catalog bundle id:version mandatory in v1.0.0

+1, this sounds sensible to me too. I also vote in favor of making this a breaking change. With 1.0.0 coming, this is the perfect time to do it. Best. On Fri, 27 Oct 2017 at 08:06 Geoff Macartney wrote: > +1 to your suggestion Aled. Also I'd side with making it

Re: [PROPOSAL] catalog bundle id:version mandatory in v1.0.0

+1 to your suggestion Aled. Also I'd side with making it a breaking change, I prefer forcing that mental model. On Thu, 26 Oct 2017 at 13:12 Aled Sage wrote: > Alex, > > I say we break it - force the user to have the correct mental model for > 1.0.0! > > It's a simple