[GitHub] brooklyn-server issue #916: DynamicCluster's max size applies to all calls t...

2018-01-03 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/916 @nakomis @sjcorbett @tbouron are you suggesting we change the `AutoScalerPolicy` etc to do that, or that we leave it as-is so the auto-scaler doesn't work well with `maxSize` (unless the

[GitHub] brooklyn-docs pull request #242: Describe authentication options for catalog...

2018-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/242 ---

[jira] [Resolved] (BROOKLYN-167) HighAvailabilityManagerImpl has invalid state if /v1/server/ha/states requested before BrooklynLauncher has fully initialised a server

2018-01-03 Thread Sam Corbett (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Corbett resolved BROOKLYN-167. -- Resolution: Fixed > HighAvailabilityManagerImpl has invalid state if /v1/server/ha/states >

[GitHub] brooklyn-server pull request #925: Fix reporting of master ID when web API u...

2018-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/925 ---

[jira] [Commented] (BROOKLYN-167) HighAvailabilityManagerImpl has invalid state if /v1/server/ha/states requested before BrooklynLauncher has fully initialised a server

2018-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309475#comment-16309475 ] ASF GitHub Bot commented on BROOKLYN-167: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-server issue #923: DynamicCluster: resize to maxSize, before throwi...

2018-01-03 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/923 makes sense to resize as much as we can, but 100% agree re giving more feedback to user. a highlight might be nice but not sure how to clear it. the right thing feels like being

[GitHub] brooklyn-server pull request #923: DynamicCluster: resize to maxSize, before...

2018-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/923 ---

[GitHub] brooklyn-server issue #925: Fix reporting of master ID when web API used bef...

2018-01-03 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/925 LGTM. Client-side fix in https://github.com/apache/brooklyn-ui/pull/51 which could also be merged but this change is better. ---

[GitHub] brooklyn-ui pull request #51: if not using persistence and mgmt plane ID is ...

2018-01-03 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-ui/pull/51 if not using persistence and mgmt plane ID is null, UI can give erroneous error fix it by accepting null plane as acceptable if server is otherwise healthy You can merge this pull request

[GitHub] brooklyn-server issue #916: DynamicCluster's max size applies to all calls t...

2018-01-03 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/916 @aledsage I agree with @nakomis and @sjcorbett. I this logic should be implemented in the client (UI/CLI) to deal with a `InsufficientCapacityException` by proposing to resize to the max

[GitHub] brooklyn-server issue #916: DynamicCluster's max size applies to all calls t...

2018-01-03 Thread nakomis
Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/916 @aledsage regarding resizing up to `maxSize`, I'd favour @sjcorbett's approach of throwing the `InsufficientCapacityException` and leaving it up to the consumer to re-try. Requesting a new

Jenkins build is back to normal : brooklyn-master-build-docker #123

2018-01-03 Thread Apache Jenkins Server
See