[GitHub] brooklyn-server issue #999: Constraints - serialization and {forbidden,requi...

2018-09-21 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/999 BTW you're both right, i forgot to apply the serialization to catalog input; i've fixed that also ---

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219657203 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

[GitHub] brooklyn-server issue #999: Constraints - serialization and {forbidden,requi...

2018-09-21 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/999 all PR comments addressed. more exciting, it has been tested against https://github.com/apache/brooklyn-ui/pull/72. ![screen shot 2018-09-22 at 01 48

[GitHub] brooklyn-ui pull request #72: More constraints

2018-09-21 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-ui/pull/72 More constraints Adds UI support for constraints introduced in https://github.com/apache/brooklyn-server/pull/999 You can merge this pull request into a Git repository by running: $ git

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219655675 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219655574 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/ResourcePredicates.java --- @@ -64,7 +66,7 @@ public boolean apply(@Nullable String

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219655496 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219655030 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219654951 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

[GitHub] brooklyn-dist pull request #126: update order in pom so we get the preferred...

2018-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/126#discussion_r219619890 --- Diff: all/pom.xml --- @@ -36,11 +36,35 @@ +

[GitHub] brooklyn-dist pull request #126: update order in pom so we get the preferred...

2018-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/126#discussion_r219619308 --- Diff: all/pom.xml --- @@ -36,11 +36,35 @@ +east we've attempted to do this! --> --- End diff --

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219558955 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219557804 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219567394 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/ConfigConstraints.java --- @@ -218,4 +228,88 @@ public

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219567021 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/ConfigConstraints.java --- @@ -218,4 +228,88 @@ public

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219560576 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219559231 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219561614 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java --- @@ -0,0 +1,369 @@ +/* + * Licensed to the

Build failed in Jenkins: brooklyn-client-master-docker #19

2018-09-21 Thread Apache Jenkins Server
See -- [...truncated 210.84 KB...] at org.apache.brooklyn.rt.felix.EmbeddedFramework.getFramework(EmbeddedFramework.java:30) at

Re: PROPOSAL: conditional config constraints

2018-09-21 Thread Thomas Bouron
+1 great addition! I'm also in favour of returning YAML instead of plain string, will make the UI work way easier. Alex, I just eyeballed your PR, looks good but left a comment and question there. Best. On Fri, 21 Sep 2018 at 12:34 Alex Heneveld wrote: > > +1 > > I've implemented this for the

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/999#discussion_r219550831 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/ResourcePredicates.java --- @@ -64,7 +66,7 @@ public boolean apply(@Nullable String

[GitHub] brooklyn-server issue #999: Constraints - serialization and {forbidden,requi...

2018-09-21 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/999 retest this please Build failure was environmental: ``` ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from

Build failed in Jenkins: brooklyn-dist-master-docker #63

2018-09-21 Thread Apache Jenkins Server
See -- [...truncated 2.59 KB...] at hudson.Util.tryOnceDeleteContentsRecursive(Util.java:407) at hudson.Util.deleteContentsRecursive(Util.java:252) ...

[GitHub] brooklyn-dist pull request #126: update order in pom so we get the preferred...

2018-09-21 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-dist/pull/126 update order in pom so we get the preferred versions in downstream maven projects You can merge this pull request into a Git repository by running: $ git pull

Re: PROPOSAL: conditional config constraints

2018-09-21 Thread Alex Heneveld
+1 I've implemented this for the server side at https://github.com/apache/brooklyn-server/pull/999 . One minor tweak to Aled's proposal, I think we should output a structured YAML rather than the toString, so clients don't have to do complex parsing. IE instead of sending the string

[GitHub] brooklyn-server pull request #999: Constraints - serialization and {forbidde...

2018-09-21 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/999 Constraints - serialization and {forbidden,required}{If,Unless} You can merge this pull request into a Git repository by running: $ git pull

Re: PROPOSAL: conditional config constraints

2018-09-21 Thread Aled Sage
Hi Geoff, all, You're example is correct - that is what I'd write. I don't think there's a short way to convey this info without using two such predicates, or implementing a full-blown DSL. I wondered about including an "iff" (i.e. "if and only if"), but that doesn't add much. For example,

Re: Empire-db build problems <-- brooklyn-master-build-docker_ws-cleanup workspace left behind

2018-09-21 Thread John Campbell
Hi Aled, We’re seeing this failure message in the log for build #62. It’s referring to a target directory although Maven has not run. https://builds.apache.org/job/brooklyn-dist-master-docker/62 [brooklyn-dist-master-docker] $ /bin/bash -xe /tmp/jenkins918258338062829729.sh + docker build -t

Re: Empire-db build problems <-- brooklyn-master-build-docker_ws-cleanup workspace left behind

2018-09-21 Thread Aled Sage
Hi all, Do any brooklyn folk know what the `brooklyn-master-build-docker_ws-cleanup_.*` workspaces are for, and why they are not being cleaned up? It sounds like this bug in ws-cleanup-plugin [1]. It was fixed, but then folk reported that they were still experiencing the same problem [2].

Build failed in Jenkins: brooklyn-library-master-docker #331

2018-09-21 Thread Apache Jenkins Server
See -- [...truncated 2.10 MB...] [INFO] --- buildnumber-maven-plugin:1.3:create (default) @ brooklyn-software-cm-ansible --- [INFO] [INFO] ---

Re: PROPOSAL: conditional config constraints

2018-09-21 Thread Geoff Macartney
Hi Aled, I'd say go for it, that looks like something that could be valuable in various cases. I take it your example of "exactly one of config X or config Y" would be expressed along the lines of a parallel set of constraints between each config - On X: constraints: -

Jenkins build is back to normal : brooklyn-master-build-docker #702

2018-09-21 Thread Apache Jenkins Server
See