Github user bostko commented on the issue:
https://github.com/apache/brooklyn-library/pull/134
Thanks for the reminder @tbouron . Addressed comments.
Feel free to edit my PR if you have more comments.
---
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/911#discussion_r155337371
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
---
@@ -509,13
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/907
BROOKLYN-567 Prevent mutating EntitySpecSupplier's flag field
I believe this fixes the issue.
Glad to do a little Sunday hiking in Apache Brooklyn.
You can merge this pull request
Hi,
I'd like to address one more glitch which I think is not discussed.
Setting a config for VanillaSoftwareProcess type which is be predefined
for that type could cause confusion.
For example [1] using brooklyn.config:
- version is set to the install.version config
- downloadUrl is set to the
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-library/pull/134
Add Apache ActiveMQ Artemis catalog item
Catalog item is visible in Apache Brooklyn karaf build
BROOKLYN-541
You can merge this pull request into a Git repository by running
Github user bostko closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/132
Bundle-Symbolic name should be discouraged. PR is irrelevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/491
I will not use those changes. Closing for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/204#discussion_r130730297
--- Diff: guide/locations/_azure-ARM.md ---
@@ -158,9 +158,8 @@ brooklyn.catalog:
destroyOnFailure: false
templateOptions
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/204
Fix wrong indentation in Windows Azure ARM config
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs
windows-azure-arm
Github user bostko closed the pull request at:
https://github.com/apache/brooklyn-server/pull/779
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/779
Closing in favor of #780
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/780
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/779
Exclude Vault headers trace log
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-server exclude-headers
Alternatively
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/775
Useful when consumer of the VaultConfigSuppliler wants to have finer
control over number of calls made to vault.
Also this method returns Map with parameters on which a consumer can use
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/775
Useful getDataAsStringMap for VaultExternalConfigSupplier
`getDataAsStringMap` allows obtaining vault data with single call.
You can merge this pull request into a Git repository by running
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/774
Reduce logging for Vault external config supplier
I consider as healthier to not log `responseBody` from vault.
You can merge this pull request into a Git repository by running:
$ git
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/757
[WIP] BROOKLYN-519 no BasicSpecParameter serialization
BasicSpecParameters are only consumed in API
and no need to keep them or keep their state.
- TODO rebind tests
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/201
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/144
@tbouron I included @geomacy note.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bostko closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/183
Squash changes into https://github.com/apache/brooklyn-docs/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-ui/pull/46
Update maven-compiler-plugin to 3.6.1
Related to https://github.com/apache/brooklyn-dist/pull/97 and
https://github.com/apache/brooklyn-server/pull/741
You can merge this pull request
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-dist/pull/97
Update maven-compiler-plugin to 3.6.1
Related to https://github.com/apache/brooklyn-server/pull/741
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/741
Update maven-compiler-plugin to 3.6.1
I think since we upgrade java it will be useful to have later
maven-compiler-plugin.
If you approve this change, I will do the same PR for brooklyn
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/144#discussion_r123011018
--- Diff: guide/dev/tips/logging.md ---
@@ -11,6 +11,10 @@ with a default configuration which just works out of the
box
and bindings to the other
Github user bostko closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/156
@aledsage I think problem I had was that I used machine location namer
which was specifiying a constant machine name. Thus I hit an error in Azure ARM
where the first problem was when jclouds
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/183
Any suggestions are welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/119
Hi, I rebased PR and addressed Aleds' comments for
`SharedLocationSecurityGroupCustomizer`.
@aledsage , regarding the section talking about configuring the location,
if using
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/197
Point to currently supported Java 8
Minor changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs java-8
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/720
@neykov how did you verify Jenkins merges the branch to master before
building?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/724
[BROOKLYN-516] Persist feed of WindowsPerformanceCounterSensors initializer
Also make WindowsPerformanceCounterFeed$GetPerformanceCountersJob to not
throw
exception when no machine
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/722
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/722
[BROOKLYN-515] WindowsPerformanceCounterSensors does not show values
WindowsPerformanceCounterSensors does not show values on some deployments.
You can merge this pull request into a Git
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/195
@drigodwin thank you for the suggestions!
I am hesitant to reword the first sentence WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/195#discussion_r120638130
--- Diff: guide/ops/troubleshooting/increase-system-resource-limits.md ---
@@ -4,6 +4,16 @@ title: Increase System Resource Limits
toc: /guide
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/195
Advise users to increase OS opened files limit
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs max-files
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/713
To what it will transform for the blueprint in BROOKLYN-510?
Will the yaml bellow
```
inboundPorts:
- 22
- 9100-9200
```
mean `22, 9101, 9202,..., 9200
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/708
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/690#discussion_r117673212
--- Diff:
core/src/main/java/org/apache/brooklyn/location/byon/ByonLocationResolver.java
---
@@ -152,49 +153,54 @@ protected ConfigBag
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/187
Add hint for using effector.add.openInboundPorts entity config
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs ports
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/185
[Suggestion] Merge guide/dev into website/developers
One section for all coding related matters.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/183
[For Review] Details on configuring logging for OSGi distribution
I am looking for some hints which we can add in docs for logging
configuration.
Should we describe karaf commands in docs
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/682
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/681
Thank you @neykov. I changed PR as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/681
Flag allowing a Winrm4jTool to use unique context
Fixes https://github.com/cloudsoft/winrm4j/issues/63
To test add in location configuration
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/680
You can assign any ssh config using
```
provisioning.properties:
brooklyn.ssh.config.additionalSshConfig: myValue
```
---
If your project is set up for it, you can
+1
for contents in
https://github.com/apache/brooklyn-library/tree/master/examples except [1]
[1] https://github.com/apache/brooklyn-library/tree/master/examples/webapps
On 10/05/17 16:30, Aled Sage wrote:
Hi all,
I suggest we delete the java/groovy examples in
brooklyn-library/examples
edit
On 10/05/17 16:37, bostko wrote:
+1
for *deleting* contents in
https://github.com/apache/brooklyn-library/tree/master/examples except
[1]
[1]
https://github.com/apache/brooklyn-library/tree/master/examples/webapps
On 10/05/17 16:30, Aled Sage wrote:
Hi all,
I suggest we delete
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/179
@neykov I removed `-Xint` option from doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/179
I personally use the line I quoted only and works for me.
If others thing we shouldn't advice people to use `Xint` I am happy to
simply remove it from this doc
and probably add a link
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/179
It is interesting that IntelliJ Idea recommends using remote debug only with
`-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005` and
not disabling JIT.
---
If your
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/179
Remove from docs deprecated -Xnoagent
Ignored in Oracle Java
http://www.oracle.com/technetwork/java/javase/tech/faqs-jsp-142584.html#QC4http://www.oracle.com/technetwork/java/javase/tech
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/176
@tbouron I agree we should look why `osVersionRegex: 7\..*` does not choose
the latest and probably fire a bug instead of adding such note.
Closing PR. I will create a jira issue at some
Github user bostko closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/176
imageId example for Azure Compute ARM
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs azure-arm/imageId-hint
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/655
Thank you!
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/654
Fix BROOKLYN-493 Rebind fails when using WinRmCommandSensor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-server
Github user bostko closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/171
Closing in favor of #171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/171
A ConfigKey default value should be immutable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs default-config-key
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-library/pull/99
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/634
Are there other use cases for using private classes besides BROOKLYN-474?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/163
Update jclouds 1.9.x links to point to jclouds 2.0.x
Removed obsolete openstack-mitaka-nova section.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/162
BROOKLYN-460: Brooklyn Camp syntax guidance
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs yaml-tags
Alternatively
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/612#discussion_r109965279
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
---
@@ -227,7
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/618
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/612#discussion_r108640523
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java
---
@@ -227,7
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/612#discussion_r108639142
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslYamlTest.java
---
@@ -66,6 +71,63 @@ public void
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/612#discussion_r108635893
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTags.java ---
@@ -59,6 +59,21 @@ public String getKind() {
public
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/612#discussion_r108633990
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
---
@@ -257,6
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/612
Brooklyn Camp syntax for adding tags to an entity spec
```yaml
services:
- type: BasicApplication
brooklyn.tags: [tag1, tag2]
```
`brooklyn.tags` adds
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/603
I missed to add that my concern is that I do not know find suitable place
to put such test.
Adding test in brooklyn-camp or brooklyn-software-winrm will introduce
circular dependency
Github user bostko closed the pull request at:
https://github.com/apache/brooklyn-server/pull/597
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/597
No we do not need this PR since we have #598 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/597
Rebind SshFeed workaround
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-server sshfeed-rebind
Alternatively you can
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/596#discussion_r106206363
--- Diff:
software/winrm/src/main/java/org/apache/brooklyn/core/sensor/windows/WinRmCommandSensor.java
---
@@ -144,15 +144,7 @@ public T apply
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/596#discussion_r106205545
--- Diff:
software/winrm/src/main/java/org/apache/brooklyn/core/sensor/windows/WinRmCommandSensor.java
---
@@ -144,15 +144,7 @@ public T apply
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/596
WinRmCommandSensor default executionDir
Use default dir obtained on the winrm sesion
until Apache Brooklyn has working concept for RUN_DIR on
VanillaWindowsProcess
You can merge
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-docs/pull/155
@drigodwin could you check again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/595
That worked, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/595
Workaround for WinRmCommandSensor to see CmdFeed in OSGi
Move CmdFeed to the same package as WinRmCommandSensor
You can merge this pull request into a Git repository by running:
$ git
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/156
Suggest using unique custom.machine.namer.machine
Notes on using unique VM name to avoid duplicated names in cloud.
You can merge this pull request into a Git repository by running
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/591
I wanted to check whether it is tested against CentOS 6.
Thank you for inspecting that!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/591
Is it possible that `PROP_ALLOCATE_PTY` breaks for Centos 6 images?
Is it tested on other clouds. I thing it should be optional.
I have to suggestions for implementing it:
- Move
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/155
Brooklyn.initializers example with sensor from windows command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs winrm
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/154#discussion_r105683376
--- Diff: guide/java/feeds.md ---
@@ -67,15 +69,15 @@ protected void disconnectSensors() {
An SSH feed executes a command over ssh periodically
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/154
WinRM CMD feed usage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs winrmcmd_feed
Alternatively you can review
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/583
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@sjcorbett thanks for the notes!
I added in apache/brooklyn-server#578 an `unauthorize` call which seems to
solve the issues in classic mode.
Could you check both PRs again,
Thanks
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/578
This PR is not dependent brooklyn-ui#36.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bostko closed the pull request at:
https://github.com/apache/brooklyn-library/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-library/pull/55
This PR should be revisited. Closing for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/578#discussion_r103885009
--- Diff:
rest/rest-resources/src/main/resources/OSGI-INF/blueprint/service.xml ---
@@ -114,6 +114,7 @@ limitations under the License
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/578
BROOKLYN-323: Logout fixes for karaf distribution
- Added POST logout call returning html.
Intermidiate logout step moved from brooklyn-ui
to Java code in brooklyn-server
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-server/pull/577
Bugfix. Move a test from src/main to src/test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-server fix/build
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/564
@neykov I opened https://issues.apache.org/jira/browse/BROOKLYN-442 .
Could you review current PR whether is suitable for merging?
---
If your project is set up for it, you can reply
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/564
@neykov I was doing some changes for common ShellTool locally however
didn't find time to finish and push that.
---
If your project is set up for it, you can reply to this email and have
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/564#discussion_r101862606
--- Diff:
software/winrm/src/main/java/org/apache/brooklyn/core/sensor/windows/WinRmCommandSensor.java
---
@@ -0,0 +1,167
1 - 100 of 317 matches
Mail list logo
