[GitHub] [brooklyn-server] ahgittin commented on pull request #1389: Activities tab rest optimization

2023-05-24 Thread via GitHub
ahgittin commented on PR #1389: URL: https://github.com/apache/brooklyn-server/pull/1389#issuecomment-1560901120 @jcabrerizo You are right, this makes a huge difference, and I agree with you it's the correct balance where we do it. In fact I've extended it a bit, and tidied, in

[GitHub] [brooklyn-server] ahgittin commented on pull request #1389: Activities tab rest optimization

2023-04-24 Thread via GitHub
ahgittin commented on PR #1389: URL: https://github.com/apache/brooklyn-server/pull/1389#issuecomment-1519854466 @jcabrerizo this is effective but a few things seem wrong to me: (1) `Sanitizer.suppress` methods are to _replace_ sensitive fields eg password with a hashcode so they are