aledsage commented on issue #1035: DO NOT MERGE Use dependencyManagement from Karaf as a bom URL: https://github.com/apache/brooklyn-server/pull/1035#issuecomment-462397221 I like the approach, the changes look good, but `brooklyn-dist` build fails for me with these changes due to the `maven-enforcer-plugin`: ``` [WARNING] Dependency convergence error for javax.xml.bind:jaxb-api:2.3.0 paths to dependency are: +-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT +-org.apache.karaf.features:framework:4.2.2 +-org.apache.karaf.features:base:4.2.2 +-javax.xml.bind:jaxb-api:2.3.0 and +-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT +-org.apache.karaf.features:framework:4.2.2 +-org.apache.karaf.features:base:4.2.2 +-org.glassfish.jaxb:jaxb-runtime:2.3.1 +-javax.xml.bind:jaxb-api:2.3.1 [WARNING] Rule 2: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message: Failed while enforcing releasability the error(s) are [ Dependency convergence error for javax.xml.bind:jaxb-api:2.3.0 paths to dependency are: +-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT +-org.apache.karaf.features:framework:4.2.2 +-org.apache.karaf.features:base:4.2.2 +-javax.xml.bind:jaxb-api:2.3.0 and +-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT +-org.apache.karaf.features:framework:4.2.2 +-org.apache.karaf.features:base:4.2.2 +-org.glassfish.jaxb:jaxb-runtime:2.3.1 +-javax.xml.bind:jaxb-api:2.3.1 ] ``` Annoyingly, this seems to be a problem in Karaf 4.2.2 itself! https://search.maven.org/artifact/org.apache.karaf.features/base/4.2.2/jar depends on: ``` <dependency> <groupId>javax.xml.bind</groupId> <artifactId>jaxb-api</artifactId> <version>2.3.0</version> </dependency> <dependency> <groupId>org.glassfish.jaxb</groupId> <artifactId>jaxb-runtime</artifactId> <version>2.3.1</version> </dependency> ``` And https://search.maven.org/artifact/org.glassfish.jaxb/jaxb-runtime/2.3.1/jar depends on v2.3.1 of `javax.xml.bind:jaxb-api`. Therefore I'm not sure we can merge this! Maybe we could add some excludes or some temporary ugliness like that. Note that karaf 4.2.3 is recently out as well, which I think will fix that incompatibility between jaxb-api version (to use v2.3.2 throughout). But not suggesting we rush to upgrade to that, and certainly not in this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
