[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-12 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-docs/pull/44#issuecomment-209258489 Added a new commit addressing the comments so it's clear what the changes are. Will squash before merging. @sjcorbett The instructions are mostly one-liners copy

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-12 Thread geomacy
Github user geomacy commented on the pull request: https://github.com/apache/brooklyn-docs/pull/44#issuecomment-208910092 What do we do about the numerous other pages where 'brooklyn.properties' is referenced? Is it best to leave them as-is until Brooklyn moves to a Karaf-only distr

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-12 Thread geomacy
Github user geomacy commented on the pull request: https://github.com/apache/brooklyn-docs/pull/44#issuecomment-208910288 that's all the comments from me... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-12 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/44#discussion_r59375726 --- Diff: guide/misc/osgi.md --- @@ -0,0 +1,63 @@ +--- +title: FAQ +layout: website-normal +--- + +# Running Apache Brooklin insi

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-12 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/44#discussion_r59376672 --- Diff: guide/misc/osgi.md --- @@ -0,0 +1,63 @@ +--- +title: FAQ +layout: website-normal +--- + +# Running Apache Brooklin insi

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-12 Thread m4rkmckenna
Github user m4rkmckenna commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/44#discussion_r59375180 --- Diff: guide/misc/osgi.md --- @@ -0,0 +1,63 @@ +--- +title: FAQ +layout: website-normal +--- + +# Running Apache Brooklin

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-12 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/44#discussion_r59375191 --- Diff: guide/misc/osgi.md --- @@ -0,0 +1,63 @@ +--- +title: FAQ +layout: website-normal +--- + +# Running Apache Brooklin insi

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-12 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/44#discussion_r59374944 --- Diff: guide/misc/osgi.md --- @@ -0,0 +1,63 @@ +--- +title: FAQ --- End diff -- The title is misleading, it's not a FAQ page real

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-11 Thread sjcorbett
Github user sjcorbett commented on the pull request: https://github.com/apache/brooklyn-docs/pull/44#issuecomment-208466458 Looks good. Do you want me to double check any of the instructions in particular? --- If your project is set up for it, you can reply to this email and have you

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-11 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/44#discussion_r59246331 --- Diff: guide/misc/osgi.md --- @@ -0,0 +1,63 @@ +--- +title: FAQ +layout: website-normal +--- + +# Running Apache Brooklin in

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-11 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/44#discussion_r59246114 --- Diff: guide/misc/osgi.md --- @@ -0,0 +1,63 @@ +--- +title: FAQ +layout: website-normal +--- + +# Running Apache Brooklin in

[GitHub] brooklyn-docs pull request: Initial OSGi docs

2016-04-11 Thread neykov
GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-docs/pull/44 Initial OSGi docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/neykov/brooklyn-docs osgi Alternatively you can review and apply these c