[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/388 thanks @neykov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/388 @neykov surely this isn't merged yet, can we merge it first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/388 @geomacy Can you close - looks like I didn't use the correct keyword in the message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/388 Changes squashed and re-pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/388 Thanks @geomacy, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/388 Comments addressed in 0559ff0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/388 Good to merge after addressing above and Aled's comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/388 @aledsage yes I tested this yesterday, and sure enough it bites us - I commented out the line 136 above, and increased the timeout to a large value, and after a minute the test fails with

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/388 @geomacy Looks good to me. Feel free to completely ignore my trivial comment - it's not worth the effort of changing it here ;-) What is the situation with @neykov's comment "on

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user justinThompson commented on the issue: https://github.com/apache/brooklyn-server/pull/388 So does the stop latch just wait for the presence of the `stop.now` sensor? Does it care what the value is? --- If your project is set up for it, you can reply to this email and

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/388 will have a think about that and see if I can add test conditions to cover that case --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server issue #388: Add a stop latch to SoftwareProcess.

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/388 Changes look good on first pass. One thing that comes to mind is that on stop DSLs time out after a minute and unblock. Does this rule apply here as well, can we do something to avoid it?