Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
Seems there may be a pathway by which REST does not populate an entity's
`EntityType.configKeys` in this PR, reported by @sjcorbett . Looking in to
this now.
---
If your project is set
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
Good spot. Will fix and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
Could cause an issue if absents are used as keys with the intention that
they all be different but that would be weird. Have checked our hashCode
and it's a constant for absents
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
@neykov @geomacy @aledsage Done. Hurrah. I've fixed the "declared keys"
exclusions -- in the end @geomacy's suggestion re cleaning up the
`resolveParameters` method was on point, and the
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
^^ and neykov's comments re `SpecParameterForInheritance`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
more updates; now just need to:
* fix the bug geomacy found
* rewview comments from neykov re SpecParameterUnwrappingTest.java
---
If your project is set up for it,
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
@geomacy good find in your failing test
[above](https://github.com/apache/brooklyn-server/pull/462#issuecomment-270408039)
-- we do not filter out hidden ancestor config keys whenever we
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
failure appears non-deterministic and i think unrelated
```
Tests run: 2036, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 328.296
sec <<< FAILURE! - in TestSuite
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
Thanks for such great comments. Nearly done, should finish today. Sorry I
dropped the ball on this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
In general I think this looks good to me and does what it says on the tin;
I just had
the few observations and questions above.
---
If your project is set up for it, you can reply to
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
Wrote a few extra tests to try out the change. The only one that didn't
perform as I'd expected was
```java
@Test
public void
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/462
rebased on master; still need to address comments above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
12 matches
Mail list logo
