Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/519
Looks good, and other reviewers approved. Will merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user m4rkmckenna commented on the issue:
https://github.com/apache/brooklyn-server/pull/519
@bostko One from @geomacy RE javadoc (DRY) ... I think the rest have been
addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/519
@m4rkmckenna are there comments which I missed to address.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-server/pull/519
PR is updated.
To test it in the karaf distribution you need to have
`etc/org.apache.brooklyn.rest.filter.cors.cfg`
---
If your project is set up for it, you can reply to this email and
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/519
I think that's all the comments I want to make except that it would be good
to have an actual web page test case that demonstrates it working; maybe
@m4rkmckenna could help out with that?
