[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

2017-06-06 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/719 Looks like it is fetching the apache master instead of the branch from my fork, as below. Note `c545381152a22df29d16c063fd6cd2fab4ec7b33` is my change but it is fetching from ```

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

2017-06-06 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/719 Tests pass locally, merging. Will investigate jenkins issue separately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

2017-06-06 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/719 retest this please, after deleting the workspace --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

2017-06-06 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/719 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

2017-06-06 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/719 Hm very strange - it looks as if the test hasn't pulled the [change](https://github.com/apache/brooklyn-server/pull/719/files#diff-774e93f2e6ad061ee24dbb975abff1d0R174), see

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

2017-06-06 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/719 Hm, build fails with same error - I can't reproduce that however. I did reproduce the original error, then built everything successfully after making the change above. Odd... --- If your

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

2017-06-06 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/719 LGTM, will wait for the tests to pass and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have