[GitHub] brooklyn-server issue #798: Fix template forward reference

2017-08-21 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/798 Thanks @ahgittin, merging now then. @Graeme-Miller was there a Jira for your issue? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server issue #798: Fix template forward reference

2017-08-18 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/798 I have tested locally and can confirm that this fixes the issue that I saw. This PR adds a test for that issue, but thought it was best to double check. This code looks good

[GitHub] brooklyn-server issue #798: Fix template forward reference

2017-08-16 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/798 fixed RAT and your better code style. also added checks in other paths where unresolved might be used. don't think any of them are necessary but doesn't hurt to try. --- If your

[GitHub] brooklyn-server issue #798: Fix template forward reference

2017-08-16 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/798 @ahgittin Build failed due to no license header in `template-and-app.bom` file: ``` [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project