Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
@ahgittin I'll review #854 now. Although, there is another point that is
missing from this PR: Swagger still don't show the deprecation warning for the
entity policy endpoints.
For
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
@tbouron totally forgot about your point karaf is missing this; have fixed
that in #854 if you could take a quick look
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
@ahgittin Sorry, I did miss your comment. I was suggesting type to be
consistent with the `DELETE` method. I guess `adjunctType` is fine for now
(`superType` is really confusing for me) but
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
left it as `adjunctType` for now - could evolve to `supertype` in future
tests added
that's everything addresses i think
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
BTW, I just realised that there is no tests coverage for the new endpoints
`Entity Adjuncts` and `Entity Adjuncts Config`. Can you add that please
@ahgittin ?
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
Cool, thanks @ahgittin. I'm reviewing it right now.
---
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
@tbouron It's up to date. Primarily it is still just the one commit adding
the Adjunct API -- it does have a lot of lines but they are mostly boilerplate
(like a couple hundred just to
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
@ahgittin The description says `This is then just one commit (currently)
which:` but there is still 1000+ additions. Is this up to date and rebase on
master?
---
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
rebased to incorporate deprecation around the multiple config REST classes
and add a tidy API for that
---
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/821
These are the API calls, for reference. The `Entity Policy` and `Entity
Policy Config` resources shown at bottom are now redundant (and deprecated).
10 matches
Mail list logo
