[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-28 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-202473461 Yes, guava is included and swagger works with the newer version. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-28 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-202456707 this conflicts w #55 but it's easy to resolve; done so in https://github.com/ahgittin/brooklyn-server/commit/b49bb07cd35eaba6a5762de1c3f988d9239de613 (which i

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-28 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-202451060 is guava 18 included in the osgi build? maybe worth a check it's not being too smart and trying to fetch that from the internet if not in the local maven

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-28 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/56#discussion_r57585442 --- Diff: utils/rest-swagger/pom.xml --- @@ -85,80 +76,19 @@ javax.ws.rs jsr311-api

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-19 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-197808496 Re guava version change - haven't looked at the specific API changes between versions, but would expect that they would lead to a compile error if something used

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-11 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-195304238 Forcing a rebuild. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-11 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-195303898 Had the same failure this morning, but after pulling latest changes and rebuilding it went away. --- If your project is set up for it, you can reply to this

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-11 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-195276712 simple to fix, i guess the felix error messages have changed. change `OsgiVersionMoreEntityTest:282` from try { Entity

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-11 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-195273274 test failure looks related: ``` 2016-03-11 08:40:51,463 INFO TESTNG FAILED: "Surefire test" -

[GitHub] brooklyn-server pull request: [OSGi] Enable Swagger

2016-03-11 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-server/pull/56#issuecomment-195271264 Apart from guava and felix version bumps this looks good. Felix version bump seems fine. Guava however... Have you checked what from 16 (jclouds) and