Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/87
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202781464
updated https://github.com/ahgittin/brooklyn-server/tree/all-osgi with
everything including this and conflicts resolved. building and testing it now.
---
If y
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202741651
It was due to a missing commit 271d76ba08f411cb35ac85327a831c27b8276be6,
had to force push to include it.
---
If your project is set up for it, you can reply to
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202506959
Actually the build failed when it got to the osgi init bundle (I spoke too
soon, seeing core pass):
```
[INFO] Brooklyn OSGi init ..
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202470485
Not basing on previous PRs because the changes in the PR get lost, harder
to review.
---
If your project is set up for it, you can reply to this email and have y
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202470195
Jenkins build failure due to the branch being based on master instead of
previous PRs. Gave up piling one on the other :) - that's why there are minor
merge confl
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202469982
builds fine for me so i think it's just a case that this has dependencies
which aren't included in the PR
@neykov curious why you didn't build on the de
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202466772
code looks nice and elegant. the jenkins compile failure is suspicious.
building on my machine now.
personally don't like the name "container framewor
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202464979
config conflicts with some of the others, i think easily fixed in
https://github.com/ahgittin/brooklyn-server/commit/b6b5fb62cec79a919dd00f4042d857337104ad75,
b
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/87
[OSGi] Graceful shutdown
Implement shutdown handler, call shutdown hooks at the appropriate time.
You can merge this pull request into a Git repository by running:
$ git pull https://git
10 matches
Mail list logo
