[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-10 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66581776 --- Diff: software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/WinRmTool.java --- @@ -46,7 +46,7 @@ ConfigKey PROP_HO

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-10 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66580748 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -49,15 +50,27 @@ public v

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-10 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66579605 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -49,15 +50,27 @@ public

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-08 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66246994 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -49,15 +50,29 @@ public v

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-08 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66244197 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java --- @@ -321,12 +332,21 @@ pub

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-08 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66239387 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -49,15 +50,29 @@ public

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-08 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66239158 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java --- @@ -321,12 +332,21 @@ pu

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-06 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r65900734 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -49,15 +50,28 @@ public

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

2016-06-06 Thread nakomis
Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r65900017 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java --- @@ -321,12 +332,22 @@ pub