[GitHub] brooklyn-server pull request #196: Close streams after usage

2016-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server pull request #196: Close streams after usage

2016-06-15 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/196#discussion_r67138867 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/crypto/SecureKeys.java --- @@ -78,11 +78,11 @@ public static X509Principal getX509Princi

[GitHub] brooklyn-server pull request #196: Close streams after usage

2016-06-14 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/196#discussion_r67031965 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBomScanner.java --- @@ -268,7 +268,7 @@ private void addLibraryDetails(

[GitHub] brooklyn-server pull request #196: Close streams after usage

2016-06-14 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/196#discussion_r67030921 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/crypto/SecureKeys.java --- @@ -78,11 +78,11 @@ public static X509Principal getX509Principa

[GitHub] brooklyn-server pull request #196: Close streams after usage

2016-06-14 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/196#discussion_r67019434 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/crypto/SecureKeys.java --- @@ -78,11 +78,11 @@ public static X509Principal getX509Princi

[GitHub] brooklyn-server pull request #196: Close streams after usage

2016-06-14 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/196#discussion_r67018475 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBomScanner.java --- @@ -268,7 +268,7 @@ private void addLibraryDetail

[GitHub] brooklyn-server pull request #196: Close streams after usage

2016-06-14 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/196#discussion_r67017851 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/AbstractYamlTest.java --- @@ -125,7 +125,7 @@ protected Entity createA

[GitHub] brooklyn-server pull request #196: Close streams after usage

2016-06-13 Thread neykov
GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-server/pull/196 Close streams after usage Fixes https://builds.apache.org/job/brooklyn-master-windows/151/console You can merge this pull request into a Git repository by running: $ git pull https://gi