Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69442254
--- Diff:
launcher/src/test/java/org/apache/brooklyn/launcher/blueprints/Windows7zipBlueprintLiveTest.java
---
@@ -81,7 +81,7 @@ public void
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69441816
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindEntityTest.java
---
@@ -310,7 +310,7 @@ public void testEntityTags()
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69441669
--- Diff:
launcher/src/test/java/org/apache/brooklyn/launcher/blueprints/Windows7zipBlueprintLiveTest.java
---
@@ -81,7 +81,7 @@ public void
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69440147
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -100,30 +103,36 @@
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69440473
--- Diff: core/src/main/java/org/apache/brooklyn/core/entity/Entities.java
---
@@ -655,34 +677,112 @@ public static boolean isDescendant(Entity
Github user robertgmoss commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/218#discussion_r69440113
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -100,30 +103,36 @@
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/218
Yaml entity refs: support $brooklyn:self()
- Adds proper test coverage
- Fixes sibling/descendant/ancestor so will never return self
You can merge this pull request into a Git
