[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/852 ---

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-12 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r144296911 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -1808,6 +1808,42 @@ public void

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-12 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r144315009 --- Diff: launcher/src/test/resources/rebind-test-empty-catalog.bom --- @@ -0,0 +1,25 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-12 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r144315802 --- Diff: launcher/src/test/java/org/apache/brooklyn/launcher/AbstractBrooklynLauncherRebindTest.java --- @@ -0,0 +1,183 @@ +/* + *

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-12 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r144296174 --- Diff: api/src/main/java/org/apache/brooklyn/api/catalog/BrooklynCatalog.java --- @@ -213,6 +213,17 @@ void addItem(CatalogItem item);

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-12 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r144297930 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogInitialization.java --- @@ -128,164 +146,255 @@ public void

[GitHub] brooklyn-server pull request #852: Merge initial catalog and persisted catal...

2017-10-05 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/852#discussion_r142992671 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindCatalogEntityTest.java --- @@ -1,153 +0,0 @@ -/* - * Licensed to