[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/913 ---

[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-11 Thread alasdairhodge
Github user alasdairhodge commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/913#discussion_r156087749 --- Diff: core/src/main/java/org/apache/brooklyn/location/localhost/LocalhostMachineProvisioningLocation.java --- @@ -268,22 +266,15 @@

[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-11 Thread alasdairhodge
Github user alasdairhodge commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/913#discussion_r156087793 --- Diff: core/src/main/java/org/apache/brooklyn/location/ssh/SshMachineLocation.java --- @@ -1104,4 +1013,36 @@ public String findPassword()

[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-11 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/913#discussion_r156085895 --- Diff: core/src/main/java/org/apache/brooklyn/location/ssh/SshMachineLocation.java --- @@ -1104,4 +1013,36 @@ public String findPassword() {

[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-11 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/913#discussion_r156085783 --- Diff: core/src/main/java/org/apache/brooklyn/location/localhost/LocalhostMachineProvisioningLocation.java --- @@ -268,22 +266,15 @@ public

[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-11 Thread alasdairhodge
Github user alasdairhodge commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/913#discussion_r156050830 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractMachineLocation.java --- @@ -0,0 +1,131 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-11 Thread alasdairhodge
Github user alasdairhodge commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/913#discussion_r156030790 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractMachineLocation.java --- @@ -0,0 +1,139 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-11 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/913#discussion_r156030583 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractMachineLocation.java --- @@ -0,0 +1,139 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-08 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/913#discussion_r155803922 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractMachineLocation.java --- @@ -0,0 +1,131 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #913: AbstractMachineLocation base class

2017-12-08 Thread alasdairhodge
GitHub user alasdairhodge opened a pull request: https://github.com/apache/brooklyn-server/pull/913 AbstractMachineLocation base class Introduces `AbstractMachineLocation` base class to hold responsibilities that may otherwise be duplicated between `SshMachineLocation` and