Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/913
---
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/913#discussion_r156087749
--- Diff:
core/src/main/java/org/apache/brooklyn/location/localhost/LocalhostMachineProvisioningLocation.java
---
@@ -268,22 +266,15 @@
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/913#discussion_r156087793
--- Diff:
core/src/main/java/org/apache/brooklyn/location/ssh/SshMachineLocation.java ---
@@ -1104,4 +1013,36 @@ public String findPassword()
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/913#discussion_r156085895
--- Diff:
core/src/main/java/org/apache/brooklyn/location/ssh/SshMachineLocation.java ---
@@ -1104,4 +1013,36 @@ public String findPassword() {
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/913#discussion_r156085783
--- Diff:
core/src/main/java/org/apache/brooklyn/location/localhost/LocalhostMachineProvisioningLocation.java
---
@@ -268,22 +266,15 @@ public
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/913#discussion_r156050830
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/AbstractMachineLocation.java
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/913#discussion_r156030790
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/AbstractMachineLocation.java
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/913#discussion_r156030583
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/AbstractMachineLocation.java
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/913#discussion_r155803922
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/AbstractMachineLocation.java
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the
GitHub user alasdairhodge opened a pull request:
https://github.com/apache/brooklyn-server/pull/913
AbstractMachineLocation base class
Introduces `AbstractMachineLocation` base class to hold responsibilities
that may otherwise be duplicated between `SshMachineLocation` and
10 matches
Mail list logo