Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r48628343
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1608,7 +1608,36 @@ protected SshMachi
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r48627987
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1608,7 +1608,36 @@ protected SshMachi
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r48627640
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1608,7 +1608,36 @@ protected SshMachi
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r48562878
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1608,7 +1606,35 @@ protected SshMachi
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r48562111
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1608,7 +1606,35 @@ protected SshMachi
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46675443
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1608,7 +1606,35 @@ protected SshMac
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#issuecomment-161941393
+1, apart from the potentially misleading comment.
Will merge after Jenkins is happy with the build.
---
If your project is set up for it, you can reply
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#issuecomment-161941117
Looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46672018
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2537,28 +2563,53 @@ protected LoginCr
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46672025
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2537,28 +2563,53 @@ protected LoginCr
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46672008
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2692,7 +2743,7 @@ protected void wait
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46671528
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -1608,7 +1606,35 @@ protected SshMachi
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46664936
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2537,28 +2563,53 @@ protected Login
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#issuecomment-161827503
Looks good, with one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1087
JcloudsLocation: fix waitForWinRm, for alternate WinRmTool
Previously JcloudsLocation was hard-coded to use the winrm4j directly,
in waitForWinrmAvailable. Now it follows the same p
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46630734
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2537,28 +2563,53 @@ protected LoginCr
17 matches
Mail list logo
