Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1130#discussion_r49433075
--- Diff:
brooklyn-server/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
@@ -376,7 +378,7 @@ else f
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1130#issuecomment-170855532
Thanks @iyovcheva - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1130#issuecomment-170585001
@iyovcheva please see
https://github.com/iyovcheva/incubator-brooklyn/pull/1, for some suggested
improvements to the tests (and some additional fixes I ne
Github user iyovcheva commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1130#discussion_r49190899
--- Diff:
brooklyn-server/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ExternalConfigYamlTest.java
---
@@ -108,6 +110,34
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1130#discussion_r49080187
--- Diff:
brooklyn-server/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
@@ -391,18 +396,61 @@ else
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1130#discussion_r49079996
--- Diff:
brooklyn-server/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
@@ -391,18 +396,61 @@ else
