Github user andreaturli closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-173949034
I'll close this PR and open a simplified version of it where I will
- remove JsonNode from API interfaces
- refactor consistently `toString`, `ha
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-172898775
@andreaturli The plan for #1140 (at least currently) is to try to move the
changes in the existing modules instead of forking them. It will also ease
mergin
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-172874651
@ahgittin thanks for your review, I think this PR clashes with
https://github.com/apache/incubator-brooklyn/pull/1140
Happy to close this and work
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-172872188
> @JsonSerialize introduces another deps on jackson (databind) which I
think it doesn't need to be there as it really depends on the ObjectMapper
settings
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-172512885
@andreaturli Could you resolve the merge conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-171006809
See #1139 for a solution for dependencies.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-170968512
@sjcorbett @ahgittin Yes, the ```dependencies''' file is generated for
dependency control across versions. I think for now is not useful and I'll
remove it in
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169665520
thanks @ahgittin for comments
- `Object.hashCode` or `Objects.equals` from Guava are nicer but I wanted
to avoid to have a direct dependency on Guav
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169663939
why move `HighAvailabilityMode` and `ManagementNodeState` to different
packages? that will break backwards compatibility (and so should be in README
if w
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169661760
i prefer `Objects.hashCode` over autogenerated and use of
`Objects.equal(.., ..)` over three-part check but no strong feeling. i have no
preference on th
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169661215
are you sure the `LocationApi` methods aren't used in the current UI ?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169661022
using https://github.com/apache/incubator-brooklyn/pull/1127/files?w=1 you
can at least see the changes in github. (@andreaturli worth checking what your
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169656652
Likewise with AccessSummary.equals could do the type checks and then
`Objects.equals(this.locationProvisioningAllowed,
that.locationProvisioningAllowed)
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169656161
brooklyn-server/rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/AccessSummary.java
I think it would be better to continue using `Objects.h
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169654793
brooklyn-server/rest/rest-api/generated/swagger-api-spec/retrofit2.json:
What is this file for? Why does it refer to "petstore"?
```
{
"l
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169654547
brooklyn-server/karaf/features/src/main/history/dependencies.xml:
Do you really want to remove `BROOKLYN_VERSION` from
---
If your project is set up
GitHub user andreaturli reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1127
improvements to rest-api module
Initial work to simplify the rest server:
- remove `JsonNode` from API interfaces
- refactor consistently `toString`and `hashCode` and
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169362282
In org.apache.brooklyn.rest.domain.LocationSummaryTest.testSerializeToJSON.
---
If your project is set up for it, you can reply to this email and have yo
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169362167
@andreaturli I'll take a look. The Jenkins failure is valid:
```
java.lang.AssertionError: expected / found:
[{"id":"123","name":"localhost","
GitHub user andreaturli opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1127
improvements to rest-api module
Initial work to simplify the rest server:
- remove `JsonNode` from API interfaces
- refactor consistently `toString`and `hashCode` and `e
21 matches
Mail list logo
