[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...

2016-01-29 Thread nakomis
GitHub user nakomis reopened a pull request: https://github.com/apache/incubator-brooklyn/pull/1168 Uses externally accessible address for main uri of controller Previously, if deploying to BYON AWS instances, the internal IP address was being displayed in the main.uri for the Contr

[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...

2016-01-29 Thread nakomis
Github user nakomis closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] incubator-brooklyn pull request: Generate config/effector descript...

2016-01-29 Thread bostko
Github user bostko commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1176#issuecomment-176651040 @tbouron @neykov if you had noticed docs were loading from a json file for a while. However I noticed the experience wasn't so smooth on production and

[GitHub] incubator-brooklyn pull request: Create Password Sensor

2016-01-29 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1169#issuecomment-176694764 I think I've made all the changes that I've been asked for. If everything is ok then please let me know if I should squash my commits before merging.

Re: Brooklyn Daemon Solution

2016-01-29 Thread John McCabe
[bumping so aleks can see the thread] On Thu, 28 Jan 2016 at 16:41 Andrew Kennedy < andrew.kenn...@cloudsoftcorp.com> wrote: > Or what about running a Brooklyn Docker image as a systemd service! > > - http://container-solutions.com/running-docker-containers-with-systemd/ > - https://github.com/ib

[GitHub] incubator-brooklyn pull request: Improvements to brooklyn-server/r...

2016-01-29 Thread CMoH
Github user CMoH commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1177#issuecomment-176781901 Feel free to merge before #1140. That PR already has merge conflicts, that will more time to resolve anyway. I think there's no point holding this back in the

[GitHub] incubator-brooklyn pull request: Improvements to brooklyn-server/r...

2016-01-29 Thread CMoH
Github user CMoH commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1177#discussion_r51266731 --- Diff: brooklyn-server/karaf/features/src/main/history/dependencies.xml --- @@ -0,0 +1,103 @@ + --- End diff -- I have removed t

[GitHub] incubator-brooklyn pull request: Improvements to brooklyn-server/r...

2016-01-29 Thread andreaturli
Github user andreaturli commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1177#issuecomment-176789869 thanks @CMoH Anyway I see problems with jenkins with this PR as well. I'll try closing and reopening it to force a new build if it was just tempora

[GitHub] incubator-brooklyn pull request: Improvements to brooklyn-server/r...

2016-01-29 Thread andreaturli
GitHub user andreaturli reopened a pull request: https://github.com/apache/incubator-brooklyn/pull/1177 Improvements to brooklyn-server/rest/rest-api - remove duplication of jackson and jackson2 on brooklyn project - refactor pojos to have a consistent `toString`, `hashCode` and

[GitHub] incubator-brooklyn pull request: Improvements to brooklyn-server/r...

2016-01-29 Thread andreaturli
Github user andreaturli closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

Re: Brooklyn Daemon Solution

2016-01-29 Thread Aleksandr Vasilev
Hi Alex, The advantages of having a native daemon in my opinion are: 1. Proper detaching from the parent process, making daemon more secure 2. Proper detaching from any TTYs, making daemon even more secure 3. Proper redirection of all file descriptors, helps with debugging and logging 4. More port

[GitHub] incubator-brooklyn pull request: Generate config/effector descript...

2016-01-29 Thread iyovcheva
Github user iyovcheva commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1176#discussion_r51270639 --- Diff: brooklyn-server/server-cli/src/main/java/org/apache/brooklyn/cli/ItemLister.java --- @@ -98,88 +115,150 @@ public Void call() throws

[GitHub] incubator-brooklyn pull request: Generate config/effector descript...

2016-01-29 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1176#issuecomment-176809380 @bostko Didn't notice that. Let's not reintroduce a slow process then. However, I quite like the @iyovcheva's idea of generate the `JS` **and** ` J

Re: Brooklyn Daemon Solution

2016-01-29 Thread John McCabe
Hi Aleksandr, > 1. Proper detaching from the parent process, making daemon more secure > 2. Proper detaching from any TTYs, making daemon even more secure Regarding the security implications when using a script vs a binary, could you explain? > 3. Proper redirection of all file descriptors, hel

Re: Brooklyn Daemon Solution

2016-01-29 Thread Aleksandr Vasilev
> Regarding the security implications when using a script vs a binary, could you explain? It's not the difference between binary vs script, it's the different approach at launching the process. In my daemon I make sure child process is detached from the parent and can't get hold of any terminal ses

Re: Brooklyn Daemon Solution

2016-01-29 Thread Alex Heneveld
Aleksandr, Is there anyone who needs this level of security? In my experience a service calling a shell script is common, and in the cases where someone needs something stronger they can build it. They possibly have custom requirements there in any case. Bear in mind a daemon is going to i

Re: Brooklyn Daemon Solution

2016-01-29 Thread Aleksandr Vasilev
Alex, In this case, I agree that wrapping java command in a service script may be the best choice. Best Regards, Aleksandr Vasilev DevOps Engineer | Cloudsoft Corporation On 29 January 2016 at 20:50, Alex Heneveld wrote: > > Aleksandr, > > Is there anyone who needs this level of security? In

[GitHub] incubator-brooklyn pull request: Improvements to brooklyn-server/r...

2016-01-29 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1177#discussion_r51308146 --- Diff: brooklyn-server/rest/rest-server/src/main/java/org/apache/brooklyn/rest/util/json/BrooklynJacksonJsonProvider.java --- @@ -137,25 +13

[GitHub] incubator-brooklyn pull request: Improvements to brooklyn-server/r...

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1177#issuecomment-176945957 strange test failure. can't tell if it is related to this or a new intermittent one. --- If your project is set up for it, you can reply to this email a

[GitHub] incubator-brooklyn pull request: Generate config/effector descript...

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1176#issuecomment-176947214 test failure is clearly unrelated, maybe close and reopen to run again. meanwhile we should look at this /cc @aledsage : ``` org.apac

[GitHub] incubator-brooklyn pull request: Generate config/effector descript...

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1176#issuecomment-177017397 (easily fixed - the test was doing an immediate assert on something happening in another thread; PR to follow; @iyovcheva give it an hour or so for the ot

[GitHub] incubator-brooklyn pull request: fix failing (time sensitive) test

2016-01-29 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1178 fix failing (time sensitive) test solves the nondet test failure observed in #1176 . and improve the "Asserts.eventually" routines which that used, adding a new simpler eve

[GitHub] incubator-brooklyn pull request: fix failing (time sensitive) test

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1178#issuecomment-177048278 seems to fix nondet test and checks pass so i'm going to merge; @aledsage or @geomacy (since you did a lot of the work on `Asserts`) could you review afte

[GitHub] incubator-brooklyn pull request: add getting started vagrant env t...

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1170#issuecomment-177050161 great stuff. may need more review /cc @drigodwin @aledsage but i'm going to merge so it doesn't have to be ported to new repos --- If your project is se

[GitHub] incubator-brooklyn pull request: fix the nondet cancellation test ...

2016-01-29 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1179 fix the nondet cancellation test race observed previously the "fix" in #1171 didn't do everything, but provided enough clues to see the other culprit which this fixes, i think You can

[GitHub] incubator-brooklyn pull request: fix the nondet cancellation test ...

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1179#issuecomment-177052693 CTR as this is simple test-only and it's interfering with other PRs. @aledsage this is one i'd really like you to be aware of, it's quite subtle

[GitHub] incubator-brooklyn pull request: Fix/deferred location config

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1093#issuecomment-177053294 @alasdairhodge ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] incubator-brooklyn pull request: Getting Started with Vagrant upda...

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1144#issuecomment-177058516 like the concertina. would be nice if i could click anywhere in the title bar, not just on text. not sure about the glossary. cute at first but

[GitHub] incubator-brooklyn pull request: add getting started vagrant env t...

2016-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: Getting Started with Vagrant upda...

2016-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: Update storm remove redundant dep...

2016-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: fix failing (time sensitive) test

2016-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: fix the nondet cancellation test ...

2016-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: Port parameters docs and fixes

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1166#issuecomment-177059815 merging @shartzel i'd like you to have a look at this -- feels like a few more things like this (examples and ease-of-use tweaks) in the right pla

[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-177059968 ugly failure this time. not one i've come across. probably nondet. @nakomix you're not having luck! ``` org.apache.brooklyn.AssemblyTest.ch

[GitHub] incubator-brooklyn pull request: Uses externally accessible addres...

2016-01-29 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1168#issuecomment-177060034 @nakomis could you spearhead the others incl @sjcorbett @aledsage @grkvlt to determine what we want to do wrt public/private? i don't think we can

[GitHub] incubator-brooklyn pull request: Create Password Sensor

2016-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: Port parameters docs and fixes

2016-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Build failed in Jenkins: incubator-brooklyn-master-build #744

2016-01-29 Thread Apache Jenkins Server
See Changes: [duncan.godwin] Getting Started with Vagrant updates - for review [duncan.godwin] Adding Vagrant Temp URL [duncan.godwin] Updated blueprints + fixes [duncan.godwin] Updated blueprints and managing [duncan