Build failed in Jenkins: brooklyn-master-windows #27

2016-03-24 Thread Apache Jenkins Server
See 

--
[...truncated 28262 lines...]
at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:108)
at 
org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:111)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)


Results :

Failed tests: 
  
SoftwareProcessPersisterInMemorySizeIntegrationTest>BrooklynMementoPersisterInMemorySizeIntegrationTest.testPersistenceVolumeFastNoTrigger:67->BrooklynMementoPersisterInMemorySizeIntegrationTest.doTestPersistenceVolume:95
 should have written less than 150k, wrote 161444 expected [true] but found 
[false]

Tests run: 155, Failures: 1, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [ 55.863 s]
[INFO] Brooklyn Server Root ... SUCCESS [  0.343 s]
[INFO] Brooklyn Parent Project  SUCCESS [  9.164 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [ 10.788 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  6.115 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 34.815 s]
[INFO] Brooklyn API ... SUCCESS [  4.252 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.776 s]
[INFO] CAMP Base .. SUCCESS [  5.770 s]
[INFO] Brooklyn Test Support .. SUCCESS [  2.786 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [ 14.723 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  0.747 s]
[INFO] CAMP Server  SUCCESS [ 14.395 s]
[INFO] CAMP Server Jersey . SUCCESS [ 12.309 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  4.287 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  1.324 s]
[INFO] Brooklyn Core .. SUCCESS [04:38 min]
[INFO] Brooklyn Policies .. SUCCESS [01:30 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [ 14.394 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 11.905 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  1.018 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 30.608 s]
[INFO] Brooklyn Software Base . FAILURE [01:31 min]
[INFO] Brooklyn CAMP REST API . SKIPPED
[INFO] Brooklyn Hazelcast Storage . SKIPPED
[INFO] Brooklyn Launcher Common ... SKIPPED
[INFO] Brooklyn REST API .. SKIPPED
[INFO] Brooklyn REST Resources  SKIPPED
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn REST Client ... SKIPPED
[INFO] Brooklyn REST Server with Jersey dependencies .. SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Distro .. SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn Monitoring Software Entities .. SKIPPED
[INFO] Brooklyn QA  SKIPPED
[INFO] 

Jenkins build is back to normal : brooklyn-master-build #88

2016-03-24 Thread Apache Jenkins Server
See 



Build failed in Jenkins: brooklyn-server-master #19

2016-03-24 Thread Apache Jenkins Server
See 

Changes:

[aled.sage] Tidy test imports

[aled.sage] Upgrade winrm4j to 0.3.3

[aled.sage] deserializingClassRenames: include TestEntity etc

[aled.sage] softwareProcess.restart: even on error, set expected=running

--
[...truncated 52268 lines...]
[INFO] Brooklyn REST Client ... SUCCESS [ 18.010 s]
[INFO] Brooklyn REST Server with Jersey dependencies .. SUCCESS [01:01 min]
[INFO] Brooklyn Test Framework  SUCCESS [01:14 min]
[INFO] Brooklyn OSGi init . SUCCESS [  6.200 s]
[INFO] Brooklyn Karaf . SUCCESS [  1.600 s]
[INFO] Brooklyn Karaf Features  SUCCESS [  2.663 s]
[INFO] Brooklyn Karaf Distro .. SUCCESS [ 25.807 s]
[INFO] Brooklyn Karaf Shell Commands .. SUCCESS [  3.811 s]
[INFO] Brooklyn Karaf pax-exam itest .. SUCCESS [ 43.576 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 20:38 min
[INFO] Finished at: 2016-03-25T01:23:32+00:00
[INFO] Final Memory: 161M/624M
[INFO] 
[JENKINS] Archiving 
 to 
org.apache.brooklyn/brooklyn-policy/0.9.0-SNAPSHOT/brooklyn-policy-0.9.0-SNAPSHOT.pom
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-policy/0.9.0-SNAPSHOT/brooklyn-policy-0.9.0-SNAPSHOT.jar
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-policy/0.9.0-SNAPSHOT/brooklyn-policy-0.9.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-policy/0.9.0-SNAPSHOT/brooklyn-policy-0.9.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-policy/0.9.0-SNAPSHOT/brooklyn-policy-0.9.0-SNAPSHOT-test-sources.jar
No artifacts from brooklyn-server-master » Brooklyn Policies #18 to compare, so 
performing full copy of artifacts
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-test-framework/0.9.0-SNAPSHOT/brooklyn-test-framework-0.9.0-SNAPSHOT.pom
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-test-framework/0.9.0-SNAPSHOT/brooklyn-test-framework-0.9.0-SNAPSHOT.jar
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-test-framework/0.9.0-SNAPSHOT/brooklyn-test-framework-0.9.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-test-framework/0.9.0-SNAPSHOT/brooklyn-test-framework-0.9.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-test-framework/0.9.0-SNAPSHOT/brooklyn-test-framework-0.9.0-SNAPSHOT-test-sources.jar
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-storage-hazelcast/0.9.0-SNAPSHOT/brooklyn-storage-hazelcast-0.9.0-SNAPSHOT.pom
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-storage-hazelcast/0.9.0-SNAPSHOT/brooklyn-storage-hazelcast-0.9.0-SNAPSHOT.jar
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-storage-hazelcast/0.9.0-SNAPSHOT/brooklyn-storage-hazelcast-0.9.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 

 to 
org.apache.brooklyn/brooklyn-storage-hazelcast/0.9.0-SNAPSHOT/brooklyn-storage-hazelcast-0.9.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 

Build failed in Jenkins: brooklyn-library-master #11

2016-03-24 Thread Apache Jenkins Server
See 

Changes:

[sam.corbett] Fix KafkaZooKeeper archive directory name format

--
[...truncated 2046 lines...]
jdk1.7.0_80/bin/jcontrol
jdk1.7.0_80/bin/java
jdk1.7.0_80/bin/servertool
jdk1.7.0_80/bin/idlj
jdk1.7.0_80/bin/javah
jdk1.7.0_80/bin/serialver
jdk1.7.0_80/bin/orbd
jdk1.7.0_80/bin/jsadebugd
jdk1.7.0_80/bin/ControlPanel
jdk1.7.0_80/bin/schemagen
jdk1.7.0_80/bin/apt
jdk1.7.0_80/bin/java-rmi.cgi
jdk1.7.0_80/bin/jps
jdk1.7.0_80/bin/jar
jdk1.7.0_80/bin/jcmd
jdk1.7.0_80/bin/jstatd
jdk1.7.0_80/bin/javadoc
jdk1.7.0_80/bin/xjc
jdk1.7.0_80/bin/jarsigner
jdk1.7.0_80/bin/jstack
jdk1.7.0_80/bin/keytool
jdk1.7.0_80/bin/javafxpackager
jdk1.7.0_80/bin/wsimport
jdk1.7.0_80/bin/jvisualvm
jdk1.7.0_80/bin/policytool
jdk1.7.0_80/bin/jhat
jdk1.7.0_80/bin/javap
jdk1.7.0_80/bin/jmc.ini
jdk1.7.0_80/man/
jdk1.7.0_80/man/man1/
jdk1.7.0_80/man/man1/jinfo.1
jdk1.7.0_80/man/man1/rmid.1
jdk1.7.0_80/man/man1/native2ascii.1
jdk1.7.0_80/man/man1/jcmd.1
jdk1.7.0_80/man/man1/java.1
jdk1.7.0_80/man/man1/jarsigner.1
jdk1.7.0_80/man/man1/keytool.1
jdk1.7.0_80/man/man1/jconsole.1
jdk1.7.0_80/man/man1/extcheck.1
jdk1.7.0_80/man/man1/wsimport.1
jdk1.7.0_80/man/man1/pack200.1
jdk1.7.0_80/man/man1/schemagen.1
jdk1.7.0_80/man/man1/javadoc.1
jdk1.7.0_80/man/man1/rmic.1
jdk1.7.0_80/man/man1/serialver.1
jdk1.7.0_80/man/man1/apt.1
jdk1.7.0_80/man/man1/javah.1
jdk1.7.0_80/man/man1/wsgen.1
jdk1.7.0_80/man/man1/jvisualvm.1
jdk1.7.0_80/man/man1/appletviewer.1
jdk1.7.0_80/man/man1/jsadebugd.1
jdk1.7.0_80/man/man1/orbd.1
jdk1.7.0_80/man/man1/javaws.1
jdk1.7.0_80/man/man1/jdb.1
jdk1.7.0_80/man/man1/jstatd.1
jdk1.7.0_80/man/man1/javap.1
jdk1.7.0_80/man/man1/jhat.1
jdk1.7.0_80/man/man1/xjc.1
jdk1.7.0_80/man/man1/jar.1
jdk1.7.0_80/man/man1/policytool.1
jdk1.7.0_80/man/man1/rmiregistry.1
jdk1.7.0_80/man/man1/idlj.1
jdk1.7.0_80/man/man1/jps.1
jdk1.7.0_80/man/man1/unpack200.1
jdk1.7.0_80/man/man1/tnameserv.1
jdk1.7.0_80/man/man1/jrunscript.1
jdk1.7.0_80/man/man1/jmap.1
jdk1.7.0_80/man/man1/jstack.1
jdk1.7.0_80/man/man1/servertool.1
jdk1.7.0_80/man/man1/javafxpackager.1
jdk1.7.0_80/man/man1/jstat.1
jdk1.7.0_80/man/man1/jmc.1
jdk1.7.0_80/man/man1/javac.1
jdk1.7.0_80/man/ja
jdk1.7.0_80/man/ja_JP.UTF-8/
jdk1.7.0_80/man/ja_JP.UTF-8/man1/
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jinfo.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/rmid.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/native2ascii.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jcmd.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/java.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jarsigner.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/keytool.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jconsole.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/extcheck.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/wsimport.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/pack200.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/schemagen.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/javadoc.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/rmic.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/serialver.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/apt.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/javah.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/wsgen.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jvisualvm.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/appletviewer.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jsadebugd.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/orbd.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/javaws.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jdb.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jstatd.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/javap.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jhat.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/xjc.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jar.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/policytool.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/rmiregistry.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/idlj.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jps.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/unpack200.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/tnameserv.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jrunscript.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jmap.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jstack.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/servertool.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/javafxpackager.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jstat.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/jmc.1
jdk1.7.0_80/man/ja_JP.UTF-8/man1/javac.1
jdk1.7.0_80/include/
jdk1.7.0_80/include/jvmti.h
jdk1.7.0_80/include/classfile_constants.h
jdk1.7.0_80/include/jdwpTransport.h
jdk1.7.0_80/include/jvmticmlr.h
jdk1.7.0_80/include/jni.h
jdk1.7.0_80/include/linux/
jdk1.7.0_80/include/linux/jni_md.h
jdk1.7.0_80/include/linux/jawt_md.h
jdk1.7.0_80/include/jawt.h
jdk1.7.0_80/src.zip
jdk1.7.0_80/THIRDPARTYLICENSEREADME-JAVAFX.txt
jdk1.7.0_80/COPYRIGHT
jdk1.7.0_80/db/
jdk1.7.0_80/db/LICENSE
jdk1.7.0_80/db/RELEASE-NOTES.html
jdk1.7.0_80/db/lib/
jdk1.7.0_80/db/lib/derbyLocale_zh_CN.jar
jdk1.7.0_80/db/lib/derbynet.jar
jdk1.7.0_80/db/lib/derbyLocale_ja_JP.jar
jdk1.7.0_80/db/lib/derbyLocale_ru.jar
jdk1.7.0_80/db/lib/derbyLocale_es.jar
jdk1.7.0_80/db/lib/derbyLocale_it.jar
jdk1.7.0_80/db/lib/derby.jar
jdk1.7.0_80/db/lib/derbytools.jar
jdk1.7.0_80/db/lib/derbyLocale_hu.jar

[GitHub] brooklyn-server pull request: Winrm4j upgrade

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/81


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-library pull request: Fix KafkaZooKeeper archive director...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-library/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-library pull request: Fix: ElasticSearch advertise datast...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-library/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-library pull request: Fix: ElasticSearch advertise datast...

2016-03-24 Thread aledsage
Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-library/pull/23#issuecomment-201085233
  
Jenkins build failure looks like yet another unrelated strange environment 
thing?

```
[FATAL] Non-resolvable parent POM: Could not find artifact 
org.apache.brooklyn:brooklyn-parent:pom:0.9.0-SNAPSHOT and 
'parent.relativePath' points at wrong local POM @ line 24, column 13
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-library pull request: Support disabling http based sensor...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-library/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: Winrm4j upgrade

2016-03-24 Thread aledsage
GitHub user aledsage opened a pull request:

https://github.com/apache/brooklyn-server/pull/81

Winrm4j upgrade

Also see the commit "softwareProcess.restart: even on error, set 
expected=running", and the details in that commit description.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/brooklyn-server winrm4j-upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #81


commit da26fb2a99b334dc8a9b8dc10d9bd960477c0c3e
Author: Aled Sage 
Date:   2016-03-25T00:26:30Z

Tidy test imports

Use com.google.common.collect instead of org.testng.collections

commit 4cad1009ec3d3ca89cc51b656f3613556bdfb1c1
Author: Aled Sage 
Date:   2016-03-25T00:26:49Z

Upgrade winrm4j to 0.3.3

commit d08cda63f0d217a89937e7612988c46ab455d0c1
Author: Aled Sage 
Date:   2016-03-25T00:27:08Z

deserializingClassRenames: include TestEntity etc

commit a0418bfb4805c2f1443e2077d9362127e644ff1f
Author: Aled Sage 
Date:   2016-03-25T00:29:51Z

softwareProcess.restart: even on error, set expected=running

Previously if the restart failed in some way (e.g. an error in the 
launch script or a timeout waiting for serviceUp), we would leave the 
expectedState as “starting”. This meant that serviceUp=false was not
rendered as an error.

Always setting expected=running is better, but is not great. For 
example, if a script fails in restart then we won’t mark the 
entity as onFire if the basic service-up checks still pass. This is
different from the start() behaviour. But then we are doing less than
in start (e.g. in start a script failure could mean that a WAR was not
installed so the simple serviceUp reachability check would not be
sufficient if customize() had failed).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (BROOKLYN-244) Blueprint Composer: text disappears after few seconds

2016-03-24 Thread Aled Sage (JIRA)
Aled Sage created BROOKLYN-244:
--

 Summary: Blueprint Composer: text disappears after few seconds
 Key: BROOKLYN-244
 URL: https://issues.apache.org/jira/browse/BROOKLYN-244
 Project: Brooklyn
  Issue Type: Bug
Reporter: Aled Sage


On Brooklyn 0.9.0-SNAPSHOT...

When I open the Blueprint Composer and start typing (particularly if I've 
pasted a blueprint), then sometimes a few seconds later the text all disappears 
leaving me with a blank text area.

I suspect (talking briefly to Thomas) that it could be refreshing after the 
catalog has finished loading - the longer the catalog takes to be retrieved, 
then the longer the delay before any text is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BROOKLYN-243) MySql stop+restart: timed out waiting for serviceUp (due to enrichers/feeds?)

2016-03-24 Thread Aled Sage (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211037#comment-15211037
 ] 

Aled Sage commented on BROOKLYN-243:


I saw the same thing with RabbitMQ. I deployed a RabbitMQ to GCE, and then I 
ran the script below to repeatedly stop and restart the process (exiting as 
soon as one of the effectors failed). It failed after 46 iterations, with the 
same symptoms as described above.

I'll repeat this again with trace enabled.

{noformat}
#!/bin/bash -e -x

for i in {1..1000}; do 
  echo "Run $i"
  br app oigXiDpI entity QOQJinps stop --param "stopMachineMode=NEVER"
  br app oigXiDpI entity QOQJinps restart --param "restartMachine=false"
done
{noformat}

> MySql stop+restart: timed out waiting for serviceUp (due to enrichers/feeds?)
> -
>
> Key: BROOKLYN-243
> URL: https://issues.apache.org/jira/browse/BROOKLYN-243
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> Using Brooklyn 0.9.0-SNAPSHOT, I deployed MySqlNode to a BYON VM in AWS (on 
> CentOS 6.5).
> My automated test script invoked stop() on the MySqlNode to just stop the 
> process, and then invoked restart().
> The restart() successfully restarted the process, but then the post-restart 
> task timed out waiting for SERVICE_UP.
> Looking at the sensor values, I think (*) it showed:
> {noformat}
> mysql.queries.perSec.fromMysql: 0.29
> service.process.isRunning:  true
> service.state:  STARTING
> service.isUp:   false
> service.notUp.indicators:   {}
> {noformat}
> (*) unfortunately the automated test script changed the state of the entity 
> before I had copy-pasted all the values. But I'm pretty sure it was in this 
> state.
> This suggests that the feed was doing its job (having populated isRunning and 
> queries.perSec) - the log confirmed that this was being executed periodically.
> It suggests that the notUp.indicators had been updated correctly by the 
> enricher.
> But that the 
> {{ServiceNotUpLogic.newEnricherForServiceUpIfNotUpIndicatorsEmpty()}} had 
> somehow not set the serviceUp.
> This is very surprising! The entity was previously up; the enricher has been 
> there for a while. I therefore don't think it's a race with the first value 
> being missed or anything like that.
> A (probably unrelated) worry I have about this code is for stop(): we stop 
> the feeds (but we don't wait for the feeds to be terminated), and then set 
> isRunning to false. There is a race, where we could leave the entity saying 
> isRunning=true even though the process is stopped.
> This is not reproducible; I've only ever seen it once.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: Skip to next bundle on predicate fai...

2016-03-24 Thread geomacy
Github user geomacy commented on the pull request:

https://github.com/apache/brooklyn-server/pull/78#issuecomment-201020297
  
Trying a recycle 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: Skip to next bundle on predicate fai...

2016-03-24 Thread geomacy
GitHub user geomacy reopened a pull request:

https://github.com/apache/brooklyn-server/pull/78

Skip to next bundle on predicate failure.

Without this change, if the predicate fails, the code flow just picks the 
next predicate to check,
when really we want to skip to checking the next bundle.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/geomacy/brooklyn-server osgis-loop-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit 71932b2de5ef53c334353d2f6280766f66fe0657
Author: Geoff Macartney 
Date:   2016-03-23T16:54:21Z

Skip to next bundle on predicate failure.

Without this change, if the predicate fails, the code flow just picks the 
next predicate to check,
when really we want to skip to checking the next bundle.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: Skip to next bundle on predicate fai...

2016-03-24 Thread geomacy
Github user geomacy closed the pull request at:

https://github.com/apache/brooklyn-server/pull/78


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-docs pull request: Details about using CredSSP in Windows

2016-03-24 Thread bostko
GitHub user bostko opened a pull request:

https://github.com/apache/brooklyn-docs/pull/36

Details about using CredSSP in Windows

@aledsage can you review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bostko/brooklyn-docs winrm_port_sensor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-docs/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 665795368236e47ff6dc194875be5ecb6f9a2995
Author: Valentin Aitken 
Date:   2016-03-24T19:29:27Z

Details about using CredSSP in Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-dist pull request: use JAVA_HOME if available when starti...

2016-03-24 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request:

https://github.com/apache/brooklyn-dist/pull/25#discussion_r57371163
  
--- Diff: dist/src/main/dist/bin/brooklyn ---
@@ -48,4 +48,10 @@ 
JAVA_OPTS="-Dbrooklyn.location.localhost.address=127.0.0.1 ${JAVA_OPTS}"
 
 # start Brooklyn
 echo $$ > "$ROOT/pid_java"
-exec java ${JAVA_OPTS} -cp "${INITIAL_CLASSPATH}" 
org.apache.brooklyn.cli.Main "$@"
+if [ -n "$JAVA_HOME" ] ; then
--- End diff --

check that `JAVA_HOME` is a path:
```
if [[ -n "$JAVA_HOME" && -d "$JAVA_HOME" ]] ; then
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CLI packaging problem

2016-03-24 Thread John McCabe
And a reminder that https://github.com/apache/brooklyn-client/pull/11 will
need to be merged to ensure Jenkins builds the current code in the repo
rather than the cached copy in godeps/_workspace

On Thu, 24 Mar 2016 at 18:47 Geoff Macartney <
geoff.macart...@cloudsoftcorp.com> wrote:

>
> The brooklyn-client Apache build adds the CLI binaries in a zip file to
> the Apache Jenkins.
>
> E.g. See links at end of
> https://builds.apache.org/view/Brooklyn/job/brooklyn-client-master/9/console
>
> …
> Uploaded:
> https://repository.apache.org/content/repositories/snapshots/org/apache/brooklyn/brooklyn-client-cli/0.9.0-SNAPSHOT/brooklyn-client-cli-0.9.0-20160321.101320-2-bin.zip
> <
> https://repository.apache.org/content/repositories/snapshots/org/apache/brooklyn/brooklyn-client-cli/0.9.0-SNAPSHOT/brooklyn-client-cli-0.9.0-20160321.101320-2-bin.zip
> >
>
>
>
> All you would need to do would be to add that to the same location as the
> main Brooklyn zip.
>
> As discussed with Duncan, for convenience it would be good to unpack the
> zip file before uploading it so users could just get the right binary
> without having to download the zip.  I’d just put up the Windows, Mac and
> Linux builds.
>
>
>
>
> 
> Gnu PGP key - http://is.gd/uI
>
>
> > On 24 Mar 2016, at 18:32, Aled Sage  wrote:
> >
> > +1
> >
> > We won't have the brooklyn-client RPM in time for a 0.9.0 release, but
> we should definitely work on that afterwards.
> >
> > ---
> > We can add a download link for the CLI to
> http://brooklyn.apache.org/download/index.html, once there is an official
> apache release of the CLI.
> >
> > I believe the release manager copies the final artifacts to the right
> place in apache, giving us the nice download links. We can do the same for
> the CLI, as long as we have an appropriate artifact to put there from the
> 0.9.0 release process.
> >
> > Aled
> >
> >
> > On 24/03/2016 18:12, John McCabe wrote:
> >> +1 Geoff
> >> Having a CLI download alongside the brooklyn release as well makes
> sense,
> >> like the web ui the user should be able to run the client from their
> local
> >> machine to connect to a remote brooklyn instance (which is supported and
> >> imho preferable since it keeps you off the server), bundling it only in
> the
> >> release means the user has to either copy br from the node brooklyn is
> >> running on or download a full brooklyn release only to get at the cli
> tool
> >> which seems unnecessary.
> >> I'd be inclined to package it (rpm, brew etc) separately as well -
> >> installing the brooklyn rpm would pull in the client as a dep (will
> need to
> >> be in a repo to make this painless). For a client install you could use
> >> brew/port on OSX, possibly Chocolatey on Windows.
> >>
> >> On Thu, 24 Mar 2016 at 17:56 Geoff Macartney <
> >> geoff.macart...@cloudsoftcorp.com> wrote:
> >>
> >>> I suggest adding the CLI artifacts to the release alongside the
> brooklyn
> >>> zip.  At the same time as the brooklyn zip is copied to the release
> >>> location, get the CLI artifact out of the Maven repository, for good
> >>> measure unpack it, and upload the individual builds of the CLI tool to
> the
> >>> same location.  Then update docs to explain how to download it too.
> >>>
> >>> Remember the vagrant approach is really there as a Getting Started
> track,
> >>> it’s not the typical path for using Brooklyn in anger.
> >>>
> >>>
> >>> 
> >>> Gnu PGP key - http://is.gd/uI
> >>>
> >>>
>  On 24 Mar 2016, at 17:51, Duncan Godwin <
> duncan.god...@cloudsoftcorp.com>
> >>> wrote:
>  Hi All,
> 
>  I've found a problem with the way the CLI is distributed for Brooklyn.
> >>> It's
>  included in the release files which means when an initial user uses
> the
>  vagrant getting started guide, the CLI is inside the vagrant box, not
> on
>  the users machine. As there's no download link to the CLI anywhere it
> >>> means
>  the flow of the documentation no longer works.
> 
>  The solutions to this could be:
> 
>  * Add additional downloads for each of the CLI versions somewhere
>  * Extract the correct CLI from the vagrant box to the users machine in
> >>> the
>  instructions
>  * Download the CLI bundle and extract and install the correct one
> 
>  What are everyone's thoughts?
> 
>  Many thanks
> 
>  Duncan
> >>>
> >
>
>


Re: CLI packaging problem

2016-03-24 Thread Geoff Macartney

The brooklyn-client Apache build adds the CLI binaries in a zip file to the 
Apache Jenkins.

E.g. See links at end of 
https://builds.apache.org/view/Brooklyn/job/brooklyn-client-master/9/console

…
Uploaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/brooklyn/brooklyn-client-cli/0.9.0-SNAPSHOT/brooklyn-client-cli-0.9.0-20160321.101320-2-bin.zip
 

 



All you would need to do would be to add that to the same location as the main 
Brooklyn zip. 

As discussed with Duncan, for convenience it would be good to unpack the zip 
file before uploading it so users could just get the right binary without 
having to download the zip.  I’d just put up the Windows, Mac and Linux builds.





Gnu PGP key - http://is.gd/uI


> On 24 Mar 2016, at 18:32, Aled Sage  wrote:
> 
> +1
> 
> We won't have the brooklyn-client RPM in time for a 0.9.0 release, but we 
> should definitely work on that afterwards.
> 
> ---
> We can add a download link for the CLI to 
> http://brooklyn.apache.org/download/index.html, once there is an official 
> apache release of the CLI.
> 
> I believe the release manager copies the final artifacts to the right place 
> in apache, giving us the nice download links. We can do the same for the CLI, 
> as long as we have an appropriate artifact to put there from the 0.9.0 
> release process.
> 
> Aled
> 
> 
> On 24/03/2016 18:12, John McCabe wrote:
>> +1 Geoff
>> Having a CLI download alongside the brooklyn release as well makes sense,
>> like the web ui the user should be able to run the client from their local
>> machine to connect to a remote brooklyn instance (which is supported and
>> imho preferable since it keeps you off the server), bundling it only in the
>> release means the user has to either copy br from the node brooklyn is
>> running on or download a full brooklyn release only to get at the cli tool
>> which seems unnecessary.
>> I'd be inclined to package it (rpm, brew etc) separately as well -
>> installing the brooklyn rpm would pull in the client as a dep (will need to
>> be in a repo to make this painless). For a client install you could use
>> brew/port on OSX, possibly Chocolatey on Windows.
>> 
>> On Thu, 24 Mar 2016 at 17:56 Geoff Macartney <
>> geoff.macart...@cloudsoftcorp.com> wrote:
>> 
>>> I suggest adding the CLI artifacts to the release alongside the brooklyn
>>> zip.  At the same time as the brooklyn zip is copied to the release
>>> location, get the CLI artifact out of the Maven repository, for good
>>> measure unpack it, and upload the individual builds of the CLI tool to the
>>> same location.  Then update docs to explain how to download it too.
>>> 
>>> Remember the vagrant approach is really there as a Getting Started track,
>>> it’s not the typical path for using Brooklyn in anger.
>>> 
>>> 
>>> 
>>> Gnu PGP key - http://is.gd/uI
>>> 
>>> 
 On 24 Mar 2016, at 17:51, Duncan Godwin 
>>> wrote:
 Hi All,
 
 I've found a problem with the way the CLI is distributed for Brooklyn.
>>> It's
 included in the release files which means when an initial user uses the
 vagrant getting started guide, the CLI is inside the vagrant box, not on
 the users machine. As there's no download link to the CLI anywhere it
>>> means
 the flow of the documentation no longer works.
 
 The solutions to this could be:
 
 * Add additional downloads for each of the CLI versions somewhere
 * Extract the correct CLI from the vagrant box to the users machine in
>>> the
 instructions
 * Download the CLI bundle and extract and install the correct one
 
 What are everyone's thoughts?
 
 Many thanks
 
 Duncan
>>> 
> 



[GitHub] brooklyn-dist pull request: Populate catalog from bundle bom

2016-03-24 Thread geomacy
GitHub user geomacy opened a pull request:

https://github.com/apache/brooklyn-dist/pull/26

Populate catalog from bundle bom

The PR adds updates to the existing jars to add a catalog.bom file that 
includes the details of the various entities in each.  

See https://github.com/apache/brooklyn-server/pull/80 for details; this PR 
depends on that one and should be merged after it.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/geomacy/brooklyn-dist 
populate-catalog-from-bundle-bom

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-dist/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 1e40c0b39d19ccfaec908cdbccf5ec9a6d467889
Author: Geoff Macartney 
Date:   2016-03-23T16:16:22Z

Add default catalog.bom files (empty at present).

commit 2c09645e336ec972d5827556f78d41d338d55a39
Author: Geoff Macartney 
Date:   2016-03-24T18:02:12Z

Amend catalog.com with items for this package.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-library pull request: Populate catalog from bundle bom

2016-03-24 Thread geomacy
GitHub user geomacy opened a pull request:

https://github.com/apache/brooklyn-library/pull/25

Populate catalog from bundle bom

The PR adds updates to the existing jars to add a catalog.bom file that 
includes the details of the various entities in each.  

See https://github.com/apache/brooklyn-server/pull/80 for details; this PR 
depends on that one and should be merged after it.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/geomacy/brooklyn-library 
populate-catalog-from-bundle-bom

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-library/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit dcc4df47e75fdf504ab558201a64742740d85dd0
Author: Geoff Macartney 
Date:   2016-03-23T16:16:40Z

Add default catalog.bom files (empty at present).

commit ed8c39563b3d332daa90a8b343ceb7422606f7fa
Author: Geoff Macartney 
Date:   2016-03-24T18:04:10Z

Add bundle catalogs for OSGI setup.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CLI packaging problem

2016-03-24 Thread Robert Moss
+1

On 24 March 2016 at 18:12, John McCabe  wrote:

> +1 Geoff
> Having a CLI download alongside the brooklyn release as well makes sense,
> like the web ui the user should be able to run the client from their local
> machine to connect to a remote brooklyn instance (which is supported and
> imho preferable since it keeps you off the server), bundling it only in the
> release means the user has to either copy br from the node brooklyn is
> running on or download a full brooklyn release only to get at the cli tool
> which seems unnecessary.
> I'd be inclined to package it (rpm, brew etc) separately as well -
> installing the brooklyn rpm would pull in the client as a dep (will need to
> be in a repo to make this painless). For a client install you could use
> brew/port on OSX, possibly Chocolatey on Windows.
>
> On Thu, 24 Mar 2016 at 17:56 Geoff Macartney <
> geoff.macart...@cloudsoftcorp.com> wrote:
>
> > I suggest adding the CLI artifacts to the release alongside the brooklyn
> > zip.  At the same time as the brooklyn zip is copied to the release
> > location, get the CLI artifact out of the Maven repository, for good
> > measure unpack it, and upload the individual builds of the CLI tool to
> the
> > same location.  Then update docs to explain how to download it too.
> >
> > Remember the vagrant approach is really there as a Getting Started track,
> > it’s not the typical path for using Brooklyn in anger.
> >
> >
> > 
> > Gnu PGP key - http://is.gd/uI
> >
> >
> > > On 24 Mar 2016, at 17:51, Duncan Godwin <
> duncan.god...@cloudsoftcorp.com>
> > wrote:
> > >
> > > Hi All,
> > >
> > > I've found a problem with the way the CLI is distributed for Brooklyn.
> > It's
> > > included in the release files which means when an initial user uses the
> > > vagrant getting started guide, the CLI is inside the vagrant box, not
> on
> > > the users machine. As there's no download link to the CLI anywhere it
> > means
> > > the flow of the documentation no longer works.
> > >
> > > The solutions to this could be:
> > >
> > > * Add additional downloads for each of the CLI versions somewhere
> > > * Extract the correct CLI from the vagrant box to the users machine in
> > the
> > > instructions
> > > * Download the CLI bundle and extract and install the correct one
> > >
> > > What are everyone's thoughts?
> > >
> > > Many thanks
> > >
> > > Duncan
> >
> >
>


[GitHub] brooklyn-server pull request: Populate catalog from bundle bom

2016-03-24 Thread geomacy
GitHub user geomacy opened a pull request:

https://github.com/apache/brooklyn-server/pull/80

Populate catalog from bundle bom

This PR adds the ability for bundles to contain a 'catalog.bom' file 
specifying items that the bundle contains which should be added to the catalog.

The bundle is scanned for a catalog.bom upon bundle start.  The catalog.bom 
file is automatically enhanced with a 'brooklyn.libraries' entry that refers to 
the newly started bundle, and any items in it are added to the catalog.

The PR also includes updates to the existing jars to add a catalog.bom file 
that includes the details of the various entities in each. 

This PR is based upon the following and should be merged after them:

https://github.com/apache/brooklyn-server/pull/65
https://github.com/apache/brooklyn-server/pull/66


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/geomacy/brooklyn-server 
populate-catalog-from-bundle-bom

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #80


commit a51fdc71c9a1620e35cd88b1b6643ca4439b719d
Author: Geoff Macartney 
Date:   2016-03-04T10:52:46Z

Use OSGI lookup for ApiObjectsFactory and fall back to ServiceLoader.

Abstract out the lookup into a utility.

commit 00d1338b5c500a5585aaa91c38b3205668254821
Author: Geoff Macartney 
Date:   2016-03-07T16:19:39Z

Add framework lookup for (deprecated) PlanToSpecFactory.

commit f7a03f03897a7b0acc50163aeed32bf65283c1c4
Author: Geoff Macartney 
Date:   2016-03-07T17:08:18Z

Apply FrameworkLookup to TypePlanTransformers.

commit 8f88e41afc94bcdf7dfc7896dbaa44ceaffc464f
Author: Geoff Macartney 
Date:   2016-03-08T09:51:55Z

Use prototype scope on beans rather than explicit factory classes.

commit ebaeae7beac048f488b5a46c5430395ddc0ca35b
Author: Geoff Macartney 
Date:   2016-03-08T10:30:13Z

Replace ServiceLoader with FrameworkLookup for EntitySpecResolver.

commit 98d1b6003e9b71c3a0d85d25152e31c5414ccf92
Author: Geoff Macartney 
Date:   2016-03-08T14:26:05Z

Replace ServiceLoader with FrameworkLookup for ServiceTypeResolver.

commit b60db4c6f4dd5f57e06a962d52e734f361dd7c88
Author: Geoff Macartney 
Date:   2016-03-08T14:56:22Z

Replace ServiceLoader with FrameworkLookup for LocationResolver.

commit e6a412bfc0b0347364f50aee92977d6488d3d3e9
Author: Geoff Macartney 
Date:   2016-03-08T16:56:17Z

Fix list handling.

commit 6c3c508c8da03447742d19567d225bcf045da7c0
Author: Geoff Macartney 
Date:   2016-03-10T15:37:31Z

ServiceLookups should be in core, and use correct interface for 
campToSpecTransformerService.

commit afcb689f0a31995a27c953abab73f4902d8f2754
Author: Geoff Macartney 
Date:   2016-03-16T12:43:38Z

Update call to ServiceLoader.load to match previous call pattern.

(Previous in the sense of prior to the FrameworkLookup change.)

commit a93c170b6753110b034dcb8244e33ea859bac544
Author: Geoff Macartney 
Date:   2016-03-16T15:02:18Z

Add Javadoc note on use of FrameworkLooup and OSGI service reference count.

commit 630eb6485f89f5d68f5d10107bbc56af3c570cc0
Author: Geoff Macartney 
Date:   2016-03-18T16:36:40Z

Merge branch 'master' into service-loader-updates

commit 71d5a1083f250ac419cdb34b139ba62abef1bd4d
Author: Geoff Macartney 
Date:   2016-03-18T16:41:26Z

Use FrameworkLookup class to get the bundle context.

Necessary to avoid NPE at line 135 and 160 if the class being looked up is 
in a bundle that hasn't started yet.
We don't really need to get the bundle context from that class, any 
suitable one will do, and we know that
the bundle we live in has started!

commit b2df8dd2943b63eba805eb1b5209c99b3ade1d3f
Author: Geoff Macartney 
Date:   2016-03-23T09:48:28Z

Merge branch 'master' into service-loader-updates

commit 50ece3dee91d0f07f4ac8bd78b462063799580cc
Author: Svetoslav Neykov 
Date:   2016-03-16T16:41:52Z

Make EmbeddedFelixFramework pluggable

Needs different implementations depending on whether running in Karaf or 
classical. Can't have EmbeddedFelixFramework loaded in Karaf because felix 
bundle doesn't export org.apache.framework packages, just generic OSGi ones.

commit 

[GitHub] brooklyn-server pull request: Skip to next bundle on predicate fai...

2016-03-24 Thread geomacy
Github user geomacy commented on the pull request:

https://github.com/apache/brooklyn-server/pull/78#issuecomment-200953384
  
Did this not complete?  The build seems to have finished successfully.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CLI packaging problem

2016-03-24 Thread Geoff Macartney
I suggest adding the CLI artifacts to the release alongside the brooklyn zip.  
At the same time as the brooklyn zip is copied to the release location, get the 
CLI artifact out of the Maven repository, for good measure unpack it, and 
upload the individual builds of the CLI tool to the same location.  Then update 
docs to explain how to download it too.

Remember the vagrant approach is really there as a Getting Started track, it’s 
not the typical path for using Brooklyn in anger.



Gnu PGP key - http://is.gd/uI


> On 24 Mar 2016, at 17:51, Duncan Godwin  
> wrote:
> 
> Hi All,
> 
> I've found a problem with the way the CLI is distributed for Brooklyn. It's
> included in the release files which means when an initial user uses the
> vagrant getting started guide, the CLI is inside the vagrant box, not on
> the users machine. As there's no download link to the CLI anywhere it means
> the flow of the documentation no longer works.
> 
> The solutions to this could be:
> 
> * Add additional downloads for each of the CLI versions somewhere
> * Extract the correct CLI from the vagrant box to the users machine in the
> instructions
> * Download the CLI bundle and extract and install the correct one
> 
> What are everyone's thoughts?
> 
> Many thanks
> 
> Duncan



[GitHub] brooklyn-library pull request: Move custom-enable-credssp.ps1 to b...

2016-03-24 Thread aledsage
Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-library/pull/22#issuecomment-200913178
  
Now that https://github.com/apache/brooklyn-server/pull/75 is merged, I'll 
merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57339862
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+ 

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57338936
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. Set {@link #SCOPE_TIMEOUT scopeTimeout} ({@code 
softlayer.vlan.timeout}) to change
+ * the length of time the customizer will wait for VLAN information; 
normally 15 minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+"A mapping from scope identifiers to CountDownLatches; used to 
synchronize threads");
+  

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread grkvlt
Github user grkvlt commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57332394
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. Set {@link #SCOPE_TIMEOUT scopeTimeout} ({@code 
softlayer.vlan.timeout}) to change
+ * the length of time the customizer will wait for VLAN information; 
normally 15 minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+"A mapping from scope identifiers to CountDownLatches; used to 
synchronize threads");
+

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread aledsage
Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57329562
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+ 

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread grkvlt
Github user grkvlt commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57330074
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+   

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread grkvlt
Github user grkvlt commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57329759
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+   

[GitHub] brooklyn-docs pull request: Minor wording changes around option of...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57326426
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+ 

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57328790
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+ 

[GitHub] brooklyn-docs pull request: Update running.md

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/33


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread grkvlt
Github user grkvlt commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57326425
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+   

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread grkvlt
Github user grkvlt commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57325776
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+   

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread grkvlt
Github user grkvlt commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57325453
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+   

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread grkvlt
Github user grkvlt commented on the pull request:

https://github.com/apache/brooklyn-server/pull/53#issuecomment-200849031
  
@ahgittin I found the latches had better semantics than semaphores; will 
look into your other comments...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: Add Windows script for enabling Cred...

2016-03-24 Thread bostko
Github user bostko commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/75#discussion_r57310466
  
--- Diff: 
logging/logback-includes/src/main/resources/brooklyn/logback-logger-excludes.xml
 ---
@@ -42,6 +42,8 @@
 
 
 
+
--- End diff --

Currently the debug log is flooded with too jclouds rest calls. I feel like 
this shouldn't be part of brooklyn.debug.log


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: Add Windows script for enabling Cred...

2016-03-24 Thread aledsage
Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/75#discussion_r57308247
  
--- Diff: 
logging/logback-includes/src/main/resources/brooklyn/logback-logger-excludes.xml
 ---
@@ -42,6 +42,8 @@
 
 
 
+
--- End diff --

Is this deliberate? Why?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: brooklyn-master-windows #26

2016-03-24 Thread Apache Jenkins Server
See 

--
[...truncated 52907 lines...]
Compressed 648.22 KB of artifacts by 14.8% relative to #25
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-ui\pom.xml to 
org.apache.brooklyn/brooklyn-jsgui/0.9.0-SNAPSHOT/brooklyn-jsgui-0.9.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-ui\target\brooklyn-jsgui-0.9.0-SNAPSHOT.war
 to 
org.apache.brooklyn/brooklyn-jsgui/0.9.0-SNAPSHOT/brooklyn-jsgui-0.9.0-SNAPSHOT.war
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-ui\target\brooklyn-jsgui-0.9.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn/brooklyn-jsgui/0.9.0-SNAPSHOT/brooklyn-jsgui-0.9.0-SNAPSHOT-tests.jar
Compressed 2.84 MB of artifacts by 89.2% relative to #25
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\pom.xml
 to 
org.apache.brooklyn/brooklyn-utils-common/0.9.0-SNAPSHOT/brooklyn-utils-common-0.9.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\target\brooklyn-utils-common-0.9.0-SNAPSHOT.jar
 to 
org.apache.brooklyn/brooklyn-utils-common/0.9.0-SNAPSHOT/brooklyn-utils-common-0.9.0-SNAPSHOT.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\target\brooklyn-utils-common-0.9.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn/brooklyn-utils-common/0.9.0-SNAPSHOT/brooklyn-utils-common-0.9.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\target\brooklyn-utils-common-0.9.0-SNAPSHOT-sources.jar
 to 
org.apache.brooklyn/brooklyn-utils-common/0.9.0-SNAPSHOT/brooklyn-utils-common-0.9.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\common\target\brooklyn-utils-common-0.9.0-SNAPSHOT-test-sources.jar
 to 
org.apache.brooklyn/brooklyn-utils-common/0.9.0-SNAPSHOT/brooklyn-utils-common-0.9.0-SNAPSHOT-test-sources.jar
Compressed 1.15 MB of artifacts by 24.4% relative to #25
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\groovy\pom.xml
 to 
org.apache.brooklyn/brooklyn-utils-groovy/0.9.0-SNAPSHOT/brooklyn-utils-groovy-0.9.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\groovy\target\brooklyn-utils-groovy-0.9.0-SNAPSHOT.jar
 to 
org.apache.brooklyn/brooklyn-utils-groovy/0.9.0-SNAPSHOT/brooklyn-utils-groovy-0.9.0-SNAPSHOT.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\groovy\target\brooklyn-utils-groovy-0.9.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn/brooklyn-utils-groovy/0.9.0-SNAPSHOT/brooklyn-utils-groovy-0.9.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\groovy\target\brooklyn-utils-groovy-0.9.0-SNAPSHOT-sources.jar
 to 
org.apache.brooklyn/brooklyn-utils-groovy/0.9.0-SNAPSHOT/brooklyn-utils-groovy-0.9.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\utils\groovy\target\brooklyn-utils-groovy-0.9.0-SNAPSHOT-test-sources.jar
 to 
org.apache.brooklyn/brooklyn-utils-groovy/0.9.0-SNAPSHOT/brooklyn-utils-groovy-0.9.0-SNAPSHOT-test-sources.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-library\examples\simple-web-cluster\pom.xml
 to 
org.apache.brooklyn.example/brooklyn-example-simple-web-cluster/0.9.0-SNAPSHOT/brooklyn-example-simple-web-cluster-0.9.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-library\examples\simple-web-cluster\target\brooklyn-example-simple-web-cluster-0.9.0-SNAPSHOT.jar
 to 
org.apache.brooklyn.example/brooklyn-example-simple-web-cluster/0.9.0-SNAPSHOT/brooklyn-example-simple-web-cluster-0.9.0-SNAPSHOT.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-library\examples\simple-web-cluster\target\brooklyn-example-simple-web-cluster-0.9.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn.example/brooklyn-example-simple-web-cluster/0.9.0-SNAPSHOT/brooklyn-example-simple-web-cluster-0.9.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 
F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-library\examples\simple-web-cluster\target\brooklyn-example-simple-web-cluster-0.9.0-SNAPSHOT-sources.jar
 to 
org.apache.brooklyn.example/brooklyn-example-simple-web-cluster/0.9.0-SNAPSHOT/brooklyn-example-simple-web-cluster-0.9.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 

[GitHub] brooklyn-server pull request: Add a label to predicates check in f...

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/78#discussion_r57306501
  
--- Diff: core/src/main/java/org/apache/brooklyn/util/core/osgi/Osgis.java 
---
@@ -181,11 +181,11 @@ public BundleFinder requiringFromUrl(String url) {
 public List findAll() {
 boolean urlMatched = false;
 List result = MutableList.of();
-for (Bundle b: framework.getBundleContext().getBundles()) {
+allBundles: for (Bundle b: 
framework.getBundleContext().getBundles()) {
 if (symbolicName!=null && 
!symbolicName.equals(b.getSymbolicName())) continue;
 if (version!=null && 
!Version.parseVersion(version).equals(b.getVersion())) continue;
 for (Predicate predicate: predicates) {
-if (!predicate.apply(b)) continue;
+if (!predicate.apply(b)) continue allBundles;
--- End diff --

+1 i don't like labels here, and in any case i think the inner loop as svet 
suggests can be replaced by one line

if (!Predicates.and(predicates).apply(b)) continue;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-docs pull request: Describe SoftLayerSameVlanLocationCust...

2016-03-24 Thread ahgittin
Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-docs/pull/31#issuecomment-200802335
  
great content -- quite a few minor tweaks

then good to merge once the change in server is merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-docs pull request: Describe SoftLayerSameVlanLocationCust...

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/31#discussion_r57305871
  
--- Diff: guide/ops/locations/more-clouds.md ---
@@ -172,4 +172,86 @@ For example, for dev/demo purposes an "everything" 
network could be created that
 || Source IP Ranges|| 0.0.0.0/0   |
 || Allowed protocols and ports || tcp:0-65535 and udp:0-65535 |
 
-
+## IBM SoftLayer
+
+### VLAN Selection
+
+For some applications it is important that All VMs use the same VLAN. On
+SoftLayer this can be done by setting the `SoftLayerTemplateOptions`
+fields `primaryNetworkComponentNetworkVlanId` and
+`primaryBackendNetworkComponentNetworkVlanId` when specifying the
+location being used in the blueprint, as follows:
+
+```YAML
+location:
+  jclouds:softlayer:
+region: ams01
+templateOptions:
+  # Enter your preferred network IDs
+  primaryNetworkComponentNetworkVlanId: 1153481
+  primaryBackendNetworkComponentNetworkVlanId: 1153483
+```
+
+This will only work if you already have a VM configured using the same
+VLAN, and can copy the IDs from the SoftLayer console UI.
+
+If you are deploying a new application, then you can customise the
+location with ` `JcloudsLocationCustomizer` class, and we provide an
+implementation that ensures all machines in a particular scope will
+use the same VLAN. By default, the scope used is the application ID
+for the blueprint being deployed, but this can be changed if you need
+multiple applications to share the same VLAN.
+
+Use the `SoftLayerSameVlanLocationCustomizer` in your blueprint by
--- End diff --

```
To use this method, we tell brooklyn to use 
`SoftLayerSameVlanLocationCustomizer` as a location customizer.  
This can be done on a location as follows:
```

(put location first, then)

```
It is also possible with many blueprints to specify this as one of the 
`provisioning.properties` on an *application*:
```

(app blueprint illustration)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-docs pull request: Describe SoftLayerSameVlanLocationCust...

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/31#discussion_r57305606
  
--- Diff: guide/ops/locations/more-clouds.md ---
@@ -172,4 +172,86 @@ For example, for dev/demo purposes an "everything" 
network could be created that
 || Source IP Ranges|| 0.0.0.0/0   |
 || Allowed protocols and ports || tcp:0-65535 and udp:0-65535 |
 
-
+## IBM SoftLayer
+
+### VLAN Selection
+
+For some applications it is important that All VMs use the same VLAN. On
+SoftLayer this can be done by setting the `SoftLayerTemplateOptions`
+fields `primaryNetworkComponentNetworkVlanId` and
+`primaryBackendNetworkComponentNetworkVlanId` when specifying the
+location being used in the blueprint, as follows:
+
+```YAML
+location:
+  jclouds:softlayer:
+region: ams01
+templateOptions:
+  # Enter your preferred network IDs
+  primaryNetworkComponentNetworkVlanId: 1153481
+  primaryBackendNetworkComponentNetworkVlanId: 1153483
+```
+
+This will only work if you already have a VM configured using the same
+VLAN, and can copy the IDs from the SoftLayer console UI.
+
+If you are deploying a new application, then you can customise the
+location with ` `JcloudsLocationCustomizer` class, and we provide an
+implementation that ensures all machines in a particular scope will
+use the same VLAN. By default, the scope used is the application ID
+for the blueprint being deployed, but this can be changed if you need
+multiple applications to share the same VLAN.
--- End diff --

```
The second method tells Brooklyn to discover VLAN information automatically:
it will provision one VM first, and use the VLAN information from it when 
provisioning subsequent machines.
This ensures that all VMs are on the same subnet without requiring any 
manual VLAN referencing,
making it very easy for end-users.
```

(also note extra backtick in line 199)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-docs pull request: Describe SoftLayerSameVlanLocationCust...

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/31#discussion_r57305130
  
--- Diff: guide/ops/locations/more-clouds.md ---
@@ -172,4 +172,86 @@ For example, for dev/demo purposes an "everything" 
network could be created that
 || Source IP Ranges|| 0.0.0.0/0   |
 || Allowed protocols and ports || tcp:0-65535 and udp:0-65535 |
 
-
+## IBM SoftLayer
+
+### VLAN Selection
+
+For some applications it is important that All VMs use the same VLAN. On
--- End diff --

```
SoftLayer may provision VMs in different VLANs, even within the same region.
Some applications require VMs to be on the *same* internal subnet;
blueprints for these can specify this behaviour in SoftLayer in one of two 
ways.

The VLAN ID can be set explicitly using the fields ...
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread ahgittin
Github user ahgittin commented on the pull request:

https://github.com/apache/brooklyn-server/pull/53#issuecomment-200798220
  
A few more comments I'm afraid @grkvlt .  The latching logic still looks 
dubious and needs addressing, same for the non-transience of the latch.  The 
other comments are cosmetic but probably worth doing given changes are needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57304674
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+ 

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57304446
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+ 

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57304133
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+ 

[GitHub] brooklyn-server pull request: SoftLayer VLAN customizer

2016-03-24 Thread ahgittin
Github user ahgittin commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/53#discussion_r57303936
  
--- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java
 ---
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.brooklyn.location.jclouds.softlayer;
+
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.annotation.concurrent.ThreadSafe;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.TypeToken;
+import com.google.common.util.concurrent.Uninterruptibles;
+
+import org.jclouds.compute.ComputeService;
+import org.jclouds.compute.options.TemplateOptions;
+import org.jclouds.softlayer.SoftLayerApi;
+import org.jclouds.softlayer.compute.options.SoftLayerTemplateOptions;
+import org.jclouds.softlayer.domain.VirtualGuest;
+import org.jclouds.softlayer.features.VirtualGuestApi;
+import org.jclouds.softlayer.reference.SoftLayerConstants;
+
+import org.apache.brooklyn.api.entity.Entity;
+import org.apache.brooklyn.api.sensor.AttributeSensor;
+import org.apache.brooklyn.config.ConfigKey;
+import org.apache.brooklyn.core.config.ConfigKeys;
+import org.apache.brooklyn.core.location.LocationConfigKeys;
+import org.apache.brooklyn.core.sensor.Sensors;
+import org.apache.brooklyn.location.jclouds.BasicJcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsLocationCustomizer;
+import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
+import org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation;
+import org.apache.brooklyn.util.collections.MutableMap;
+import org.apache.brooklyn.util.core.flags.SetFromFlag;
+import org.apache.brooklyn.util.core.task.Tasks;
+import org.apache.brooklyn.util.text.Strings;
+import org.apache.brooklyn.util.time.Duration;
+
+/**
+ * Customizes {@link JcloudsSshMachineLocation machines} in SoftLayer to 
use
+ * the same VLANs across an application, or other named scope
+ * 
+ * Define the scope by setting the {@link #SCOPE_UID scopeUid} ({@code 
softlayer.vlan.scopeUid})
+ * option. If unset or blank, will default to the {@link 
Entity#getApplicationId() application ID}
+ * of the entity being deployed on the machine. Set {@link #SCOPE_TIMEOUT 
scopeTimeout}
+ * ({@code softlayer.vlan.timeout}) to change the length of time the 
customizer
+ * will wait for VLAN information; normally ten minutes.
+ * 
+ * The VLAN IDs and latches are stored as {@link ConfigKey configuration} 
on
+ * the {@link JcloudsLocation location} provisioning the VMs, in a map 
keyed
+ * on the scope.
+ */
+@ThreadSafe
+public class SoftLayerSameVlanLocationCustomizer extends 
BasicJcloudsLocationCustomizer {
+
+private static final Logger LOG = 
LoggerFactory.getLogger(SoftLayerSameVlanLocationCustomizer.class);
+
+@SetFromFlag("scopeUid")
+public static final ConfigKey SCOPE_UID = 
ConfigKeys.newStringConfigKey(
+"softlayer.vlan.scopeUid",
+"The unique identifier for a Softlayer location scope that 
will have VMs created in the same VLAN");
+
+@SetFromFlag("scopeTimeout")
+public static final ConfigKey SCOPE_TIMEOUT = 
ConfigKeys.newDurationConfigKey(
+"softlayer.vlan.timeout",
+"The length of time to wait for a Softlayer VLAN ID",
+Duration.minutes(15));
+
+public static final ConfigKey> 
COUNTDOWN_LATCH_MAP = ConfigKeys.newConfigKey(
+new TypeToken>() { },
+"softLayerSameVlanLocationCustomizer.map.latches",
+ 

[GitHub] brooklyn-ui pull request: Show error message on top of the YAML ed...

2016-03-24 Thread tbouron
Github user tbouron commented on a diff in the pull request:

https://github.com/apache/brooklyn-ui/pull/21#discussion_r57298808
  
--- Diff: src/main/webapp/assets/tpl/editor/page.html ---
@@ -47,12 +47,12 @@ Blueprint Composer
 
 
 
+
+ERROR
+
+
 
 
-
--- End diff --

@bostko It should be part of this PR in my opinion as this is a specific 
style, not a global one. You just need to add the code I mentioned to the 
`base.css` file :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-ui pull request: Show error message on top of the YAML ed...

2016-03-24 Thread bostko
Github user bostko commented on a diff in the pull request:

https://github.com/apache/brooklyn-ui/pull/21#discussion_r57298452
  
--- Diff: src/main/webapp/assets/tpl/editor/page.html ---
@@ -47,12 +47,12 @@ Blueprint Composer
 
 
 
+
+ERROR
+
+
 
 
-
--- End diff --

@tbouron I think the last can be done in a separate PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Brooklyn configuration in Karaf

2016-03-24 Thread Alex Heneveld


+1 this plan sounds excellent Svet.

I think the focus on catalog.bom files will make it a lot easier to 
package and share blueprints -- whether as bundles, zips, plain text 
files, or a git url.  I really like that we can use the power of OSGi 
for isolation and dependency resolution but this is transparent to a 
user, ie they don't need to know anything about OSGi.


And with persistence and the ability to define locations in the UI, it's 
nice that configuration (ie brooklyn.properties) becomes so much simpler.


--A


On 24/03/2016 09:48, Svetoslav Neykov wrote:

Hi all,

There's lots of effort going into Brooklyn to make it run in a Karaf container. 
As part of the changes we need to figure out how to support the existing CLI 
arguments and brooklyn.properties in the new environment.

Here's a suggestion of how this might look, open to discussion.

Command line arguments. Revise current set of command line arguments. Some of 
them are no longer needed, others don’t make sense in a Karaf environment. 
Define and support a subset of them. Arguments passed at the command line will 
be added to the brooklyn configuration files, making the values permanent, even 
for subsequent restarts. It ends up being just another means for editing the 
configuration.

brooklyn.properties. Integrate with Karaf by:
  * using OSGI configuration admin service to store Brooklyn properties;
  * populating the service from brooklyn.properties as well as the usual .cfg 
files;
Don't support properties which are now handled by different subsystems in Karaf.
  * webconsole (jetty) can be fully configured in Karaf without Brooklyn 
interfering.;
  * authentication - Karaf already provides the means to configure 
authentication providers (through JAAS) and configure them;
  * defining locations - the preferred way of defining a location is through 
the catalog, which can then be shared through HA. The only exception is for 
persistence locations which need to be available before persistence is enabled
 - for advanced cases allow the user to pass a catalog.bom with the 
persistence location and reference it in the configuration.Potentially marking 
the catalog item as NOT_PERSISTABLE to avoid handling duplicates. For example 
by adding the following config to brooklyn.properties:
brooklyn.persistence.location.specs=catalog.bom
brooklyn.persistence.location.named_in_catalog=my_persistence_loc #from 
catalog.bom above;
 - UI to do the same. When no persistence location is defined prompt the 
user create one (either webconsole or karaf mechanism to add one)

With the above brooklyn.properties will tend to be minimalistic (or not needed 
at all). Could consider splitting it additionally, for example options which 
can be included in the HA persistence and thus shared, and local properties.

Here’s a document which tracks existing CLI arguments and brooklyn.properties 
entries with a suggestion how it should be handled in the Karaf world.
https://docs.google.com/spreadsheets/d/19Tx-LLmqvboLJSQVAcyrbM9FJTaDWFJGMJuFnT_gNgY/edit#gid=0
 


Svet.






Jenkins build is back to normal : brooklyn-server-master #16

2016-03-24 Thread Apache Jenkins Server
See 



[GitHub] brooklyn-library pull request: Fix: ElasticSearch advertise datast...

2016-03-24 Thread bostko
Github user bostko commented on the pull request:

https://github.com/apache/brooklyn-library/pull/23#issuecomment-200732675
  
Looks good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---