Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/299
The jenkins build failure is unrelated (e.g. `Could not start Jetty server
on port 9,998: Address already in use`).
LGTM; merging.
---
If your project is set up for it, you can
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/61
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/100
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75291309
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/LocationSpecConfiguration.java
---
@@ -0,0 +1,58 @@
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75292142
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -84,51 +89,72 @@ public
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/300
@grkvlt the nine test failures in jenkins look related - e.g.
`org.apache.brooklyn.entity.group.DynamicFabricTest.testDynamicFabricCreatesAndStartsEntityWhenGivenManyLocations`.
---
If
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75291636
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -84,51 +89,72 @@ public
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/300
No tests have been added/updated - e.g. for the DSL to lookup locations,
and for testing what you're adding to `DynamicFabric`.
---
If your project is set up for it, you can reply to this
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75293363
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -84,51 +89,72 @@ public
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/300
@grkvlt finished reviewing - a few minor comments; the biggest is about the
failing tests, and lack of new tests to cover the new functionality.
---
If your project is set up for it, you
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/300#discussion_r75292379
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
---
@@ -145,81 +171,88 @@ public
14 matches
Mail list logo
