Jenkins build is unstable: brooklyn-master-windows #309

[Apache Jenkins Server]

See 

[GitHub] brooklyn-server pull request #355: Public Hostname is first public address o...

[bostko]

GitHub user bostko opened a pull request:

https://github.com/apache/brooklyn-server/pull/355

Public Hostname is first public address or first reachable private

Public Hostname to be first public address or first reachable private 
address

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bostko/brooklyn-server 
vmhostname_public_or_reachable

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #355


commit a0f1eac9a096346e110422ebeb3ee9082a7f6e27
Author: Valentin Aitken 
Date:   2016-09-27T21:05:52Z

Public Hostname is first public address or first reachable private address




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: brooklyn-master-windows #308

[Apache Jenkins Server]

See 

--
[...truncated 49501 lines...]
[INFO] Brooklyn Dist Root . SKIPPED
[INFO] Brooklyn All Things  SKIPPED
[INFO] Brooklyn Distribution .. SKIPPED
[INFO] Brooklyn Karaf Distribution Parent . SKIPPED
[INFO] Brooklyn Dist Karaf Features ... SKIPPED
[INFO] Brooklyn Karaf Distribution  SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Vagrant Getting Started Environment ... SKIPPED
[INFO] Brooklyn Quick-Start Project Archetype . SKIPPED
[INFO] Brooklyn Shared Package Files .. SKIPPED
[INFO] Brooklyn DEB Package ... SKIPPED
[INFO] Brooklyn Root .. SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 40:50 min
[INFO] Finished at: 2016-09-27T12:45:15-07:00
[INFO] Final Memory: 139M/445M
[INFO] 
Waiting for Jenkins to finish collecting data
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on 
project brooklyn-software-webapp: There are test failures.
[ERROR] 
[ERROR] Please refer to 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-library\software\webapp\target\surefire-reports
 for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :brooklyn-software-webapp
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-library\software\cm\salt\pom.xml
 to 
org.apache.brooklyn/brooklyn-software-cm-salt/0.10.0-SNAPSHOT/brooklyn-software-cm-salt-0.10.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-library\software\cm\salt\target\brooklyn-software-cm-salt-0.10.0-SNAPSHOT.jar
 to 
org.apache.brooklyn/brooklyn-software-cm-salt/0.10.0-SNAPSHOT/brooklyn-software-cm-salt-0.10.0-SNAPSHOT.jar
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-library\software\cm\salt\target\brooklyn-software-cm-salt-0.10.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn/brooklyn-software-cm-salt/0.10.0-SNAPSHOT/brooklyn-software-cm-salt-0.10.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-library\software\cm\salt\target\brooklyn-software-cm-salt-0.10.0-SNAPSHOT-sources.jar
 to 
org.apache.brooklyn/brooklyn-software-cm-salt/0.10.0-SNAPSHOT/brooklyn-software-cm-salt-0.10.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-library\software\cm\salt\target\brooklyn-software-cm-salt-0.10.0-SNAPSHOT-test-sources.jar
 to 
org.apache.brooklyn/brooklyn-software-cm-salt/0.10.0-SNAPSHOT/brooklyn-software-cm-salt-0.10.0-SNAPSHOT-test-sources.jar
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-server\core\pom.xml
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT.pom
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\brooklyn-core-0.10.0-SNAPSHOT.jar
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT.jar
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\brooklyn-core-0.10.0-SNAPSHOT-tests.jar
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT-tests.jar
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\brooklyn-core-0.10.0-SNAPSHOT-sources.jar
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT-sources.jar
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\brooklyn-core-0.10.0-SNAPSHOT-test-sources.jar
 to 
org.apache.brooklyn/brooklyn-core/0.10.0-SNAPSHOT/brooklyn-core-0.10.0-SNAPSHOT-test-sources.jar
[JENKINS] Archiving 
F:\jenkins\jenkins-slave\workspace\brooklyn-master-windows\brooklyn-server\camp\camp-server\pom.xml
 to 

Build failed in Jenkins: brooklyn-client-master #22

[Apache Jenkins Server]

See 

Changes:

[graeme.miller] Updated resteasy version

[graeme.miller] updated resteasy to 3.0.19.Final

--
[...truncated 628 lines...]
at 
com.fasterxml.jackson.databind.ObjectReader._prefetchRootDeserializer(ObjectReader.java:1404)
at 
com.fasterxml.jackson.databind.ObjectReader.withType(ObjectReader.java:424)
at 
com.fasterxml.jackson.databind.ObjectReader.withType(ObjectReader.java:453)
at 
org.jboss.resteasy.plugins.providers.jackson.ResteasyJackson2Provider.readFrom(ResteasyJackson2Provider.java:121)
at 
org.jboss.resteasy.core.interception.AbstractReaderInterceptorContext.readFrom(AbstractReaderInterceptorContext.java:61)
at 
org.jboss.resteasy.core.interception.AbstractReaderInterceptorContext.proceed(AbstractReaderInterceptorContext.java:53)
at 
org.jboss.resteasy.plugins.interceptors.encoding.GZIPDecodingInterceptor.aroundReadFrom(GZIPDecodingInterceptor.java:59)
at 
org.jboss.resteasy.core.interception.AbstractReaderInterceptorContext.proceed(AbstractReaderInterceptorContext.java:55)
at 
org.jboss.resteasy.client.core.BaseClientResponse.readFrom(BaseClientResponse.java:448)
at 
org.jboss.resteasy.client.core.BaseClientResponse.getEntity(BaseClientResponse.java:396)
at 
org.jboss.resteasy.client.core.BaseClientResponse.getEntity(BaseClientResponse.java:367)
at 
org.jboss.resteasy.client.core.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:75)
at 
org.jboss.resteasy.client.core.ClientInvoker.invoke(ClientInvoker.java:138)
at 
org.jboss.resteasy.client.core.ClientProxy.invoke(ClientProxy.java:98)
at com.sun.proxy.$Proxy72.getVersion(Unknown Source)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.brooklyn.rest.client.BrooklynApi$3.invoke(BrooklynApi.java:287)
at com.sun.proxy.$Proxy73.getVersion(Unknown Source)
at 
org.apache.brooklyn.rest.client.BrooklynApiRestClientTest.testNoV1InUrl(BrooklynApiRestClientTest.java:102)

testDeployBlueprint(org.apache.brooklyn.rest.client.BrooklynApiUtilTest)  Time 
elapsed: 0.058 sec  <<< FAILURE!
java.lang.NoSuchMethodError: 
com.fasterxml.jackson.databind.util.BeanUtil.okNameForGetter(Lcom/fasterxml/jackson/databind/introspect/AnnotatedMethod;Z)Ljava/lang/String;
at 
com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector.findNameForSerialization(JaxbAnnotationIntrospector.java:824)
at 
com.fasterxml.jackson.databind.introspect.AnnotationIntrospectorPair.findNameForSerialization(AnnotationIntrospectorPair.java:475)
at 
com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector._addGetterMethod(POJOPropertiesCollector.java:552)
at 
com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector._addMethods(POJOPropertiesCollector.java:510)
at 
com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector.collect(POJOPropertiesCollector.java:238)
at 
com.fasterxml.jackson.databind.introspect.BasicClassIntrospector.collectProperties(BasicClassIntrospector.java:142)
at 
com.fasterxml.jackson.databind.introspect.BasicClassIntrospector.forDeserialization(BasicClassIntrospector.java:81)
at 
com.fasterxml.jackson.databind.introspect.BasicClassIntrospector.forDeserialization(BasicClassIntrospector.java:11)
at 
com.fasterxml.jackson.databind.DeserializationConfig.introspect(DeserializationConfig.java:550)
at 
com.fasterxml.jackson.databind.deser.DeserializerCache._createDeserializer(DeserializerCache.java:323)
at 
com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCache2(DeserializerCache.java:261)
at 
com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCacheValueDeserializer(DeserializerCache.java:241)
at 
com.fasterxml.jackson.databind.deser.DeserializerCache.findValueDeserializer(DeserializerCache.java:142)
at 
com.fasterxml.jackson.databind.DeserializationContext.findRootValueDeserializer(DeserializationContext.java:394)
at 
com.fasterxml.jackson.databind.ObjectReader._prefetchRootDeserializer(ObjectReader.java:1404)
at 
com.fasterxml.jackson.databind.ObjectReader.withType(ObjectReader.java:424)
at 
com.fasterxml.jackson.databind.ObjectReader.withType(ObjectReader.java:453)
at 
org.jboss.resteasy.plugins.providers.jackson.ResteasyJackson2Provider.readFrom(ResteasyJackson2Provider.java:121)
at 
org.jboss.resteasy.core.interception.AbstractReaderInterceptorContext.readFrom(AbstractReaderInterceptorContext.java:61)
at 

[jira] [Commented] (BROOKLYN-349) NPE using yaml DSL in entity's "provisioning.properties"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BROOKLYN-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526804#comment-15526804
 ] 

ASF GitHub Bot commented on BROOKLYN-349:
-

Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/341
  
@neykov can you review these additional commits please? Do you agree that 
we should merge this, and not @grkvlt 's #279?

When refactoring the tests to remove duplication, I realised that if one 
uses:

```
provisioning.properties:
  password: $brooklyn:config("password")
```
And then subsequently calls `jcloudsSshMachineLocation.getHostname()` 
outside of the context of an entity, then it fails to resolve (because it 
doesn't know which entity to look at the config on).

I discussed the short term fix with @neykov, and applied it here: it avoids 
propagating the exception if the credentials can't be obtained, and it only 
look up the credentials if we really need them (e.g. for hostname on AWS, where 
we ask the VM for it).

---
I also discussed the longer term solution with @neykov. Conclusion is that 
it's hard. And that we should resolve the DSL config's context at the time the 
entity is being instantiated (e.g. storing it as a field on the 
`DslConfigSupplier` or whatever). This would mean we'd always use the entity on 
which the config was declared, rather than relying on who is looking it up. 
However, there is (probably?!) an exception to that rule: if you declare config 
with an `@brooklyn:entitySpec`, such as for a `memberSpec`, then you probably 
want it to refer to the context of the entity to be created rather than the 
entity where you are declaring the entitySpec (and therefore if setting the 
entity context on the DSL object, you'd need to ensure it is a different DSL 
object instance for each member instantiated using the entitySpec!).

That deserves its own thread on dev@brooklyn.


> NPE using yaml DSL in entity's "provisioning.properties"
> 
>
> Key: BROOKLYN-349
> URL: https://issues.apache.org/jira/browse/BROOKLYN-349
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> Using Brooklyn 0.10.0-SNAPSHOT...
> Some usage of the brooklyn DSL within an entity's "provisioning.properties" 
> config fails. This is because it fails to find the entity in context.
> Therefore a config value like {{$brooklyn:config(\"password\")}} will fail 
> (but yaml like {{$brooklyn:external(\"creds\", \"test-identity\")}} should be 
> ok, because that does not need to resolve the entity).
> As an example, add the following catalog item and then deploy the given app:
> {noformat}
> brooklyn.catalog:
>   id: example-entity
>   version: "0.1.2"
>   itemType: entity
>   item:",
> brooklyn.parameters:
> - name: password
>   default: myYamlPassword
> type: org.apache.brooklyn.entity.software.base.EmptySoftwareProcess
> location:
>   jclouds:softlayer:
> waitForSshable: false
> useJcloudsSshInit: false
> services:\n"+
> - type: example-entity
>   brooklyn.config:
> onbox.base.dir.skipResolution: true
> sshMonitoring.enabled: false
> provisioning.properties:
>   password: $brooklyn:config("password")
> #  password: $brooklyn:external("creds", "test-password")
> {noformat}
> This fails with an NPE:
> {noformat}
> java.util.concurrent.ExecutionException: 
> org.apache.brooklyn.core.mgmt.internal.EffectorUtils$EffectorCallPropagatedRuntimeException:
>  Error invoking start at BasicApplicationImpl{id=wsufdg642b}: Error invoking 
> start at EmptySoftwareProcessImpl{id=j8rtiy99gr}: Error resolving 
> config("password"), in 
> org.apache.brooklyn.util.core.task.BasicExecutionContext@2f46ac03([LocalManagementContext[mujiHu35-oUhipl25],
>  BROOKLYN-SERVER]): 
> org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: 
> NullPointerException
>   at java.util.concurrent.FutureTask.report(FutureTask.java:122)
>   at java.util.concurrent.FutureTask.get(FutureTask.java:188)
>   at 
> com.google.common.util.concurrent.ForwardingFuture.get(ForwardingFuture.java:63)
>   at org.apache.brooklyn.util.core.task.BasicTask.get(BasicTask.java:361)
>   at 
> org.apache.brooklyn.camp.brooklyn.JcloudsRebindWithYamlDslTest.newJcloudsLocation(JcloudsRebindWithYamlDslTest.java:163)
>   at 
> org.apache.brooklyn.location.jclouds.JcloudsRebindStubTest.testRebind(JcloudsRebindStubTest.java:193)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> 

[GitHub] brooklyn-server issue #341: BROOKLYN-349: fix DSL resolution in location

[aledsage]

Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/341
  
@neykov can you review these additional commits please? Do you agree that 
we should merge this, and not @grkvlt 's #279?

When refactoring the tests to remove duplication, I realised that if one 
uses:

```
provisioning.properties:
  password: $brooklyn:config("password")
```
And then subsequently calls `jcloudsSshMachineLocation.getHostname()` 
outside of the context of an entity, then it fails to resolve (because it 
doesn't know which entity to look at the config on).

I discussed the short term fix with @neykov, and applied it here: it avoids 
propagating the exception if the credentials can't be obtained, and it only 
look up the credentials if we really need them (e.g. for hostname on AWS, where 
we ask the VM for it).

---
I also discussed the longer term solution with @neykov. Conclusion is that 
it's hard. And that we should resolve the DSL config's context at the time the 
entity is being instantiated (e.g. storing it as a field on the 
`DslConfigSupplier` or whatever). This would mean we'd always use the entity on 
which the config was declared, rather than relying on who is looking it up. 
However, there is (probably?!) an exception to that rule: if you declare config 
with an `@brooklyn:entitySpec`, such as for a `memberSpec`, then you probably 
want it to refer to the context of the entity to be created rather than the 
entity where you are declaring the entitySpec (and therefore if setting the 
entity context on the DSL object, you'd need to ensure it is a different DSL 
object instance for each member instantiated using the entitySpec!).

That deserves its own thread on dev@brooklyn.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client pull request #28: Updated resteasy version

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-client/pull/28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-client issue #28: Updated resteasy version

[aledsage]

Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-client/pull/28
  
LGTM. https://github.com/apache/brooklyn-server/pull/339 is merged; merging 
this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #339: Updated jackson version

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/339


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #339: Updated jackson version

[aledsage]

Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/339
  
LGTM; merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : brooklyn-master-windows #307

[Apache Jenkins Server]

See 

[jira] [Created] (BROOKLYN-352) ConcurrentModificationException when using $brooklyn:entity

[Svetoslav Neykov (JIRA)]

Svetoslav Neykov created BROOKLYN-352:
-

 Summary: ConcurrentModificationException when using 
$brooklyn:entity
 Key: BROOKLYN-352
 URL: https://issues.apache.org/jira/browse/BROOKLYN-352
 Project: Brooklyn
  Issue Type: Bug
Reporter: Svetoslav Neykov


Got the following exception when running a fairly complex blueprint on a cpu 
starved machine. Looking at the sources and the javadoc makes sense - we should 
guard iterating over the entities with a synchronized block.

>From Collections.synchronizedMap:
{noformat}
 * It is imperative that the user manually synchronize on the returned
 * map when iterating over any of its collection views:
{noformat}


{noformat}
Failed after 13ms: Execution failed, invocation error for launching 
VanillaSoftwareProcessImpl{id=w4ixqlmhdh}: Error resolving config 
shell.env.KUBERNETES_URL, 
$brooklyn:entity("kubernetes-master").attributeWhenReady("kubernetes.url"), in 
org.apache.brooklyn.util.core.task.BasicExecutionContext@1d028d95([Wrapped[contextEntity:VanillaSoftwareProcessImpl{id=w4ixqlmhdh}],
 LocalManagementContext[i5xdJAZa-yAstcnrg]]): 
org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: 
ConcurrentModificationException

java.lang.IllegalStateException: Execution failed, invocation error for 
launching VanillaSoftwareProcessImpl{id=w4ixqlmhdh}: Error resolving config 
shell.env.KUBERNETES_URL, 
$brooklyn:entity("kubernetes-master").attributeWhenReady("kubernetes.url"), in 
org.apache.brooklyn.util.core.task.BasicExecutionContext@1d028d95([Wrapped[contextEntity:VanillaSoftwareProcessImpl{id=w4ixqlmhdh}],
 LocalManagementContext[i5xdJAZa-yAstcnrg]]): 
org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: 
ConcurrentModificationException
at 
org.apache.brooklyn.entity.software.base.lifecycle.ScriptHelper.logWithDetailsAndThrow(ScriptHelper.java:387)
at 
org.apache.brooklyn.entity.software.base.lifecycle.ScriptHelper.executeInternal(ScriptHelper.java:370)
at 
org.apache.brooklyn.entity.software.base.lifecycle.ScriptHelper$8.call(ScriptHelper.java:287)
at 
org.apache.brooklyn.entity.software.base.lifecycle.ScriptHelper$8.call(ScriptHelper.java:285)
at 
org.apache.brooklyn.util.core.task.DynamicSequentialTask$DstJob.call(DynamicSequentialTask.java:359)
at 
org.apache.brooklyn.util.core.task.BasicExecutionManager$SubmissionCallable.call(BasicExecutionManager.java:519)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: Error resolving config 
shell.env.KUBERNETES_URL, 
$brooklyn:entity("kubernetes-master").attributeWhenReady("kubernetes.url"), in 
org.apache.brooklyn.util.core.task.BasicExecutionContext@1d028d95([Wrapped[contextEntity:VanillaSoftwareProcessImpl{id=w4ixqlmhdh}],
 LocalManagementContext[i5xdJAZa-yAstcnrg]]): 
org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: 
ConcurrentModificationException
at 
org.apache.brooklyn.util.core.task.ValueResolver.getMaybeInternal(ValueResolver.java:411)
at 
org.apache.brooklyn.util.core.task.ValueResolver.getMaybe(ValueResolver.java:257)
at 
org.apache.brooklyn.util.core.task.ValueResolver.get(ValueResolver.java:250)
at org.apache.brooklyn.util.core.task.Tasks.resolveValue(Tasks.java:147)
at 
org.apache.brooklyn.core.config.BasicConfigKey.resolveValue(BasicConfigKey.java:355)
at 
org.apache.brooklyn.core.config.BasicConfigKey.extractValue(BasicConfigKey.java:340)
at 
org.apache.brooklyn.core.config.SubElementConfigKey.extractValue(SubElementConfigKey.java:48)
at 
org.apache.brooklyn.core.config.internal.AbstractStructuredConfigKey.extractValue(AbstractStructuredConfigKey.java:111)
at 
org.apache.brooklyn.core.config.internal.AbstractStructuredConfigKey.extractValue(AbstractStructuredConfigKey.java:124)
at 
org.apache.brooklyn.core.entity.internal.EntityConfigMap.getConfigImpl(EntityConfigMap.java:139)
at 
org.apache.brooklyn.core.entity.internal.EntityConfigMap.getConfig(EntityConfigMap.java:113)
at 
org.apache.brooklyn.core.config.internal.AbstractConfigMapImpl.getConfig(AbstractConfigMapImpl.java:50)
at 
org.apache.brooklyn.core.entity.AbstractEntity$BasicConfigurationSupport.get(AbstractEntity.java:1213)
at 
org.apache.brooklyn.core.entity.AbstractEntity.getConfig(AbstractEntity.java:1299)
at 
org.apache.brooklyn.entity.software.base.AbstractSoftwareProcessSshDriver.getShellEnvironment(AbstractSoftwareProcessSshDriver.java:348)
at 

[GitHub] brooklyn-server issue #339: Updated jackson version

[Graeme-Miller]

Github user Graeme-Miller commented on the issue:

https://github.com/apache/brooklyn-server/pull/339
  
I have tested this with vanilla/karaf brooklyn and karaf AMP.
I have tested deploying a blueprint and using the Swagger API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #339: Updated jackson version

[Graeme-Miller]

Github user Graeme-Miller commented on the issue:

https://github.com/apache/brooklyn-server/pull/339
  
We have decided to proceed with updating the dependency.
We have also added a commit recommended by Svet in the predecessor to this 
PR: 
https://github.com/neykov/brooklyn-server/commit/62613c05c2ba08c3ad9055d1fa3006f100a58b38

Lastly Swagger has been forbidden from pulling in any jackson versions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #352: Adds SshCommandEffectorYamlTest

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/352


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #352: Adds SshCommandEffectorYamlTest

[neykov]

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-server/pull/352
  
Thanks @aledsage, @duncangrant, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request #112: Add documentation about pinned field for Br...

[tbouron]

GitHub user tbouron opened a pull request:

https://github.com/apache/brooklyn-docs/pull/112

Add documentation about pinned field for Brooklyn parameters

This depends on https://github.com/apache/brooklyn-server/pull/354

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tbouron/brooklyn-docs fix/priority-vs-pinned

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-docs/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #112


commit d12e619252dc087cf5e8b3c7c4ee53d5f246f7a1
Author: Thomas Bouron 
Date:   2016-09-27T11:19:16Z

Add documentation about pinned field for Brooklyn parameters




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #354: Config keys and parameters can now be mar...

[tbouron]

GitHub user tbouron opened a pull request:

https://github.com/apache/brooklyn-server/pull/354

Config keys and parameters can now be marked as "pinned"

The new behaviour is as follow:
- By default, config keys and parameters are `pinned = false`
- A blueprint can specify a config key or parameter as pinned by using 
`@CatalogConfig(pinned = true)` or in yaml `pinned: true`
- In case of config keys or parameters pinned in YAML, the priority is auto 
incremented to keep the order (code lost in [this 
commit](https://github.com/apache/brooklyn-server/commit/6f624c78b1e7fe72c6df1ecd297b922721b2c023#diff-5310fbeb1f42a3a4cf0508ea441440baL82))

Tests have been updated. Changes in docs and JSGUI coming soon.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tbouron/brooklyn-server fix/priority-vs-pinned

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #354


commit d02e73ea87c60d517ac146c3888a7796ee74f7a3
Author: Thomas Bouron 
Date:   2016-09-27T11:06:32Z

Config keys and parameters can now be marked as "pinned" regardless of 
their priority




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: brooklyn-master-windows #306

[Apache Jenkins Server]

See 

--
[...truncated 30267 lines...]
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [01:40 min]
[INFO] Brooklyn Server Root ... SUCCESS [  1.371 s]
[INFO] Brooklyn Parent Project  SUCCESS [  9.027 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [ 15.875 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  6.162 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 37.224 s]
[INFO] Brooklyn API ... SUCCESS [  7.671 s]
[INFO] CAMP Server Parent Project . SUCCESS [  3.151 s]
[INFO] CAMP Base .. SUCCESS [ 11.502 s]
[INFO] Brooklyn Test Support .. SUCCESS [  7.008 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [  8.958 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [ 11.747 s]
[INFO] CAMP Server  SUCCESS [ 19.911 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [ 11.876 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [ 10.574 s]
[INFO] Brooklyn Core .. SUCCESS [05:08 min]
[INFO] Brooklyn Policies .. SUCCESS [01:42 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [ 19.724 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 18.398 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  6.477 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 36.522 s]
[INFO] Brooklyn Software Base . FAILURE [02:32 min]
[INFO] Brooklyn CAMP REST API . SKIPPED
[INFO] Brooklyn Hazelcast Storage . SKIPPED
[INFO] Brooklyn Launcher Common ... SKIPPED
[INFO] Brooklyn REST API .. SKIPPED
[INFO] Brooklyn REST Resources  SKIPPED
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Jetty config fragment .. SKIPPED
[INFO] Apache Http Component extension  SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn Monitoring Software Entities .. SKIPPED
[INFO] Brooklyn QA  SKIPPED
[INFO] Brooklyn Examples Aggregator Project ... SKIPPED
[INFO] Brooklyn Examples Aggregator Project - Webapps . SKIPPED
[INFO] hello-world-webapp Maven Webapp  SKIPPED
[INFO] hello-world-sql-webapp Maven Webapp  SKIPPED
[INFO] Brooklyn Simple Web Cluster Example  SKIPPED
[INFO] Brooklyn Global Web Fabric Example . SKIPPED
[INFO] Brooklyn Simple Messaging Publish-Subscribe Example  SKIPPED
[INFO] Brooklyn NoSQL Cluster Examples  SKIPPED
[INFO] Brooklyn Library Karaf integration . SKIPPED
[INFO] Brooklyn Library Catalog ... SKIPPED
[INFO] Brooklyn Library Karaf Features  SKIPPED
[INFO] Brooklyn Downstream Project Parent . SKIPPED
[INFO] Brooklyn Dist Root . SKIPPED
[INFO] Brooklyn All Things  SKIPPED
[INFO] Brooklyn Distribution .. SKIPPED
[INFO] Brooklyn Karaf Distribution Parent . SKIPPED
[INFO] Brooklyn Dist Karaf Features ... 

[GitHub] brooklyn-server pull request #353: Fix security group customizer for azure s...

[aledsage]

GitHub user aledsage opened a pull request:

https://github.com/apache/brooklyn-server/pull/353

Fix security group customizer for azure strike2



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/brooklyn-server 
fix-SecurityGroupCustomizer-for-azure-strike2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #353


commit 01bb9ad1940885adce6f49d804f8579e69dc10ba
Author: Aled Sage 
Date:   2016-09-09T09:06:39Z

JcloudsLocationSecurityGroupCustomizer: handle “openstack-mitaka-nova”

There is a different jclouds provider/api available for OpenStack
Mitaka release. Look for that, as well as the “openstack-nova” name.

commit a893ceac57d213c4c4aec09e3a167e525157317e
Author: Aled Sage 
Date:   2016-09-09T13:44:49Z

JcloudsLocatoinSecurityGroupCustomizer: avoid ICMP for azure




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #352: Adds SshCommandEffectorYamlTest

[aledsage]

GitHub user aledsage opened a pull request:

https://github.com/apache/brooklyn-server/pull/352

Adds SshCommandEffectorYamlTest



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/brooklyn-server 
test-SshCommandEffector

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #352


commit ca5fa8b98c3fdc97fb8b89cf9e1fe125025c3735
Author: Aled Sage 
Date:   2016-09-27T10:29:52Z

Adds SshCommandEffectorYamlTest




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #341: BROOKLYN-349: fix DSL resolution in location

[neykov]

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-server/pull/341
  
The changes make sense. I think they will work even if the DSL is set on 
the location object, nothing specific to `provisioning.properties` here. Worth 
a test case to confirm? 
The result still depends on the context where evaluation happens, not where 
it's set. Or may be not, not sure how #340 interacts with this and locations 
specifically. 
Good to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs issue #108: Add config instructions for HTTPS on Karaf.

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-docs/pull/108
  
Thanks @neykov!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs pull request #108: Add config instructions for HTTPS on Karaf.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-docs/pull/108


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-docs issue #108: Add config instructions for HTTPS on Karaf.

[neykov]

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-docs/pull/108
  
Thanks @geomacy, @drigodwin, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BROOKLYN-351) extra jclouds providers not found (in karaf)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BROOKLYN-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525485#comment-15525485
 ] 

ASF GitHub Bot commented on BROOKLYN-351:
-

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/351
  
looks good!


> extra jclouds providers not found (in karaf)
> 
>
> Key: BROOKLYN-351
> URL: https://issues.apache.org/jira/browse/BROOKLYN-351
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> When using a downstream build of Brooklyn 0.10.0-SNAPSHOT (with karaf), I 
> added a couple of extra jclouds labs providers/apis via the feature.xml.
> However, when I tried to use it with the blueprint below, I got the error 
> shown:
> {noformat}
> location: jclouds:azurecompute
> services:
> - type: org.apache.brooklyn.entity.stock.BasicApplication
> 2016-09-26 12:10:12,346 DEBUG 115 o.a.b.c.t.AbstractTypePlanTransformer 
> [p1212877220-1463] Could not instantiate BasicRegisteredType[null;null] 
> (rethrowing): Illegal parameter for 'location' (jclouds:azurecompute); not 
> resolvable: NoSuchElementException: Cloud provider/
> API type azurecompute is not supported by jclouds
> {noformat}
> Looking in {{org.jclouds.providers.Providers.withId("azurecompute")}}, 
> jclouds does know about azurecompute.
> The problem is that the providers/apis list are retrieved and stored in 
> {{JcloudsLocationResolver.PROVIDERS}} and {{JcloudsLocationResolver.APIS}} 
> (during static init). At that point, the azurecompute bundle has not been 
> activated, so {{org.jclouds.osgi.ProviderRegistry}} had not yet had it added 
> by {{org.jclouds.osgi.MetadataBundleListener}}.
> Below is a stacktrace of where this happens:
> {noformat}
> Daemon Thread [FelixStartLevel] (Suspended (breakpoint at line 82 in 
> Providers))  
>   owns: AtomicBoolean  (id=1573)  
>   Providers.all() line: 82
>   JcloudsLocationResolver.getProvidersMap() line: 61  
>   JcloudsLocationResolver.() line: 56 
>   NativeConstructorAccessorImpl.newInstance0(Constructor, Object[]) line: 
> not available [native method]   
>   NativeConstructorAccessorImpl.newInstance(Object[]) line: 57
>   DelegatingConstructorAccessorImpl.newInstance(Object[]) line: 45
>   Constructor.newInstance(Object...) line: 526 
>   ReflectionUtils.newInstance(AccessControlContext, Constructor, 
> Object...) line: 331 
>   BeanRecipe.newInstance(Constructor, Object...) line: 984
>   BeanRecipe.getInstanceFromType(List, List) line: 
> 349   
>   BeanRecipe.getInstance() line: 282  
>   BeanRecipe.internalCreate2() line: 830  
>   BeanRecipe.internalCreate() line: 811   
>   BeanRecipe(AbstractRecipe).create() line: 106   
>   RefRecipe.internalCreate() line: 62 
>   RefRecipe(AbstractRecipe).create() line: 106
>   ServiceRecipe.createService() line: 285 
>   ServiceRecipe.internalGetService(Bundle, ServiceRegistration) line: 252 
>   ServiceRecipe.internalCreate() line: 149
>   AbstractRecipe$1.call() line: 79
>   FutureTask.run() line: 262   
>   ServiceRecipe(AbstractRecipe).create() line: 88 
>   BlueprintRepository.createInstances(Collection) line: 255   
>   BlueprintRepository.createAll(Collection) line: 186 
>   BlueprintContainerImpl.instantiateEagerComponents() line: 712   
>   BlueprintContainerImpl.doRun() line: 399
>   BlueprintContainerImpl.run() line: 273  
>   BlueprintExtender.createContainer(Bundle, List) line: 294   
>   BlueprintExtender.createContainer(Bundle) line: 263 
>   BlueprintExtender.modifiedBundle(Bundle, BundleEvent, Object) line: 253 
>   BundleHookBundleTracker$Tracked.customizerModified(Bundle, BundleEvent, 
> T) line: 500
>   BundleHookBundleTracker$Tracked.customizerModified(Object, Object, 
> Object) line: 433
>   
> BundleHookBundleTracker$Tracked(BundleHookBundleTracker$AbstractTracked).track(S,
>  R) line: 725   
>   BundleHookBundleTracker$Tracked.bundleChanged(BundleEvent) line: 463
>   BundleHookBundleTracker$BundleEventHook.event(BundleEvent, Collection) 
> line: 422
>   SecureAction.invokeBundleEventHook(EventHook, BundleEvent, 
> Collection) line: 1179
>   EventDispatcher.createWhitelistFromHooks(EventObject, Framework, 
> Map, Map, 
> Class) line: 731  
>   EventDispatcher.fireBundleEvent(BundleEvent, Framework) line: 486   
>   Felix.fireBundleEvent(int, Bundle) line: 4541   
>   Felix.startBundle(BundleImpl, int) line: 2172   
>   Felix.setActiveStartLevel(int, FrameworkListener[]) line: 1371  
>   FrameworkStartLevelImpl.run() 

[GitHub] brooklyn-server issue #351: BROOKLYN-351: fix jclouds provider/api caching

[geomacy]

Github user geomacy commented on the issue:

https://github.com/apache/brooklyn-server/pull/351
  
looks good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

[neykov]

Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/331#discussion_r80635357
  
--- Diff: 
utils/common/src/main/java/org/apache/brooklyn/util/javalang/MemoryUsageTracker.java
 ---
@@ -68,5 +87,76 @@ public long getBytesUsed() {
 memoryTrackedReferences.cleanUp();
 return bytesUsed.get();
 }
+
+/** forces all soft references to be cleared by trying to allocate an 
enormous chunk of memory,
+ * returns a description of what was done 
+ * (tune with {@link #forceClearSoftReferences(long, int)} 
+ * for greater than 200M precision in the output message, if you 
really care about that) */
+public static String forceClearSoftReferences() {
+return forceClearSoftReferences(1000*1000, Integer.MAX_VALUE);
+}
+/** as {@link #forceClearSoftReferences()} but gives control over 
headroom and max chunk size.
+ * it tries to undershoot by headroom as it approaches maximum (and 
then overshoot)
+ * to minimize the chance we take exactly all the memory and starve 
another thread;
+ * and it uses the given max chunk size in cases where the caller 
wants more precision
+ * (the available memory will be fragmented so the smaller the chunks 
the more it can
+ * fill in, but at the expense of time and actual memory provisioned) 
*/
+public static String forceClearSoftReferences(long headroom, int 
maxChunk) {
--- End diff --

`headroom` not used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

[neykov]

Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/331#discussion_r80630775
  
--- Diff: 
camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/pdp/AssemblyTemplateConstructor.java
 ---
@@ -40,15 +40,22 @@ public AssemblyTemplateConstructor(CampPlatform 
campPlatform) {
 this.transaction = this.campPlatform.transaction();
 }
 
-/** records all the templates to the underlying platform */
+/** records all the templates to the underlying platform 
+ * @deprecated since 0.10.0 use {@link #construct(boolean)} */
 public AssemblyTemplate commit() {
+return construct(true);
+}
+
+/** builds the template, optionally recording everything to the 
underlying platform */
+public AssemblyTemplate construct(boolean save) {
 checkState();
 AssemblyTemplate at = builder.build();
-transaction.add(at).commit();
+if (!save) transaction.clear();
+transaction.commit();
 transaction = null;
 return at;
 }
-
+
--- End diff --

Can you just not call commit/construct (for the lack of rollback) and let 
the objects GC instead of doing the API changes in `camp-base`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BROOKLYN-351) extra jclouds providers not found (in karaf)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BROOKLYN-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525253#comment-15525253
 ] 

ASF GitHub Bot commented on BROOKLYN-351:
-

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/351


> extra jclouds providers not found (in karaf)
> 
>
> Key: BROOKLYN-351
> URL: https://issues.apache.org/jira/browse/BROOKLYN-351
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> When using a downstream build of Brooklyn 0.10.0-SNAPSHOT (with karaf), I 
> added a couple of extra jclouds labs providers/apis via the feature.xml.
> However, when I tried to use it with the blueprint below, I got the error 
> shown:
> {noformat}
> location: jclouds:azurecompute
> services:
> - type: org.apache.brooklyn.entity.stock.BasicApplication
> 2016-09-26 12:10:12,346 DEBUG 115 o.a.b.c.t.AbstractTypePlanTransformer 
> [p1212877220-1463] Could not instantiate BasicRegisteredType[null;null] 
> (rethrowing): Illegal parameter for 'location' (jclouds:azurecompute); not 
> resolvable: NoSuchElementException: Cloud provider/
> API type azurecompute is not supported by jclouds
> {noformat}
> Looking in {{org.jclouds.providers.Providers.withId("azurecompute")}}, 
> jclouds does know about azurecompute.
> The problem is that the providers/apis list are retrieved and stored in 
> {{JcloudsLocationResolver.PROVIDERS}} and {{JcloudsLocationResolver.APIS}} 
> (during static init). At that point, the azurecompute bundle has not been 
> activated, so {{org.jclouds.osgi.ProviderRegistry}} had not yet had it added 
> by {{org.jclouds.osgi.MetadataBundleListener}}.
> Below is a stacktrace of where this happens:
> {noformat}
> Daemon Thread [FelixStartLevel] (Suspended (breakpoint at line 82 in 
> Providers))  
>   owns: AtomicBoolean  (id=1573)  
>   Providers.all() line: 82
>   JcloudsLocationResolver.getProvidersMap() line: 61  
>   JcloudsLocationResolver.() line: 56 
>   NativeConstructorAccessorImpl.newInstance0(Constructor, Object[]) line: 
> not available [native method]   
>   NativeConstructorAccessorImpl.newInstance(Object[]) line: 57
>   DelegatingConstructorAccessorImpl.newInstance(Object[]) line: 45
>   Constructor.newInstance(Object...) line: 526 
>   ReflectionUtils.newInstance(AccessControlContext, Constructor, 
> Object...) line: 331 
>   BeanRecipe.newInstance(Constructor, Object...) line: 984
>   BeanRecipe.getInstanceFromType(List, List) line: 
> 349   
>   BeanRecipe.getInstance() line: 282  
>   BeanRecipe.internalCreate2() line: 830  
>   BeanRecipe.internalCreate() line: 811   
>   BeanRecipe(AbstractRecipe).create() line: 106   
>   RefRecipe.internalCreate() line: 62 
>   RefRecipe(AbstractRecipe).create() line: 106
>   ServiceRecipe.createService() line: 285 
>   ServiceRecipe.internalGetService(Bundle, ServiceRegistration) line: 252 
>   ServiceRecipe.internalCreate() line: 149
>   AbstractRecipe$1.call() line: 79
>   FutureTask.run() line: 262   
>   ServiceRecipe(AbstractRecipe).create() line: 88 
>   BlueprintRepository.createInstances(Collection) line: 255   
>   BlueprintRepository.createAll(Collection) line: 186 
>   BlueprintContainerImpl.instantiateEagerComponents() line: 712   
>   BlueprintContainerImpl.doRun() line: 399
>   BlueprintContainerImpl.run() line: 273  
>   BlueprintExtender.createContainer(Bundle, List) line: 294   
>   BlueprintExtender.createContainer(Bundle) line: 263 
>   BlueprintExtender.modifiedBundle(Bundle, BundleEvent, Object) line: 253 
>   BundleHookBundleTracker$Tracked.customizerModified(Bundle, BundleEvent, 
> T) line: 500
>   BundleHookBundleTracker$Tracked.customizerModified(Object, Object, 
> Object) line: 433
>   
> BundleHookBundleTracker$Tracked(BundleHookBundleTracker$AbstractTracked).track(S,
>  R) line: 725   
>   BundleHookBundleTracker$Tracked.bundleChanged(BundleEvent) line: 463
>   BundleHookBundleTracker$BundleEventHook.event(BundleEvent, Collection) 
> line: 422
>   SecureAction.invokeBundleEventHook(EventHook, BundleEvent, 
> Collection) line: 1179
>   EventDispatcher.createWhitelistFromHooks(EventObject, Framework, 
> Map, Map, 
> Class) line: 731  
>   EventDispatcher.fireBundleEvent(BundleEvent, Framework) line: 486   
>   Felix.fireBundleEvent(int, Bundle) line: 4541   
>   Felix.startBundle(BundleImpl, int) line: 2172   
>   Felix.setActiveStartLevel(int, FrameworkListener[]) line: 1371  
>   FrameworkStartLevelImpl.run() line: 308 
>   

[GitHub] brooklyn-server pull request #351: BROOKLYN-351: fix jclouds provider/api ca...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/351


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (BROOKLYN-351) extra jclouds providers not found (in karaf)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BROOKLYN-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525250#comment-15525250
 ] 

ASF GitHub Bot commented on BROOKLYN-351:
-

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-server/pull/351
  
Nice! Merging.


> extra jclouds providers not found (in karaf)
> 
>
> Key: BROOKLYN-351
> URL: https://issues.apache.org/jira/browse/BROOKLYN-351
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> When using a downstream build of Brooklyn 0.10.0-SNAPSHOT (with karaf), I 
> added a couple of extra jclouds labs providers/apis via the feature.xml.
> However, when I tried to use it with the blueprint below, I got the error 
> shown:
> {noformat}
> location: jclouds:azurecompute
> services:
> - type: org.apache.brooklyn.entity.stock.BasicApplication
> 2016-09-26 12:10:12,346 DEBUG 115 o.a.b.c.t.AbstractTypePlanTransformer 
> [p1212877220-1463] Could not instantiate BasicRegisteredType[null;null] 
> (rethrowing): Illegal parameter for 'location' (jclouds:azurecompute); not 
> resolvable: NoSuchElementException: Cloud provider/
> API type azurecompute is not supported by jclouds
> {noformat}
> Looking in {{org.jclouds.providers.Providers.withId("azurecompute")}}, 
> jclouds does know about azurecompute.
> The problem is that the providers/apis list are retrieved and stored in 
> {{JcloudsLocationResolver.PROVIDERS}} and {{JcloudsLocationResolver.APIS}} 
> (during static init). At that point, the azurecompute bundle has not been 
> activated, so {{org.jclouds.osgi.ProviderRegistry}} had not yet had it added 
> by {{org.jclouds.osgi.MetadataBundleListener}}.
> Below is a stacktrace of where this happens:
> {noformat}
> Daemon Thread [FelixStartLevel] (Suspended (breakpoint at line 82 in 
> Providers))  
>   owns: AtomicBoolean  (id=1573)  
>   Providers.all() line: 82
>   JcloudsLocationResolver.getProvidersMap() line: 61  
>   JcloudsLocationResolver.() line: 56 
>   NativeConstructorAccessorImpl.newInstance0(Constructor, Object[]) line: 
> not available [native method]   
>   NativeConstructorAccessorImpl.newInstance(Object[]) line: 57
>   DelegatingConstructorAccessorImpl.newInstance(Object[]) line: 45
>   Constructor.newInstance(Object...) line: 526 
>   ReflectionUtils.newInstance(AccessControlContext, Constructor, 
> Object...) line: 331 
>   BeanRecipe.newInstance(Constructor, Object...) line: 984
>   BeanRecipe.getInstanceFromType(List, List) line: 
> 349   
>   BeanRecipe.getInstance() line: 282  
>   BeanRecipe.internalCreate2() line: 830  
>   BeanRecipe.internalCreate() line: 811   
>   BeanRecipe(AbstractRecipe).create() line: 106   
>   RefRecipe.internalCreate() line: 62 
>   RefRecipe(AbstractRecipe).create() line: 106
>   ServiceRecipe.createService() line: 285 
>   ServiceRecipe.internalGetService(Bundle, ServiceRegistration) line: 252 
>   ServiceRecipe.internalCreate() line: 149
>   AbstractRecipe$1.call() line: 79
>   FutureTask.run() line: 262   
>   ServiceRecipe(AbstractRecipe).create() line: 88 
>   BlueprintRepository.createInstances(Collection) line: 255   
>   BlueprintRepository.createAll(Collection) line: 186 
>   BlueprintContainerImpl.instantiateEagerComponents() line: 712   
>   BlueprintContainerImpl.doRun() line: 399
>   BlueprintContainerImpl.run() line: 273  
>   BlueprintExtender.createContainer(Bundle, List) line: 294   
>   BlueprintExtender.createContainer(Bundle) line: 263 
>   BlueprintExtender.modifiedBundle(Bundle, BundleEvent, Object) line: 253 
>   BundleHookBundleTracker$Tracked.customizerModified(Bundle, BundleEvent, 
> T) line: 500
>   BundleHookBundleTracker$Tracked.customizerModified(Object, Object, 
> Object) line: 433
>   
> BundleHookBundleTracker$Tracked(BundleHookBundleTracker$AbstractTracked).track(S,
>  R) line: 725   
>   BundleHookBundleTracker$Tracked.bundleChanged(BundleEvent) line: 463
>   BundleHookBundleTracker$BundleEventHook.event(BundleEvent, Collection) 
> line: 422
>   SecureAction.invokeBundleEventHook(EventHook, BundleEvent, 
> Collection) line: 1179
>   EventDispatcher.createWhitelistFromHooks(EventObject, Framework, 
> Map, Map, 
> Class) line: 731  
>   EventDispatcher.fireBundleEvent(BundleEvent, Framework) line: 486   
>   Felix.fireBundleEvent(int, Bundle) line: 4541   
>   Felix.startBundle(BundleImpl, int) line: 2172   
>   Felix.setActiveStartLevel(int, FrameworkListener[]) line: 1371  
>   FrameworkStartLevelImpl.run() 

[GitHub] brooklyn-server issue #351: BROOKLYN-351: fix jclouds provider/api caching

[neykov]

Github user neykov commented on the issue:

https://github.com/apache/brooklyn-server/pull/351
  
Nice! Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---