Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
+1 go ahead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Aha nvm Jenkins is now running, it just took a little while.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/560#discussion_r101520554
--- Diff:
launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynWebServer.java ---
@@ -447,7 +450,15 @@ public synchronized void start()
Github user googlielmo commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/516#discussion_r101520600
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -260,7 +260,7 @@
https://github.com/square/okhttp/pull/2246
Github user googlielmo commented on the issue:
https://github.com/apache/brooklyn-server/pull/516
Thanks for the comments @m4rkmckenna. Will address them with a new commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/562
Provide a scratchpad area per management context
Replaces similar usage of `ManagementContext.getConfig()`.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user drigodwin opened a pull request:
https://github.com/apache/brooklyn-library/pull/92
Updates couchDBNode to support V2.0+
Updates couchDBNode to support CouchDB 2.0+
You can merge this pull request into a Git repository by running:
$ git pull
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/560#discussion_r101522786
--- Diff:
launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynWebServer.java ---
@@ -447,7 +450,15 @@ public synchronized void start()
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/560#discussion_r101513076
--- Diff:
launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynWebServer.java ---
@@ -447,7 +450,15 @@ public synchronized void start()
GitHub user ahgittin reopened a pull request:
https://github.com/apache/brooklyn-server/pull/560
Attempted non-determinite test fixes
Prompted by the following (from
https://builds.apache.org/job/brooklyn-server-pull-requests/1730/ ):
```
Test Result (3 failures / +3)
Github user ahgittin closed the pull request at:
https://github.com/apache/brooklyn-server/pull/560
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user duncangrant commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/92#discussion_r101529086
--- Diff:
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/couchdb/CouchDBNodeSshDriver.java
---
@@ -198,24 +211,36 @@ public
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Based on one run this improves things. I've tried closing and reopening
but that no longer triggers a rebuild. Damn server-side smartness!
---
If your project is set up for it, you can
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/363
test failures unrelated, described in
https://github.com/apache/brooklyn-server/pull/560
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/480
Unrelated test failures in penultimate jenkins build are discussed at
https://github.com/apache/brooklyn-server/pull/560
---
If your project is set up for it, you can reply to this email
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/560#discussion_r101483274
--- Diff:
launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynWebServer.java ---
@@ -447,7 +450,15 @@ public synchronized void start()
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/560
Attempted non-determinite test fixes
Prompted by the following (from
https://builds.apache.org/job/brooklyn-server-pull-requests/1730/ ):
```
Test Result (3 failures / +3)
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/561
better presentation for sensor publishing tasks
previously they didn't even have a name; now they have a nice name,
description, and a tag.
there is some attempt to optimize the use
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/561
noticed when working on #559 . related to but not implementing ML
discussion at this time around whether `entities/xxx/activities` API should
default/optionally `includeBackground`. when
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/561#discussion_r101533579
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java
---
@@ -111,7 +115,7 @@ public long
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/561#discussion_r101534376
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java
---
@@ -237,42 +212,85 @@ public synchronized
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/561#discussion_r101534679
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java
---
@@ -237,42 +212,85 @@ public synchronized
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/561#discussion_r101535119
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java
---
@@ -237,42 +212,85 @@ public synchronized
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/92#discussion_r101538525
--- Diff:
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/couchdb/CouchDBNodeSshDriver.java
---
@@ -198,24 +211,36 @@ public void
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Graeme-Miller closed the pull request at:
https://github.com/apache/brooklyn-server/pull/554
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/561
Also great to have a `SENSOR` tag, this will allows us to do filtering more
easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/562
Good idea about a limited interface @geomacy. If you look at the change
sites you'll find out that a `context` is hard to identify. On the other hand
using a `ConfigKey` for the key gives
Very interesting discussion gents.
Couple of questions/musings:
why is it necessary to have the management-private- group created
by the manager of the cluster? Can't each Brooklyn node check what cloud it
is on as it starts and then either create the management-private-
or join it?
It wasn't
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/562#discussion_r101565527
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/test/lite/CampPlatformWithJustBrooklynMgmt.java
---
@@ -30,7 +30,9 @@
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/560#discussion_r101577936
--- Diff:
launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynWebServer.java ---
@@ -447,7 +450,15 @@ public synchronized void start()
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/560#discussion_r101578521
--- Diff:
launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynWebServer.java ---
@@ -447,7 +450,15 @@ public synchronized void start()
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/562
@neykov Agree, having this warning within the docs seems to be the way to
go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/150
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/563
[WIP] Don't SO_REUSEADDR when probing for available ports
Do not merge, the changes here are meant to test the behaviour on Apache's
jenkins slaves.
The changes have the side
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Curious. I'll amend comments here and merge if that's okay. Happy to remove
the setReuseAddr or not depending who gets to it first.
---
If your project is set up for it, you can reply
36 matches
Mail list logo