[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/625#discussion_r110697978 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/javalang/Reflections.java --- @@ -204,6 +209,7 @@ public Object loadInstance(String

Jenkins build is back to normal : brooklyn-master-build #1015

See

[GitHub] brooklyn-docs pull request #165: Improve test-entities matcher docs, for reg...

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/165#discussion_r110683826 --- Diff: guide/yaml/test/test-entities.md --- @@ -165,6 +165,13 @@ The following conditions are provided by those test entities above that include

[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/625#discussion_r110694031 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/BasicExternalConfigSupplierRegistry.java --- @@ -103,12 +103,13 @@ private

[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/625#discussion_r110694368 --- Diff: utils/common/dependencies/osgi/com-example-entities/src/main/java/com/example/brooklyn/test/osgi/PrefixedDummyExternalConfigSupplier.java

[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/625#discussion_r110695847 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/javalang/Reflections.java --- @@ -204,6 +209,7 @@ public Object loadInstance(String

[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/625#discussion_r110694398 --- Diff: utils/common/dependencies/osgi/entities/src/main/java/org/apache/brooklyn/test/osgi/UnprefixedDummyExternalConfigSupplier.java --- @@

[GitHub] brooklyn-docs pull request #165: Improve test-entities matcher docs, for reg...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server pull request #617: Persist management plane ID

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/617#discussion_r110711348 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/ManagementPlaneIdTest.java --- @@ -0,0 +1,247 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #617: Persist management plane ID

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/617#discussion_r110710806 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/ManagementPlaneIdTest.java --- @@ -0,0 +1,247 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #617: Persist management plane ID

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/617#discussion_r110710330 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java --- @@ -467,6 +469,15 @@ protected void

[GitHub] brooklyn-server pull request #617: Persist management plane ID

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/617#discussion_r110708530 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/BrooklynMementoPersisterToObjectStore.java --- @@ -674,6 +685,22 @@ private

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/160#discussion_r110738634 --- Diff: guide/java/enrichers.md --- @@ -0,0 +1,150 @@ +--- +title: Enrichers +layout: website-normal +toc: ../guide_toc.json

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/160#discussion_r110738673 --- Diff: guide/java/enrichers.md --- @@ -0,0 +1,150 @@ +--- +title: Enrichers +layout: website-normal +toc: ../guide_toc.json

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/160#discussion_r110738650 --- Diff: guide/java/enrichers.md --- @@ -0,0 +1,150 @@ +--- +title: Enrichers +layout: website-normal +toc: ../guide_toc.json

[GitHub] brooklyn-docs pull request #160: Add separate enrichers page and combine pol...

Github user mikezaccardo commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/160#discussion_r110738692 --- Diff: guide/java/enrichers.md --- @@ -0,0 +1,150 @@ +--- +title: Enrichers +layout: website-normal +toc: ../guide_toc.json

[GitHub] brooklyn-server issue #589: yaml-test assertions: fix use of “matches”

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/589 @neykov regarding whether multiline support should be on by default, it feels like using the language defaults is a good idea as it will be less surprising to users (though I see the point

[GitHub] brooklyn-server pull request #622: Integration tests fixes

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/622#discussion_r110593557 --- Diff: core/src/test/java/org/apache/brooklyn/core/entity/ApplicationLifecycleStateTest.java --- @@ -201,6 +227,163 @@ public void

[GitHub] brooklyn-server issue #622: Integration tests fixes

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/622 Thanks @aledsage. Updated the javadocs. Waiting for the new build to finish and will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #622: Integration tests fixes

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/622#discussion_r110603378 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindTestUtils.java --- @@ -238,7 +238,6 @@ public LocalManagementContext

[GitHub] brooklyn-server pull request #624: Adds authSudo support (for sudo’ing wit...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #516: Add unit tests for Karaf features

Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/516 I agree that we should merge this and iterate, since there have been no more comments I'm going to do that now. Thanks @googlielmo @m4rkmckenna @aledsage --- If your project is set up

[GitHub] brooklyn-server issue #589: yaml-test assertions: fix use of “matches”

Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/589 This PR now adds the useful additional functionality of `containsMatch` without changing any defaults. I think since this was useful to @aledsage it might be useful to other users, so

[GitHub] brooklyn-server issue #624: Adds authSudo support (for sudo’ing with passw...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/624 +1 apart from password escape concern. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server pull request #624: Adds authSudo support (for sudo’ing wit...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/624#discussion_r110630192 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommands.java --- @@ -91,12 +91,23 @@ public static String ok(String command)

[jira] [Commented] (BROOKLYN-460) Brooklyn Camp syntax for adding tags to an entity spec

[ https://issues.apache.org/jira/browse/BROOKLYN-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962734#comment-15962734 ] ASF GitHub Bot commented on BROOKLYN-460: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-docs pull request #162: BROOKLYN-460: Brooklyn Camp syntax guidance

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server issue #616: Fixed BlobStoreContextFactoryImpl. It can now ha...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/616 LGTM; I also ran the live tests in `org.apache.brooklyn.core.mgmt.persist.jclouds`: `BlobStoreTest` and `BlobStoreExpiryTest`. It's a shame about the signature

[GitHub] brooklyn-server pull request #616: Fixed BlobStoreContextFactoryImpl. It can...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/616 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #589: yaml-test assertions: fix use of “match...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #620: Test entities: maxAttempts and timeouts

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/620 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #516: Add unit tests for Karaf features

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Build failed in Jenkins: brooklyn-master-build #1014

See -- [...truncated 7.40 MB...] [JENKINS] Archiving

[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/625 Updates BasicExternalConfigSupplierRegistry to use ClassLoaderUtils You can merge this pull request into a Git repository by running: $ git pull

Call for release: Brooklyn 0.11.0

Hi all, It's time we did another Brooklyn release: 0.11.0. I propose we kick off RC1 tomorrow. Any volunteers for being release manager? I also suggest we be conservative about the PRs we merge before then - let's not view that as a deadline for merging large / high-risk PRs, but instead

Re: Call for release: Brooklyn 0.11.0

Hi Aled, I'm happy to volunteer to by RM on this one. I'm keen to firm up our release process to make it as optimal as possible whilst still being The Apache Way, so I'll use this as an opportunity to draft up a wider-ranging release policy. After this release we can then discuss how the release

[GitHub] brooklyn-server issue #546: Sequencer entity

Github user mikezaccardo commented on the issue: https://github.com/apache/brooklyn-server/pull/546 @grkvlt this would indeed be useful for the Hyperledger Fabric multi-cluster in place of this entity:

[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/625#discussion_r110665785 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/BasicExternalConfigSupplierRegistry.java --- @@ -103,12 +103,13 @@ private void

[GitHub] brooklyn-server issue #625: Updates BasicExternalConfigSupplierRegistry to u...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/625 Looks good. Can you add test coverage in `ExternalConfigBrooklynPropertiesTest` by implementing a dummy `ExternalConfigSupplier` in *

[GitHub] brooklyn-server pull request #625: Updates BasicExternalConfigSupplierRegist...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/625#discussion_r110666451 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/javalang/Reflections.java --- @@ -204,6 +209,7 @@ public Object loadInstance(String

[GitHub] brooklyn-server pull request #622: Integration tests fixes

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/622#discussion_r110596123 --- Diff: core/src/test/java/org/apache/brooklyn/core/entity/ApplicationLifecycleStateTest.java --- @@ -201,6 +227,163 @@ public void

[GitHub] brooklyn-server pull request #622: Integration tests fixes

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/622#discussion_r110596919 --- Diff: core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindTestUtils.java --- @@ -238,7 +238,6 @@ public LocalManagementContext

[GitHub] brooklyn-docs pull request #165: Improve test-entities matcher docs, for reg...

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-docs/pull/165 Improve test-entities matcher docs, for regex See discussion in https://github.com/apache/brooklyn-server/pull/589 You can merge this pull request into a Git repository by running: $