[GitHub] brooklyn-server pull request #840: Fix catalog YAML

2017-09-21 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-server/pull/840 Fix catalog YAML Square brackets within the yaml string meant it was interpreted as an array and broke the initial catalog load. This puts speach marks around so it's interpreted as a

[GitHub] brooklyn-server pull request #840: Fix catalog YAML

2017-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/840 ---

[GitHub] brooklyn-server issue #840: Fix catalog YAML

2017-09-21 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/840 Thanks for spotting and fixing! Merging now. ---

Build failed in Jenkins: brooklyn-dist-master #117

2017-09-21 Thread Apache Jenkins Server
See Changes: [thomas.bouron] Add LICENSE and NOTICE file back to the RPM and DEB packages -- [...truncated 61.91 KB...] [INFO] [INFO] ---

[GitHub] brooklyn-server pull request #842: Improve Brooklyn-management of OSGi-alrea...

2017-09-21 Thread ahgittin
GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/842 Improve Brooklyn-management of OSGi-already-managed bundles Previously could claim it was already installed but not brooklyn-manage it. Now it is much smarter about checking

Re: [VOTE] Release Apache Brooklyn 0.12.0 [rc2]

2017-09-21 Thread Alex Heneveld
Good catches Thomas -- suggest we cancel and do a new RC. The build-from-source problem I suspect is simply down to network setup / firewall on your box. But it would be good to force use of localhost for those tests or mark them integration so that it doesn't bite others or ideally be

Re: [VOTE] Release Apache Brooklyn 0.12.0 [rc2]

2017-09-21 Thread Duncan Godwin
Thanks All, Due to discovery of these problems this vote is cancelled I have cherry picked the two PRs thomas mentioned and will produce a new RC shortly https://github.com/apache/brooklyn-dist/pull/109 https://github.com/apache/brooklyn-server/pull/840 Many thanks Duncan On 21 September

[GitHub] brooklyn-server pull request #839: BROOKLYN-537: fix NPE listing catalog ite...

2017-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/839 ---

[jira] [Commented] (BROOKLYN-537) NPE listing catalog items

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174960#comment-16174960 ] ASF GitHub Bot commented on BROOKLYN-537: - Github user asfgit closed the pull request at:

[jira] [Commented] (BROOKLYN-539) ClassCastExceptions on rebind (trying to persist catalog items)

2017-09-21 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174992#comment-16174992 ] Aled Sage commented on BROOKLYN-539: I played around with

[jira] [Created] (BROOKLYN-539) ClassCastExceptions on rebind (trying to persist catalog items)

2017-09-21 Thread Aled Sage (JIRA)
Aled Sage created BROOKLYN-539: -- Summary: ClassCastExceptions on rebind (trying to persist catalog items) Key: BROOKLYN-539 URL: https://issues.apache.org/jira/browse/BROOKLYN-539 Project: Brooklyn

Re: [VOTE] Release Apache Brooklyn 0.12.0 [rc2]

2017-09-21 Thread Thomas Bouron
-1 Quick summary of the tests I've done: [✓] Download links work. [✓] Checksums and PGP signatures are valid. [✓] Expanded source archive matches contents of RC tag. [x] Expanded source archive builds and passes tests. [✓] LICENSE is present and correct. [✓] NOTICE is present and correct,

[jira] [Resolved] (BROOKLYN-538) IllegalArgumentException parsing (null?) json response in http feed

2017-09-21 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-538. Resolution: Won't Fix Assignee: Aled Sage Marking this as "won't fix" for the following

[GitHub] brooklyn-server pull request #841: BROOKLYN-538: add failing test

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/841 BROOKLYN-538: add failing test Adds a test that demonstrates https://issues.apache.org/jira/browse/BROOKLYN-538 I'm going to mark issue as "won't fix" for the following reasons:

[jira] [Commented] (BROOKLYN-538) IllegalArgumentException parsing (null?) json response in http feed

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174689#comment-16174689 ] ASF GitHub Bot commented on BROOKLYN-538: - GitHub user aledsage opened a pull request:

Build failed in Jenkins: brooklyn-master-build #1222

2017-09-21 Thread Apache Jenkins Server
See -- [...truncated 8.19 MB...] [INFO] Brooklyn Launcher .. SUCCESS [ 43.506 s] [INFO] Brooklyn Container Location Targets SUCCESS

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140307032 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/TypeTransformer.java --- @@ -0,0 +1,194 @@ +/* + *

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140307822 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/BundleApi.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140305502 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/TypeTransformer.java --- @@ -0,0 +1,194 @@ +/* + *

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140309656 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/BundleApi.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140315673 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/TypeApi.java --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140310844 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java --- @@ -0,0 +1,186 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140311355 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java --- @@ -0,0 +1,186 @@ +/* + * Licensed

[GitHub] brooklyn-dist pull request #110: Improve verify brooklyn RC script

2017-09-21 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/110 Improve verify brooklyn RC script This does the following things: - improve the readability of the script - ignore the NOTICE/LICENSE files check for the DEB package (as there is no

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140315307 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140311803 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java --- @@ -0,0 +1,186 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140313345 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/SubtypeApi.java --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140315527 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/TypeApi.java --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #810: REST API for bundles, types, and subtypes

2017-09-21 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/810#discussion_r140309889 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/TypeDetail.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

[GitHub] brooklyn-server pull request #839: BROOKLYN-537: fix NPE listing catalog ite...

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/839 BROOKLYN-537: fix NPE listing catalog items Fixes https://issues.apache.org/jira/browse/BROOKLYN-537 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (BROOKLYN-537) NPE listing catalog items

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174491#comment-16174491 ] ASF GitHub Bot commented on BROOKLYN-537: - GitHub user aledsage opened a pull request:

[GitHub] brooklyn-server issue #837: [IMPORTANT] Fix FunctionSensor’s rebind

2017-09-21 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/837 Merging this now to fix the build (and because it's very low risk). But if someone can review it later that would be good! ---

[GitHub] brooklyn-client pull request #60: Fix tests tearDown (to always stop managem...

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-client/pull/60 Fix tests tearDown (to always stop management context) You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-client

[GitHub] brooklyn-server pull request #837: [IMPORTANT] Fix FunctionSensor’s rebind

2017-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/837 ---

[GitHub] brooklyn-server issue #837: [IMPORTANT] Fix FunctionSensor’s rebind

2017-09-21 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/837 LGTM ---

[GitHub] brooklyn-server pull request #838: Fix tests tearDown (to always stop manage...

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/838 Fix tests tearDown (to always stop management context) You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server

[GitHub] brooklyn-library pull request #131: Fix tests tearDown (to always stop manag...

2017-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-library/pull/131 Fix tests tearDown (to always stop management context) You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-library

[GitHub] brooklyn-dist pull request #109: Add LICENSE and NOTICE file back to the RPM...

2017-09-21 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/109 Add LICENSE and NOTICE file back to the RPM and DEB packages I missed to add those files in #104, as it required for releases You can merge this pull request into a Git repository by