[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/967#discussion_r194661758 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java --- @@ -194,16 +218,42 @@ private

[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/967#discussion_r194661902 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java --- @@ -182,10 +206,10 @@ private

[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/967#discussion_r194661659 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java --- @@ -106,7 +112,16 @@

[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/967#discussion_r194661727 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java --- @@ -194,16 +218,42 @@ private

[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/967#discussion_r194661916 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java --- @@ -106,7 +112,16 @@

[GitHub] brooklyn-server issue #967: add an /applications/details endpoint which corr...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/967 Thanks @aledsage @geomacy . Great comments. I'll add tests and push all changes addressed except depth. On maxDepth, it's a not uncommon pattern that <0 is infinite, and 0

Re: Add support for br --endpoint?

​Aled, I think i prefer the idea of a profile as its the same pattern that kubectl sorta follow with contexts. I assume we would have a way to delete a profile maybe `br logout --profile staging` For use within build / test pipelines I can see the `.brooklyn_cli` being supplied so to give

[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/967#discussion_r194658631 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java --- @@ -194,16 +218,42 @@ private

Re: Add support for br --endpoint?

Hi all, TL;DR: we can achieve what we want with the existing $BRCLI_HOME environment variable. Therefore suggest we defer this! --- It turns out we already support the alternative suggestion of "custom configuration file" by using the environment variable $BRCLI_HOME. We discovered that our

[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/967#discussion_r194658482 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/ApplicationApi.java --- @@ -53,12 +53,46 @@

[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/967#discussion_r194659942 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java --- @@ -226,6 +276,60 @@ private

Jenkins build is back to normal : brooklyn-library-master-docker #225

See

[GitHub] brooklyn-server pull request #967: add an /applications/details endpoint whi...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/967#discussion_r194659904 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java --- @@ -226,6 +276,60 @@ private

Build failed in Jenkins: brooklyn-master-build-docker #466

See -- Started by upstream project "brooklyn-library-master-docker" build number 225 originally caused by: Started by timer [EnvInject] - Loading node environment variables.

[GitHub] brooklyn-server issue #967: add an /applications/details endpoint which corr...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/967 tests added and all comments addressed except for `depth` as noted (which now has improved docs/comments) ---

[GitHub] brooklyn-server issue #969: Add registered types test

Github user duncangrant commented on the issue: https://github.com/apache/brooklyn-server/pull/969 @geomacy regarding the naming I don't think tags is relevant to the tests. The mechanism for comparison could be changed later without changing the tests. I see this as a file of tests

Jenkins build is back to normal : brooklyn-master-build-docker #467

See