[GitHub] brooklyn-ui issue #93: new layout (separable palette) tidies

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/93 all addressed as part of #93 ---

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229331551 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -243,4 +285,6 @@ function

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229331445 --- Diff: ui-modules/blueprint-composer/app/views/main/graphical/edit/add/add.js --- @@ -27,17 +27,18 @@ export const graphicalEditAddState = {

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229306022 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector-palette-footer.html --- @@ -0,0 +1,60 @@ + + +

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229330825 --- Diff: ui-modules/blueprint-composer/app/components/providers/palette-service.provider.js --- @@ -37,7 +37,9 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229309854 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed to

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229322252 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed to

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229322318 --- Diff: ui-modules/blueprint-composer/package.json --- @@ -60,7 +60,8 @@ "lodash": "^4.16.4", "ngclipboard": "^1.1.1",

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229348023 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -110,6 +110,38 @@ export function

[GitHub] brooklyn-ui pull request #91: Add callback for customising catalog save conf...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/91 ---

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229330252 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -127,15 +169,15 @@ function

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229329675 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -20,7 +20,14 @@ import angular from

[GitHub] brooklyn-ui pull request #91: Add callback for customising catalog save conf...

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/91#discussion_r229303730 --- Diff: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js --- @@ -54,11 +57,17 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229348593 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229350690 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -30,15 +47,43 @@ export function

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229345048 --- Diff: ui-modules/blueprint-composer/app/views/main/graphical/edit/add/add.js --- @@ -27,17 +27,18 @@ export const graphicalEditAddState = {

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229351508 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -230,16 +248,85 @@ function

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/93#discussion_r229344894 --- Diff: ui-modules/blueprint-composer/app/views/main/graphical/edit/add/add.js --- @@ -51,8 +52,11 @@ export function

Build failed in Jenkins: brooklyn-ui-master-docker #102

See Changes: [andrew.kennedy] Add callback for customising catalog save configuration -- [...truncated 1.60 MB...] Downloading from jclouds-snapshots:

[GitHub] brooklyn-ui issue #94: Composer recent and filters

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/94 addresses all PR comments ---

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229345898 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed to the

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229351261 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -127,15 +135,15 @@ function

[GitHub] brooklyn-ui issue #92: Expand relationship support to memberspecs

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/92 LGTM. feels like we should support multiple spec config keys in which case the single field `memberspec` wouldn't be quite right and we'd need to compute a different `x` as we do for `y` --

Build failed in Jenkins: brooklyn-ui-master-docker #104

See -- [...truncated 1.59 MB...] Downloading from jclouds-snapshots: https://repository.apache.org/content/repositories/snapshots/org/testng/testng/6.10/testng-6.10.pom

[GitHub] brooklyn-ui pull request #92: Expand relationship support to memberspecs

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/92 ---

[GitHub] brooklyn-ui issue #94: Composer recent and filters

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/94 Ah makes sense, you want the height therefore the template must be compiled. `$scope.$applyAsync` is executing at the beginning of a digest cycle therefore this info is not available.

[GitHub] brooklyn-ui issue #93: new layout (separable palette) tidies

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/93 Thanks @ahgittin, merging ---

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229355523 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -110,6 +110,38 @@ export function

Build failed in Jenkins: brooklyn-ui-master-docker #106

See Changes: [alex.heneveld] palette allows filters to be specified, with placeholder for recent [alex.heneveld] improve sort by, including sort-by recency [alex.heneveld] "Recent" filter shows a

Build failed in Jenkins: brooklyn-ui-master-docker #107

See -- [...truncated 1.60 MB...] Downloading from jclouds-snapshots: https://repository.apache.org/content/repositories/snapshots/org/testng/testng/6.10/testng-6.10.pom

[GitHub] brooklyn-ui pull request #73: Adding travis config file for an easier build

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/73 ---

[GitHub] brooklyn-ui pull request #93: new layout (separable palette) tidies

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/93 ---

Build failed in Jenkins: brooklyn-ui-master-docker #103

See Changes: [github] Added travis file [github] Exclude travis file from license checker [github] Added cache in travis [thomas.bouron] Expand relationship support to memberspecs

Build failed in Jenkins: brooklyn-dist-master-docker #103

See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on ubuntu-4 (ubuntu trusty) in workspace

[GitHub] brooklyn-ui issue #62: Restore slf4j.version property

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/62 @kemitix can you check ^ and update or close this pls? ---

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229358124 --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js --- @@ -127,15 +135,15 @@ function

[GitHub] brooklyn-ui issue #73: Adding travis config file for an easier build

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/73 i can see this being useful. wouldn't mind help @Numerinico maintaining this as and when changes are needed. merging. ---

Build failed in Jenkins: brooklyn-ui-master-docker #105

See Changes: [alex.heneveld] rename btn-ouline to btn-outline [alex.heneveld] dynamically compute pagination limit for palette based on height [alex.heneveld] minor styling changes to make palette

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/94 ---

Re: Windows builds

Hi Richard. Any news on this? I was cleaning up my inbox and I have to admit that I forgot about it. Although, would be good if we find a solution to this build failure. Best. On Tue, 24 Jul 2018 at 11:11 Richard Downer wrote: > Thomas, > > I've done a build on my Windows laptop and I can see

[GitHub] brooklyn-ui pull request #94: Composer recent and filters

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/94#discussion_r229267319 --- Diff: ui-modules/blueprint-composer/app/components/providers/recently-used-service.provider.js --- @@ -0,0 +1,62 @@ +/* + * Licensed to the