[jira] [Commented] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276971#comment-15276971 ] ASF GitHub Bot commented on BROOKLYN-259: - Github user johnmccabe commented on the pull request:

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user johnmccabe commented on the pull request: https://github.com/apache/brooklyn-server/pull/132#issuecomment-217979935 Looks like we're not overriding the `null` credentials returned in the `NodeMetadata` in JcloudsLocation.findNodeOrThrow. These should be getting replaced

Build failed in Jenkins: brooklyn-master-windows #105

See Changes: [alex.heneveld] simplify quick-start build instructions -- [...truncated 47009 lines...] [JENKINS] Archiving

[GitHub] brooklyn-docs pull request: tidy #1 of maven build instructions

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs pull request: Update the tests documentation

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs pull request: Update server-cli-reference.md

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs pull request: Documenting `waitWindowsToStart' locat...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs pull request: Inclusion of catalog items inside othe...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs pull request: Update the tests documentation

Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/55#discussion_r62547620 --- Diff: guide/yaml/test/test-entities.md --- @@ -89,6 +93,10 @@ The `TestEffector` entity invokes the specified effector on a target entity. If

Build failed in Jenkins: brooklyn-master-windows #104

See -- [...truncated 22522 lines...] 2016-05-09 19:17:41,626 WARN Error invoking replaceMember at DynamicClusterImpl{id=i79NORsS}: In DynamicClusterImpl{id=i79NORsS}, failed to grow, to replace

[GitHub] brooklyn-docs pull request: Documenting `waitWindowsToStart' locat...

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-docs/pull/52#issuecomment-217943628 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-docs pull request: Update server-cli-reference.md

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-docs/pull/54#issuecomment-217943793 good spot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-docs pull request: Inclusion of catalog items inside othe...

Github user ahgittin commented on the pull request: https://github.com/apache/brooklyn-docs/pull/49#issuecomment-217943347 @neykov the comments above are nice to have but can be a follow-on PR. this is a good addition already so merging. --- If your project is set up for it, you

[jira] [Commented] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276549#comment-15276549 ] ASF GitHub Bot commented on BROOKLYN-259: - Github user johnmccabe commented on a diff in the

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user johnmccabe commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/132#discussion_r62524649 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsByonLocationResolver.java --- @@ -61,129 +56,140 @@

[GitHub] brooklyn-server pull request: Remove feature brookly-software-cm

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276530#comment-15276530 ] ASF GitHub Bot commented on BROOKLYN-259: - Github user johnmccabe commented on a diff in the

[GitHub] brooklyn-server pull request: Remove feature brookly-software-cm

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/135#issuecomment-217902997 +1 for the quick fix. A proper solution would be to move `karaf/apacke-brooklyn` to `brooklyn-dist`. --- If your project is set up for it, you can reply to

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user johnmccabe commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/132#discussion_r62522025 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsByonLocationResolverStubbedTest.java --- @@ -0,0 +1,157 @@

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user johnmccabe commented on the pull request: https://github.com/apache/brooklyn-server/pull/132#issuecomment-217896393 Throwing an NPE when deploying an app to a JcloudsByonLocation that was working before this PR: ``` 2016-05-09 14:30:30,074 WARN

[GitHub] brooklyn-server pull request: Remove feature brookly-software-cm

Github user geomacy commented on the pull request: https://github.com/apache/brooklyn-server/pull/135#issuecomment-217895958 👍 LGTM. This was causing problems with a build, when tests were failing upon building with a clean Maven repository. Taking the cm feature out allows the

[GitHub] brooklyn-server pull request: Remove feature brookly-software-cm

GitHub user duncangrant opened a pull request: https://github.com/apache/brooklyn-server/pull/135 Remove feature brookly-software-cm You can merge this pull request into a Git repository by running: $ git pull https://github.com/duncangrant/brooklyn-server

[jira] [Commented] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276418#comment-15276418 ] ASF GitHub Bot commented on BROOKLYN-259: - Github user sjcorbett commented on a diff in the pull

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/132#discussion_r62505309 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsByonLocationResolver.java --- @@ -61,129 +56,140 @@ *

[jira] [Commented] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276398#comment-15276398 ] ASF GitHub Bot commented on BROOKLYN-259: - Github user sjcorbett commented on a diff in the pull

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/132#discussion_r62503507 --- Diff: core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java --- @@ -147,8 +168,21 @@ public void

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/132#discussion_r62503400 --- Diff: core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java --- @@ -147,8 +168,21 @@ public void

[jira] [Commented] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276395#comment-15276395 ] ASF GitHub Bot commented on BROOKLYN-259: - Github user sjcorbett commented on a diff in the pull

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r62474640 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/FirstFromRemovalStrategy.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the