[GitHub] brooklyn-docs issue #231: document the new ElectPrimaryPolicy and related it...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-docs/pull/231 thanks @drigodwin - all addressed ---

[GitHub] brooklyn-server issue #878: Misc enhancements - warnings and more lookup con...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/878 retest this please expect that failure is spurious - PR included in #879 which passes ---

[GitHub] brooklyn-server pull request #875: Fix execution context on subscriptions

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/875 ---

[GitHub] brooklyn-server pull request #881: BROOKLYN-547: fix VanillaSoftwareProcess....

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/881 ---

[jira] [Commented] (BROOKLYN-547) VanillaSoftwareProcess.restart fails if sshMonitoring disabled

[ https://issues.apache.org/jira/browse/BROOKLYN-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241158#comment-16241158 ] ASF GitHub Bot commented on BROOKLYN-547: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-server issue #882: Reuse bundle's catalog.bom from server-cli modul...

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/882 @ahgittin demo items are not remove, there are added to the catalog in `brooklyn-dist`. BTW, I did add them, there were always there, I just remove the duplication with catalog items'

[GitHub] brooklyn-dist issue #112: Reuse bundle's catalog.bom from server-cli module

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-dist/pull/112 refactoring suggested at https://github.com/apache/brooklyn-server/pull/882 but not necessary. fine to merge this when you're happy with that. ---

[GitHub] brooklyn-server issue #882: Reuse bundle's catalog.bom from server-cli modul...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/882 aha never mind i think this has been done by having the templates in https://github.com/apache/brooklyn-dist/pull/112 . feels cleaner not to have blueprints introduced in the

[GitHub] brooklyn-server issue #882: Reuse bundle's catalog.bom from server-cli modul...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/882 Are the demo items `1-server-template` ... `4-` still included? Looks like they are deleted here. I think docs, tutorials, etc refer to them and they are a good getting-started sequence.

[jira] [Commented] (BROOKLYN-547) VanillaSoftwareProcess.restart fails if sshMonitoring disabled

[ https://issues.apache.org/jira/browse/BROOKLYN-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240940#comment-16240940 ] ASF GitHub Bot commented on BROOKLYN-547: - Github user duncangrant commented on the issue:

[GitHub] brooklyn-server issue #881: BROOKLYN-547: fix VanillaSoftwareProcess.restart...

Github user duncangrant commented on the issue: https://github.com/apache/brooklyn-server/pull/881 Tested fairly thoroughly using a blueprint which was previously failing to restart correctly. ---

[jira] [Commented] (BROOKLYN-547) VanillaSoftwareProcess.restart fails if sshMonitoring disabled

[ https://issues.apache.org/jira/browse/BROOKLYN-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240819#comment-16240819 ] ASF GitHub Bot commented on BROOKLYN-547: - Github user duncangrant commented on a diff in the

[GitHub] brooklyn-server pull request #881: BROOKLYN-547: fix VanillaSoftwareProcess....

Github user duncangrant commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/881#discussion_r149190906 --- Diff: software/base/src/test/java/org/apache/brooklyn/entity/software/base/VanillaSoftwareProcessTest.java --- @@ -294,4 +309,63 @@ public

Jenkins build is back to normal : brooklyn-server-master #782

See

[GitHub] brooklyn-dist pull request #112: Reuse bundle's catalog.bom from server-cli ...

GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/112 Reuse bundle's catalog.bom from server-cli module As https://github.com/apache/brooklyn-server/pull/882 now includes the entities from `server-cli`, therefore they need to be removed from

[GitHub] brooklyn-server pull request #882: Reuse bundle's catalog.bom from server-cl...

GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/882 Reuse bundle's catalog.bom from server-cli module Some items were missing when I did the update of `catalog.bom` files to use bundles. This fixes it by including this bundle within the

[jira] [Commented] (BROOKLYN-547) VanillaSoftwareProcess.restart fails if sshMonitoring disabled

[ https://issues.apache.org/jira/browse/BROOKLYN-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240616#comment-16240616 ] ASF GitHub Bot commented on BROOKLYN-547: - GitHub user aledsage opened a pull request:

[GitHub] brooklyn-server pull request #881: BROOKLYN-547: fix VanillaSoftwareProcess....

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/881 BROOKLYN-547: fix VanillaSoftwareProcess.restart with no ssh-monitoring You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (BROOKLYN-547) VanillaSoftwareProcess.restart fails if sshMonitoring disabled

Aled Sage created BROOKLYN-547: -- Summary: VanillaSoftwareProcess.restart fails if sshMonitoring disabled Key: BROOKLYN-547 URL: https://issues.apache.org/jira/browse/BROOKLYN-547 Project: Brooklyn

[GitHub] brooklyn-library pull request #139: Update visitors-creation-script.sql

GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-library/pull/139 Update visitors-creation-script.sql Need all privileges for three tier app You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149106485 --- Diff: guide/blueprints/_elect-primary-policies.md --- @@ -0,0 +1,149 @@ + +There are a collection of policies, enrichers, and effectors

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149105773 --- Diff: guide/blueprints/_elect-primary-policies.md --- @@ -0,0 +1,149 @@ + +There are a collection of policies, enrichers, and effectors

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149114860 --- Diff: guide/blueprints/_elect-primary-policies.md --- @@ -0,0 +1,149 @@ + +There are a collection of policies, enrichers, and effectors

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149114727 --- Diff: guide/blueprints/_elect-primary-policies.md --- @@ -0,0 +1,149 @@ + +There are a collection of policies, enrichers, and effectors

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149119018 --- Diff: guide/blueprints/policies.md --- @@ -78,11 +78,18 @@ example of these working together. -

[GitHub] brooklyn-server issue #874: avoid UpdatingMapTest non-det failure

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/874 retest this please ---

[GitHub] brooklyn-server issue #873: Upgrade types and bundles as per bundle manifest...

Github user robertgmoss commented on the issue: https://github.com/apache/brooklyn-server/pull/873 LGTM ---

[GitHub] brooklyn-server pull request #880: Fix rebind EntitySpec with policies ref

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/880 ---

[GitHub] brooklyn-server issue #880: Fix rebind EntitySpec with policies ref

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/880 aha gotcha - do the `s/policy/enricher` if you haven't already then good to merge ---

Brooklyn REST API - omitting fields in JSON objects

Hi All- Until recently our REST API returned full records in most cases, including often lots of empty lists and maps and sometimes nulls -- such as `constraints: []` on all config keys. The widespread preference in REST / JSON community seems to be to omit these unless there is a very

[GitHub] brooklyn-server issue #880: Fix rebind EntitySpec with policies ref

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/880 @ahgittin thanks. The rebind error was for an empty list of policies (which I think is the default, so rebind should have been failing for any upgrade from old to new persisted state!).

[GitHub] brooklyn-server issue #880: Fix rebind EntitySpec with policies ref

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/880 Good thorough fix. One item needing fixed -- should be `enrichers = null` in second `readResolve` block. Are there known instances where a policy/enricher would have been

[GitHub] brooklyn-server pull request #880: Fix rebind EntitySpec with policies ref

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/880#discussion_r149097024 --- Diff: api/src/main/java/org/apache/brooklyn/api/entity/EntitySpec.java --- @@ -112,12 +118,29 @@ private final List members =

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-docs/pull/231 document the new ElectPrimaryPolicy and related items Documentation for https://github.com/apache/brooklyn-server/pull/879 This has been developed in the field but is now

[GitHub] brooklyn-server pull request #880: Fix rebind EntitySpec with policies ref

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/880 Fix rebind EntitySpec with policies ref You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server

[GitHub] brooklyn-server pull request #879: Elect primary / failover policies

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/879 Elect primary / failover policies Adds an `ElectPrimaryPolicy` and related items to facilitate contexts which want a primary node, with failover/reelection, and ability to propagate

[GitHub] brooklyn-server pull request #878: Misc enhancements - warnings and more loo...

GitHub user ahgittin opened a pull request: https://github.com/apache/brooklyn-server/pull/878 Misc enhancements - warnings and more lookup conveniences Builds on #875 (review that first) adding just: * a `Task.warning(msg, false)` that doesn't `LOG.warning` *

Build failed in Jenkins: brooklyn-server-master #781

See Changes: [duncan.godwin] Stop memberSpecs being inherited [duncan.godwin] Add test -- [...truncated 6.74 MB...] at

[GitHub] brooklyn-server issue #877: update maven-bundle-plugin to include headers fo...

Github user robertgmoss commented on the issue: https://github.com/apache/brooklyn-server/pull/877 It should be safe to add these headers here since it will not be inherited by `brooklyn-downstream-parent` ---

[GitHub] brooklyn-server pull request #877: update maven-bundle-plugin to include hea...

GitHub user robertgmoss opened a pull request: https://github.com/apache/brooklyn-server/pull/877 update maven-bundle-plugin to include headers for catalog bundles rebind after upgrade depends on #873 You can merge this pull request into a Git repository by running: $ git

[GitHub] brooklyn-library pull request #138: add maven-bundle-plugin configuration to...

Github user robertgmoss closed the pull request at: https://github.com/apache/brooklyn-library/pull/138 ---

[GitHub] brooklyn-library issue #138: add maven-bundle-plugin configuration to allow ...

Github user robertgmoss commented on the issue: https://github.com/apache/brooklyn-library/pull/138 closing in favour of adding higher up the pom hierarchy ---

[GitHub] brooklyn-server pull request #876: Stop memberSpecs being inherited

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/876 ---

[GitHub] brooklyn-server issue #876: Stop memberSpecs being inherited

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/876 LGTM; merging. ---

[GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/873#discussion_r149052420 --- Diff: launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynLauncherRebindCatalogOsgiTest.java --- @@ -740,20 +744,82 @@ public void

[GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/873#discussion_r149049524 --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/BundleUpgradeParser.java --- @@ -312,6 +335,90 @@ public static boolean

[GitHub] brooklyn-server pull request #873: Upgrade types and bundles as per bundle m...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/873#discussion_r149034987 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/XmlMementoSerializer.java --- @@ -341,7 +371,7 @@ public void marshal(Object

[GitHub] brooklyn-library pull request #138: add maven-bundle-plugin configuration to...

GitHub user robertgmoss opened a pull request: https://github.com/apache/brooklyn-library/pull/138 add maven-bundle-plugin configuration to allow rebind (depends on brooklyn-server#873) You can merge this pull request into a Git repository by running: $ git pull

[jira] [Resolved] (BROOKLYN-546) On restart fails to install catalog bundles due to existing bundles installed with different location

[ https://issues.apache.org/jira/browse/BROOKLYN-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-546. Resolution: Fixed Fix Version/s: 1.0.0 > On restart fails to install catalog bundles due