[GitHub] brooklyn-server issue #974: Update Brooklyn codebase to build the newly dona...

2018-07-26 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/974 This too seems to be working nicely now. :) ---

[GitHub] brooklyn-server issue #974: Update Brooklyn codebase to build the newly dona...

2018-07-26 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/974 I've fixed a few other places where `brooklyn.war` was mentioned, as noted. Have left the launcher project, as discussed, even though most of it isn't really needed. Also removed

[GitHub] brooklyn-ui issue #54: Update Brooklyn codebase to build the newly donated U...

2018-07-26 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/54 Looks good. Minor changes as ^. Will check the others and merge them all. ---

[GitHub] brooklyn-docs issue #263: Update docs to match the new Brooklyn UI

2018-07-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/263 @ahgittin Added back the web console issues page + updated the IDE setup ---

[GitHub] brooklyn-docs issue #263: Update docs to match the new Brooklyn UI

2018-07-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/263 > Fabulously thorough job. Thanks! > I think guide/ops/troubleshooting/web-console-issues.md is still relevant, so we shouldn't delete that page, should we? (Also, if we do

[GitHub] brooklyn-server issue #974: Update Brooklyn codebase to build the newly dona...

2018-07-26 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/974 @ahgittin I voluntarily didn't touch the `BrooklynLauncher` as the "classic launcher" only has been deprecated in `0.12.0`. I think remove it should be part of another PR. I just

[GitHub] brooklyn-dist issue #124: Update Brooklyn codebase to build the newly donate...

2018-07-26 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-dist/pull/124 Nice and simple, and looks right. Testing now. ---

[GitHub] brooklyn-docs issue #263: Update docs to match the new Brooklyn UI

2018-07-26 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-docs/pull/263 Fabulously thorough job. I think `guide/ops/troubleshooting/web-console-issues.md` is still relevant, so we shouldn't delete that page, should we? (Also, if we _do_ delete it,

[GitHub] brooklyn-library issue #156: Update Brooklyn codebase to build the newly don...

2018-07-26 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-library/pull/156 looks good, will merge once apache/brooklyn-server#974 is in ---

[GitHub] brooklyn-server issue #974: Update Brooklyn codebase to build the newly dona...

2018-07-26 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/974 I think this is incomplete; these references need to be changed/removed: ``` % grep4js brooklyn.war | grep -v log: ./launcher/pom.xml:

[GitHub] brooklyn-ui pull request #54: Update Brooklyn codebase to build the newly do...

2018-07-26 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/54 Update Brooklyn codebase to build the newly donated UI Replace old UI by the new one. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-library pull request #156: Update Brooklyn codebase to build the ne...

2018-07-26 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/156 Update Brooklyn codebase to build the newly donated UI See discussion about the donated UI:

[GitHub] brooklyn-server pull request #974: Update Brooklyn codebase to build the new...

2018-07-26 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/974 Update Brooklyn codebase to build the newly donated UI See discussion about the donated UI:

Re: [VOTE] New Angular UI for Brooklyn

2018-07-26 Thread John McCabe
This is fantastic news, congrats to all involved !! On Thu, Jul 26, 2018 at 11:54 AM Alex Heneveld < alex.henev...@cloudsoftcorp.com> wrote: > > Thanks Richard, Thomas. > > i have done as you suggest, pushing from a merged branch directly to > master. [1] is the result of `mkdir new ; cd new ;

[GitHub] brooklyn-docs pull request #263: Update docs to match the new Brooklyn UI

2018-07-26 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/263 Update docs to match the new Brooklyn UI This is the required changes to match the newly donated Brooklyn UI (see

Re: [VOTE] New Angular UI for Brooklyn

2018-07-26 Thread Alex Heneveld
Thanks Richard, Thomas. i have done as you suggest, pushing from a merged branch directly to master. [1] is the result of `mkdir new ; cd new ; curl https://issues.apache.org/jira/secure/attachment/12932670/brooklyn-ui-angular.tgz | tar xvz`. [2] is a few minor RAT/license header tweaks

Re: [VOTE] New Angular UI for Brooklyn

2018-07-26 Thread Richard Downer
Alex, Agree with Thomas - the code has been [VOTE]ed in so there's no need for a second stage of review, and pushing a massive PR isn't easy to navigate in the GitHub UI. So just push straight to master on the Apache git repo. There's a safety net in that the code is going into a `new`

[RESULT][VOTE] New Angular UI for Brooklyn

2018-07-26 Thread Alex Heneveld
To formally close this, I note the vote passes with: * 6 binding +1s * 0 non-binding +1s * no 0 or -1 votes Vote thread link: http://mail-archives.apache.org/mod_mbox/brooklyn-dev/201807.mbox/%3C5dc7ad59-795e-fa7a-af32-918848229b32%40CloudsoftCorp.com%3E Binding +1s: Thomas Bouron Mark

[RESULT] [IP-CLEARANCE] "brooklyn-ui-angular" contribution of new UI to Apache Brooklyn

2018-07-26 Thread Alex Heneveld
Hi Incubator PMC, With 72h elapsed and no -1's I understand this to have passed. This thread is now closed.2 I will update the forn [3] and we will continue the process in the Brooklyn PMC. Best Alex On 23/07/2018 09:56, Alex Heneveld wrote: Hi Incubator PMC, // cc dev@brooklyn The

Build failed in Jenkins: brooklyn-library-master-docker #270

2018-07-26 Thread Apache Jenkins Server
See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on ubuntu-eu2 (ubuntu trusty) in workspace