Build failed in Jenkins: brooklyn-master-build-docker #1450

2019-02-11 Thread Apache Jenkins Server 
See 


--
[...truncated 14.69 MB...]
at sun.rmi.registry.RegistryImpl.lookup(RegistryImpl.java:227)
at 
sun.rmi.registry.RegistryImpl_Skel.dispatch(RegistryImpl_Skel.java:115)
at 
sun.rmi.server.UnicastServerRef.oldDispatch(UnicastServerRef.java:468)
at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:300)
at sun.rmi.transport.Transport$1.run(Transport.java:200)
at sun.rmi.transport.Transport$1.run(Transport.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
at 
sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:573)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:834)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:688)
at java.security.AccessController.doPrivileged(Native Method)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:687)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
at 
sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:283)
at 
sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:260)
at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:375)
at sun.rmi.registry.RegistryImpl_Stub.lookup(RegistryImpl_Stub.java:119)
at 
org.ops4j.pax.exam.rbc.client.intern.RemoteBundleContextClientImpl.getRemoteBundleContext(RemoteBundleContextClientImpl.java:248)
at 
org.ops4j.pax.exam.rbc.client.intern.RemoteBundleContextClientImpl.waitForState(RemoteBundleContextClientImpl.java:218)
at 
org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.waitForState(KarafTestContainer.java:659)
at 
org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.startKaraf(KarafTestContainer.java:262)
at 
org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.start(KarafTestContainer.java:194)
at 
org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.setUp(EagerSingleStagedReactor.java:86)
at 
org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.beforeClass(EagerSingleStagedReactor.java:136)
at 
org.ops4j.pax.exam.spi.reactors.ReactorManager.beforeClass(ReactorManager.java:457)
at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:97)
at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at 
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:108)
at 
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:78)
at 
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:54)
at 
org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:144)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)

Failure when constructing test  Time elapsed: 0.229 sec  <<< ERROR!
java.lang.RuntimeException: Container never came up
at 
org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.stop(KarafTestContainer.java:629)
at 
org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.tearDown(EagerSingleStagedReactor.java:118)
at 
org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.afterClass(EagerSingleStagedReactor.java:132)
at 
org.ops4j.pax.exam.spi.reactors.ReactorManager.afterClass(ReactorManager.java:441)
at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:107)
at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93)
at org.junit.runners.Suite.runChild(Suite.java:128)

Build failed in Jenkins: brooklyn-master-build-docker #1449

2019-02-11 Thread Apache Jenkins Server 
See 


--
[...truncated 15.89 MB...]
at sun.rmi.registry.RegistryImpl.lookup(RegistryImpl.java:227)
at 
sun.rmi.registry.RegistryImpl_Skel.dispatch(RegistryImpl_Skel.java:115)
at 
sun.rmi.server.UnicastServerRef.oldDispatch(UnicastServerRef.java:468)
at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:300)
at sun.rmi.transport.Transport$1.run(Transport.java:200)
at sun.rmi.transport.Transport$1.run(Transport.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
at 
sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:573)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:834)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:688)
at java.security.AccessController.doPrivileged(Native Method)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:687)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
at 
sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:283)
at 
sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:260)
at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:375)
at sun.rmi.registry.RegistryImpl_Stub.lookup(RegistryImpl_Stub.java:119)
at 
org.ops4j.pax.exam.rbc.client.intern.RemoteBundleContextClientImpl.getRemoteBundleContext(RemoteBundleContextClientImpl.java:248)
at 
org.ops4j.pax.exam.rbc.client.intern.RemoteBundleContextClientImpl.waitForState(RemoteBundleContextClientImpl.java:218)
at 
org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.waitForState(KarafTestContainer.java:659)
at 
org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.startKaraf(KarafTestContainer.java:262)
at 
org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.start(KarafTestContainer.java:194)
at 
org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.setUp(EagerSingleStagedReactor.java:86)
at 
org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.beforeClass(EagerSingleStagedReactor.java:136)
at 
org.ops4j.pax.exam.spi.reactors.ReactorManager.beforeClass(ReactorManager.java:457)
at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:97)
at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at 
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:108)
at 
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:78)
at 
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:54)
at 
org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:144)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)

Failure when constructing test  Time elapsed: 0.212 sec  <<< ERROR!
java.lang.RuntimeException: Container never came up
at 
org.ops4j.pax.exam.karaf.container.internal.KarafTestContainer.stop(KarafTestContainer.java:629)
at 
org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.tearDown(EagerSingleStagedReactor.java:118)
at 
org.ops4j.pax.exam.spi.reactors.EagerSingleStagedReactor.afterClass(EagerSingleStagedReactor.java:132)
at 
org.ops4j.pax.exam.spi.reactors.ReactorManager.afterClass(ReactorManager.java:441)
at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:107)
at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93)
at org.junit.runners.Suite.runChild(Suite.java:128)

[GitHub] ahgittin commented on issue #1040: [WIP] [Security] Bump logback.version from 1.0.7 to 1.2.3

2019-02-11 Thread GitBox 
ahgittin commented on issue #1040: [WIP] [Security] Bump logback.version from 
1.0.7 to 1.2.3
URL: https://github.com/apache/brooklyn-server/pull/1040#issuecomment-462598937
 
 
   unsurprising that this jump caused issues.  this CVE doesn't seem to upset 
users so not a priority -- and lots of people seem to stick with 1.0.7 -- but 
if someone has time to dig a little deeper and it isn't too hard to make 1.2.3 
work it's good to be on the latest version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ahgittin opened a new pull request #1042: bump commons-compress

2019-02-11 Thread GitBox 
ahgittin opened a new pull request #1042: bump commons-compress
URL: https://github.com/apache/brooklyn-server/pull/1042
 
 
   from 1.4 to 1.4.1 to avoid being flagged as a CVE
   
   (both very old versions, not tested with 1.18, but 1.4.1 has the fix in 
question)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit merged pull request #1038: [WIP] [Security] Bump xstream from 1.4.8 to 1.4.11.1

2019-02-11 Thread GitBox 
asfgit merged pull request #1038: [WIP] [Security] Bump xstream from 1.4.8 to 
1.4.11.1
URL: https://github.com/apache/brooklyn-server/pull/1038
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ahgittin commented on issue #1038: [WIP] [Security] Bump xstream from 1.4.8 to 1.4.11.1

2019-02-11 Thread GitBox 
ahgittin commented on issue #1038: [WIP] [Security] Bump xstream from 1.4.8 to 
1.4.11.1
URL: https://github.com/apache/brooklyn-server/pull/1038#issuecomment-462597312
 
 
   don't think anything else is needed?  merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: brooklyn-master-build-docker-pipeline #146

2019-02-11 Thread Apache Jenkins Server 
See 


--
[...truncated 135210 lines...]
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.3/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.4/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5/1.5 MB
Progress (1): 1.5 MB

Downloaded from central: 
https://repo.maven.apache.org/maven2/com/google/guava/guava/10.0.1/guava-10.0.1.jar
 (1.5 MB at 5.4 MB/s)
[INFO] Node v8.4.0 is already installed.
[INFO] NPM 5.4.1 is already installed.
[INFO] 
[INFO] --- frontend-maven-plugin:1.3:npm (npm install) @ brooklyn-ui-utils ---
[INFO] Running 'npm install' in 
/home/jenkins/jenkins-slave/workspace/brooklyn-master-build-docker-pipeline/brooklyn-ui/ui-modules/utils
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] Unhandled rejection Error: EACCES: permission denied, mkdir '/.npm'
[ERROR] 
[ERROR] 
┌──────────────────────────────────────────────┐
[ERROR] │   npm update check failed│
[ERROR] │ Try running with sudo or get access  │
[ERROR] │ to the local update config store via │
[ERROR] │ sudo chown -R $USER:$(id -gn $USER) /.config │
[ERROR] 
└──────────────────────────────────────────────┘
[ERROR] npm ERR! cb() never called!
[ERROR] 
[ERROR] npm ERR! This is an error with npm itself. Please report this error at:
[ERROR] npm ERR! 
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn Server Root ... SUCCESS [  5.782 s]
[INFO] Brooklyn Parent Project  SUCCESS [  6.754 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [  9.042 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  0.402 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 30.826 s]
[INFO] Brooklyn API ... SUCCESS [  3.421 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.168 s]
[INFO] CAMP Base .. SUCCESS [  4.583 s]
[INFO] Brooklyn Test Support .. SUCCESS [  2.510 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [ 13.691 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  0.201 s]
[INFO] CAMP Server  SUCCESS [ 13.208 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  3.506 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  2.292 s]
[INFO] Brooklyn Core .. SUCCESS [04:25 min]
[INFO] Brooklyn Policies .. SUCCESS [ 33.607 s]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [ 18.602 s]
[INFO] Brooklyn Secure JMXMP Agent

[GitHub] asfgit merged pull request #1037: tidy string/primitive coercion

2019-02-11 Thread GitBox 
asfgit merged pull request #1037: tidy string/primitive coercion
URL: https://github.com/apache/brooklyn-server/pull/1037
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ahgittin commented on issue #1037: tidy string/primitive coercion

2019-02-11 Thread GitBox 
ahgittin commented on issue #1037: tidy string/primitive coercion
URL: https://github.com/apache/brooklyn-server/pull/1037#issuecomment-462466437
 
 
   server-side testing looks broken or slow -- tests pass locally now.  merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : brooklyn-master-build-docker #1445

2019-02-11 Thread Apache Jenkins Server 
See

[GitHub] aledsage commented on issue #1039: [WIP] [Security] Bump bouncycastle.version from 1.51 to 1.60

2019-02-11 Thread GitBox 
aledsage commented on issue #1039: [WIP] [Security] Bump bouncycastle.version 
from 1.51 to 1.60
URL: https://github.com/apache/brooklyn-server/pull/1039#issuecomment-462410666
 
 
   We use various deprecated bouncycastle classes (e.g. in 
`org.apache.brooklyn.util.core.crypto.SecureKeys`). That might be causing 
problems for the upgrade of bouncycastle version. But I've not looked into the 
errors further.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kemitix commented on issue #1041: [WIP] [Security] Bump commons-compress from 1.4 to 1.18

2019-02-11 Thread GitBox 
kemitix commented on issue #1041: [WIP] [Security] Bump commons-compress from 
1.4 to 1.18
URL: https://github.com/apache/brooklyn-server/pull/1041#issuecomment-462409516
 
 
   @aledsage `commons-compress` 1.18 no longer has that dependency. I'll try 
taking it out and remove it from the bundle, and check that it still works. The 
`xz` library is a public domain compression algorithm, so I'm guessing it's 
been either absorbed or de-supported by `commons-compress`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aledsage commented on issue #1039: [WIP] [Security] Bump bouncycastle.version from 1.51 to 1.60

2019-02-11 Thread GitBox 
aledsage commented on issue #1039: [WIP] [Security] Bump bouncycastle.version 
from 1.51 to 1.60
URL: https://github.com/apache/brooklyn-server/pull/1039#issuecomment-462407963
 
 
   Also not sure if sshj will work properly when compiled against v1.51 and 
then using v1.60:
   ```
   [INFO] |  |  +- com.hierynomus:sshj:jar:0.20.0:compile
   [INFO] |  |  |  +- org.bouncycastle:bcprov-jdk15on:jar:1.51:compile
   ```
   
   (As an aside - or maybe worth trying to upgrade?! - the latest sshj is 
v0.27.0, which depends on bouncycastle 1.60: 
https://search.maven.org/artifact/com.hierynomus/sshj/0.27.0/jar)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aledsage commented on issue #1039: [WIP] [Security] Bump bouncycastle.version from 1.51 to 1.60

2019-02-11 Thread GitBox 
aledsage commented on issue #1039: [WIP] [Security] Bump bouncycastle.version 
from 1.51 to 1.60
URL: https://github.com/apache/brooklyn-server/pull/1039#issuecomment-462406602
 
 
   Note that from other karaf features in brooklyn, we'll also get the older 
version installed (v1.51). I'm not sure if there are implications for the 
jclouds code of running with v1.60 when compiled against v1.51.
   ```
   Feature jclouds-driver-bouncycastle 2.1.0
   Description:
 Bouncycastle driver for jclouds
   Feature has no configuration
   Feature has no configuration files
   Feature depends on:
 jclouds 2.1.0
   Feature contains followed bundles:
 mvn:org.bouncycastle/bcprov-ext-jdk15on/1.51
 mvn:org.bouncycastle/bcpkix-jdk15on/1.51
 mvn:org.apache.jclouds.driver/jclouds-bouncycastle/2.1.0
   Feature has no conditionals.
   ```
   And:
   ```
   Feature jclouds-services 2.1.0
   Description:
 OSGi Service Factories for jclouds
   Feature has no configuration
   Feature configuration files: 
 ${karaf.etc}/org.apache.jclouds.credentials.cfg
   Feature depends on:
 aries-blueprint 0.0.0
 jclouds-compute 2.1.0
 jclouds-blobstore 2.1.0
   Feature contains followed bundles:
 
mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.jsch/0.1.54_1
 mvn:org.apache.jclouds.karaf.bundles/jsch-agentproxy-jsch/2.1.0
 mvn:com.jcraft/jsch.agentproxy.connector-factory/0.0.9
 mvn:com.jcraft/jsch.agentproxy.usocket-nc/0.0.9
 mvn:com.jcraft/jsch.agentproxy.sshagent/0.0.9
 
mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.jzlib/1.0.7_1
 mvn:org.bouncycastle/bcprov-ext-jdk15on/1.51
 mvn:org.apache.jclouds.driver/jclouds-bouncycastle/2.1.0
 mvn:org.apache.jclouds.driver/jclouds-slf4j/2.1.0
 mvn:org.apache.jclouds.common/googlecloud/2.1.0
 mvn:org.apache.jclouds.driver/jclouds-jsch/2.1.0
 mvn:org.apache.jclouds.driver/jclouds-log4j/2.1.0
 mvn:org.apache.jclouds.karaf/core/2.1.0
 mvn:org.apache.jclouds.karaf/cache/2.1.0
 mvn:org.apache.jclouds.karaf/recipe/2.1.0
 mvn:org.apache.jclouds.karaf/services/2.1.0
   Feature has no conditionals.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kemitix commented on issue #1041: [WIP] [Security] Bump commons-compress from 1.4 to 1.18

2019-02-11 Thread GitBox 
kemitix commented on issue #1041: [WIP] [Security] Bump commons-compress from 
1.4 to 1.18
URL: https://github.com/apache/brooklyn-server/pull/1041#issuecomment-462406074
 
 
   @aledsage Okay, I'll check what version goes with 1.18 and add a comment to 
both that they need to be updated as a pair.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aledsage commented on issue #1040: [WIP] [Security] Bump logback.version from 1.0.7 to 1.2.3

2019-02-11 Thread GitBox 
aledsage commented on issue #1040: [WIP] [Security] Bump logback.version from 
1.0.7 to 1.2.3
URL: https://github.com/apache/brooklyn-server/pull/1040#issuecomment-462405430
 
 
   Test failure in jenkins is:
   ```
   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) 
on project brooklyn-test-support: Compilation failure: Compilation failure:
   [ERROR] 
/home/jenkins/jenkins-slave/workspace/brooklyn-server-pull-requests@2/test-support/src/main/java/org/apache/brooklyn/test/LogWatcher.java:[160,13]
 method does not override or implement a method from a supertype
   [ERROR] 
/home/jenkins/jenkins-slave/workspace/brooklyn-server-pull-requests@2/test-support/src/main/java/org/apache/brooklyn/test/LogWatcher.java:[185,22]
 cannot find symbol
   [ERROR] symbol: method doEncode(ch.qos.logback.classic.spi.ILoggingEvent)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kemitix commented on issue #1041: [WIP] [Security] Bump commons-compress from 1.4 to 1.18

2019-02-11 Thread GitBox 
kemitix commented on issue #1041: [WIP] [Security] Bump commons-compress from 
1.4 to 1.18
URL: https://github.com/apache/brooklyn-server/pull/1041#issuecomment-462402485
 
 
   @aledsage Look like it might have been an overzealous use of IntelliJ's 
extracting a version value as a property. I'll add a new property to fix it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kemitix commented on issue #1035: DO NOT MERGE Use dependencyManagement from Karaf as a bom

2019-02-11 Thread GitBox 
kemitix commented on issue #1035: DO NOT MERGE Use dependencyManagement from 
Karaf as a bom
URL: https://github.com/apache/brooklyn-server/pull/1035#issuecomment-462401058
 
 
   @aledsage Updated: Overriding the dependency, much as karaf appear to do 
themselves, fixes this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aledsage commented on issue #1041: [WIP] [Security] Bump commons-compress from 1.4 to 1.18

2019-02-11 Thread GitBox 
aledsage commented on issue #1041: [WIP] [Security] Bump commons-compress from 
1.4 to 1.18
URL: https://github.com/apache/brooklyn-server/pull/1041#issuecomment-462399243
 
 
   @kemitix how does this relate in 
`brooklyn-server/karaf/features/src/main/feature/feature.xml`:
   ```
   wrap:mvn:org.tukaani/xz/${commons-compress.version}
   ```
   
   That will break with this version bump because we're reusing the version 
number for some reason?!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aledsage commented on issue #1035: DO NOT MERGE Use dependencyManagement from Karaf as a bom

2019-02-11 Thread GitBox 
aledsage commented on issue #1035: DO NOT MERGE Use dependencyManagement from 
Karaf as a bom
URL: https://github.com/apache/brooklyn-server/pull/1035#issuecomment-462397221
 
 
   I like the approach, the changes look good, but `brooklyn-dist` build fails 
for me with these changes due to the `maven-enforcer-plugin`:
   ```
   [WARNING] 
   Dependency convergence error for javax.xml.bind:jaxb-api:2.3.0 paths to 
dependency are:
   +-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT
 +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT
   +-org.apache.karaf.features:framework:4.2.2
 +-org.apache.karaf.features:base:4.2.2
   +-javax.xml.bind:jaxb-api:2.3.0
   and
   +-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT
 +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT
   +-org.apache.karaf.features:framework:4.2.2
 +-org.apache.karaf.features:base:4.2.2
   +-org.glassfish.jaxb:jaxb-runtime:2.3.1
 +-javax.xml.bind:jaxb-api:2.3.1
   
   [WARNING] Rule 2: org.apache.maven.plugins.enforcer.DependencyConvergence 
failed with message:
   Failed while enforcing releasability the error(s) are [
   Dependency convergence error for javax.xml.bind:jaxb-api:2.3.0 paths to 
dependency are:
   +-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT
 +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT
   +-org.apache.karaf.features:framework:4.2.2
 +-org.apache.karaf.features:base:4.2.2
   +-javax.xml.bind:jaxb-api:2.3.0
   and
   +-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT
 +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT
   +-org.apache.karaf.features:framework:4.2.2
 +-org.apache.karaf.features:base:4.2.2
   +-org.glassfish.jaxb:jaxb-runtime:2.3.1
 +-javax.xml.bind:jaxb-api:2.3.1
   ]
   ```
   
   Annoyingly, this seems to be a problem in Karaf 4.2.2 itself!
   
   https://search.maven.org/artifact/org.apache.karaf.features/base/4.2.2/jar 
depends on:
   ```
   
   javax.xml.bind
   jaxb-api
   2.3.0
   
   
   org.glassfish.jaxb
   jaxb-runtime
   2.3.1
   
   ```
   And 
https://search.maven.org/artifact/org.glassfish.jaxb/jaxb-runtime/2.3.1/jar 
depends on v2.3.1 of `javax.xml.bind:jaxb-api`.
   
   Therefore I'm not sure we can merge this! Maybe we could add some excludes 
or some temporary ugliness like that.
   
   Note that karaf 4.2.3 is recently out as well, which I think will fix that 
incompatibility between jaxb-api version (to use v2.3.2 throughout). But not 
suggesting we rush to upgrade to that, and certainly not in this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kemitix opened a new pull request #1041: [WIP] [Security] Bump commons-compress from 1.4 to 1.18

2019-02-11 Thread GitBox 
kemitix opened a new pull request #1041: [WIP] [Security] Bump commons-compress 
from 1.4 to 1.18
URL: https://github.com/apache/brooklyn-server/pull/1041
 
 
   Bumps commons-compress from 1.4 to 1.18. **This update includes security 
fixes.**
   
   Vulnerabilities fixed
   
   *Sourced from [The Sonatype OSS 
Index](https://ossindex.sonatype.org/vuln/c30fadee-a5fc-47e5-9b28-3bd160719296).*
   
   > **[CVE-2012-2098]  Cryptographic Issues**
   > Algorithmic complexity vulnerability in the sorting algorithms in bzip2 
compressing stream (BZip2CompressorOutputStream) in Apache Commons Compress 
before 1.4.1 allows remote attackers to cause a denial of service (CPU 
consumption) via a file with many repeating inputs.
   > 
   > Affected versions: <= 1.4.0
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kemitix opened a new pull request #1040: [WIP] [Security] Bump logback.version from 1.0.7 to 1.2.3

2019-02-11 Thread GitBox 
kemitix opened a new pull request #1040: [WIP] [Security] Bump logback.version 
from 1.0.7 to 1.2.3
URL: https://github.com/apache/brooklyn-server/pull/1040
 
 
   Bumps `logback.version` from 1.0.7 to 1.2.3.
   
   Updates `logback-classic` from 1.0.7 to 1.2.3. **This update includes 
security fixes.**
   
   Vulnerabilities fixed
   
   *Sourced from [The Sonatype OSS 
Index](https://ossindex.sonatype.org/vuln/391196a7-f007-430b-b47f-cd9a3fec6374).*
   
   > **[CVE-2017-5929]  Deserialization of Untrusted Data**
   > QOS.ch Logback before 1.2.0 has a serialization vulnerability affecting 
the SocketServer and ServerSocketReceiver components.
   > 
   > Affected versions: <= 1.1.10
   
   
   
   
   Updates `logback-core` from 1.0.7 to 1.2.3. **This update includes security 
fixes.**
   
   Vulnerabilities fixed
   
   *Sourced from [The Sonatype OSS 
Index](https://ossindex.sonatype.org/vuln/391196a7-f007-430b-b47f-cd9a3fec6374).*
   
   > **[CVE-2017-5929]  Deserialization of Untrusted Data**
   > QOS.ch Logback before 1.2.0 has a serialization vulnerability affecting 
the SocketServer and ServerSocketReceiver components.
   > 
   > Affected versions: <= 1.1.10
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kemitix opened a new pull request #1039: [WIP] [Security] Bump bouncycastle.version from 1.51 to 1.60

2019-02-11 Thread GitBox 
kemitix opened a new pull request #1039: [WIP] [Security] Bump 
bouncycastle.version from 1.51 to 1.60
URL: https://github.com/apache/brooklyn-server/pull/1039
 
 
   Bumps `bouncycastle.version` from 1.51 to 1.60.
   
   Updates `bcprov-ext-jdk15on` from 1.51 to 1.60. **This update includes 
security fixes.**
   
   Vulnerabilities fixed
   
   *Sourced from [The Sonatype OSS 
Index](https://ossindex.sonatype.org/vuln/3a59870b-28b3-4b6b-86b0-9629ebe9de40).*
   
   > **[CVE-2015-6644] Information disclosure**
   > > An information disclosure vulnerability in Bouncy Castle could enable a 
local malicious application to gain access to user?s private information
   > > 
   > > -- 
[source.android.com](https://source.android.com/security/bulletin/2016-01-01#information_disclosure_vulnerability_in_bouncy_castle)
   > 
   > Affected versions: < 1.55.0
   
   
   
   Changelog
   
   *Sourced from [bcprov-ext-jdk15on's 
changelog](https://github.com/bcgit/bc-java/blob/master/docs/releasenotes.html).*
   
   > 
   > 
   > Bouncy Castle Crypto Package - Release Notes
   > 
   > 
   > 
   > 
   > 
   > Bouncy Castle Crypto Package - Release Notes
   > 
   > 
   > 
   > 
   > 
   > 1.0 Introduction
   > 
   > The Bouncy Castle Crypto package is a Java implementation of 
   > cryptographic algorithms.  The package is organised so that it 
   > contains a light-weight API suitable for use in any environment
   > (including the J2ME) with the additional infrastructure
   > to conform the algorithms to the JCE framework.
   > 
   > 2.0 Release History
   > 
   > 
   > 2.1.1 Version
   > Release: 1.61
   > Date: 2018,
   > 2.1.2 Defects Fixed
   > 
   > Use of EC named curves could be lost if keys were constructed via a 
key factory and algorithm parameters. This has been fixed.
   > RFC3211WrapEngine would not properly handle messages longer than 127 
bytes. This has been fixed.
   > The JCE implementations for RFC3211 would not returned null 
AlgorithmParameters. This has been fixed.
   > 
   > 2.1.3 Additional Features and Functionality
   > 
   > TLS: Finalised support for RFC 8442 cipher suites.
   > 
   > 
   > 2.2.1 Version
   > Release: 1.60
   > Date: 2018, June 30
   > 2.2.2 Defects Fixed
   > 
   > Base64/UrlBase64 would throw an exception on a zero length string. 
This has been fixed.
   > Base64/UrlBase64 would throw an exception if there was whitespace in 
the last 4 characters. This has been fixed.
   > The SM2 Signature JCE class now properly resets of Signature.sign() is 
called.
   > XMSS applies further validation to deserialisation of the BDS tree so 
that failure occurs as soon as tampering is detected (see CVE below).
   > An off by one error in the JsseDefaultHostnameAuthorizer 
isValidNameMatch method has been fixed.
   > BCJSSE: Return empty byte array instead of null, for the null session 
ID.
   > ... (truncated)
   
   
   Commits
   
   - See full diff in [compare view](https://github.com/bcgit/bc-java/commits)
   
   
   
   Updates `bcpkix-jdk15on` from 1.51 to 1.60
   
   Changelog
   
   *Sourced from [bcpkix-jdk15on's 
changelog](https://github.com/bcgit/bc-java/blob/master/docs/releasenotes.html).*
   
   > 
   > 
   > Bouncy Castle Crypto Package - Release Notes
   > 
   > 
   > 
   > 
   > 
   > Bouncy Castle Crypto Package - Release Notes
   > 
   > 
   > 
   > 
   > 
   > 1.0 Introduction
   > 
   > The Bouncy Castle Crypto package is a Java implementation of 
   > cryptographic algorithms.  The package is organised so that it 
   > contains a light-weight API suitable for use in any environment
   > (including the J2ME) with the additional infrastructure
   > to conform the algorithms to the JCE framework.
   > 
   > 2.0 Release History
   > 
   > 
   > 2.1.1 Version
   > Release: 1.61
   > Date: 2018,
   > 2.1.2 Defects Fixed
   > 
   > Use of EC named curves could be lost if keys were constructed via a 
key factory and algorithm parameters. This has been fixed.
   > RFC3211WrapEngine would not properly handle messages longer than 127 
bytes. This has been fixed.
   > The JCE implementations for RFC3211 would not returned null 
AlgorithmParameters. This has been fixed.
   > 
   > 2.1.3 Additional Features and Functionality
   > 
   > TLS: Finalised support for RFC 8442 cipher suites.
   > 
   > 
   > 2.2.1 Version
   > Release: 1.60
   > Date: 2018, June 30
   > 2.2.2 Defects Fixed
   > 
   > Base64/UrlBase64 would throw an exception on a zero length string. 
This has been fixed.
   > Base64/UrlBase64 would throw an exception if there was whitespace in 
the last 4 characters. This has been fixed.
   > The SM2 Signature JCE class now properly resets of Signature.sign() is 
called.
   > XMSS applies further validation to deserialisation of the BDS tree so 
that failure occurs as soon as tampering is detected (see CVE below).
   > An off by one error in the JsseDefaultHostnameAuthorizer 
isValidNameMatch method has been fixed.
   > BCJSSE: Return empty byte array instead of null, for

[GitHub] kemitix opened a new pull request #1038: [WIP] [Security] Bump xstream from 1.4.8 to 1.4.11.1

2019-02-11 Thread GitBox 
kemitix opened a new pull request #1038: [WIP] [Security] Bump xstream from 
1.4.8 to 1.4.11.1
URL: https://github.com/apache/brooklyn-server/pull/1038
 
 
   Bumps [xstream](https://github.com/x-stream/xstream) from 1.4.8 to 1.4.11.1. 
**This update includes security fixes.**
   
   Vulnerabilities fixed
   
   *Sourced from [The Sonatype OSS 
Index](https://ossindex.sonatype.org/vuln/764af3f0-05d8-4a8d-9421-1d51ed8f2fae).*
   
   > **[CVE-2017-7957]  Improper Input Validation**
   > XStream through 1.4.9, when a certain denyTypes workaround is not used, 
mishandles attempts to create an instance of the primitive type 'void' during 
unmarshalling, leading to a remote application crash, as demonstrated by an 
xstream.fromXML("") call.
   > 
   > Affected versions: <= 1.4.9
   
   *Sourced from [The Sonatype OSS 
Index](https://ossindex.sonatype.org/vuln/325b0ce9-1324-4bb8-820d-032aaaf1a8ef).*
   
   > **[CVE-2016-3674]  Information Exposure**
   > Multiple XML external entity (XXE) vulnerabilities in the (1) Dom4JDriver, 
(2) DomDriver, (3) JDomDriver, (4) JDom2Driver, (5) SjsxpDriver, (6) 
StandardStaxDriver, and (7) WstxDriver drivers in XStream before 1.4.9 allow 
remote attackers to read arbitrary files via a crafted XML document.
   > 
   > Affected versions: <= 1.4.8
   
   
   
   Commits
   
   - See full diff in [compare 
view](https://github.com/x-stream/xstream/commits)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kemitix commented on issue #1035: DO NOT MERGE Use dependencyManagement from Karaf as a bom

2019-02-11 Thread GitBox 
kemitix commented on issue #1035: DO NOT MERGE Use dependencyManagement from 
Karaf as a bom
URL: https://github.com/apache/brooklyn-server/pull/1035#issuecomment-462329586
 
 
   There are problems being reported by `brooklyn-dist` when building againt 
this PR. Need to look into that before going ahead with this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] duncangrant merged pull request #278: Replace reference to AMP with Brooklyn

2019-02-11 Thread GitBox 
duncangrant merged pull request #278: Replace reference to AMP with Brooklyn
URL: https://github.com/apache/brooklyn-docs/pull/278
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kemitix opened a new pull request #278: Replace reference to AMP with Brooklyn

2019-02-11 Thread GitBox 
kemitix opened a new pull request #278: Replace reference to AMP with Brooklyn
URL: https://github.com/apache/brooklyn-docs/pull/278
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit merged pull request #122: Change NO-CONNECTION error message

2019-02-11 Thread GitBox 
asfgit merged pull request #122: Change NO-CONNECTION error message
URL: https://github.com/apache/brooklyn-ui/pull/122
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ahgittin commented on issue #122: Change NO-CONNECTION error message

2019-02-11 Thread GitBox 
ahgittin commented on issue #122: Change NO-CONNECTION error message
URL: https://github.com/apache/brooklyn-ui/pull/122#issuecomment-462294694
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit merged pull request #1036: Fix session cleaner

2019-02-11 Thread GitBox 
asfgit merged pull request #1036: Fix session cleaner
URL: https://github.com/apache/brooklyn-server/pull/1036
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ahgittin commented on issue #1036: Fix session cleaner

2019-02-11 Thread GitBox 
ahgittin commented on issue #1036: Fix session cleaner
URL: https://github.com/apache/brooklyn-server/pull/1036#issuecomment-462290489
 
 
   looks good @jcabrerizo, merging (will change log level on line 218 as above 
-- it was my mistake anyway!)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aledsage commented on issue #1037: tidy string/primitive coercion

2019-02-11 Thread GitBox 
aledsage commented on issue #1037: tidy string/primitive coercion
URL: https://github.com/apache/brooklyn-server/pull/1037#issuecomment-462274678
 
 
   Other than failing unit test, LGTM. Happy for this to be merged once that is 
fixed @ahgittin 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aledsage commented on issue #1037: tidy string/primitive coercion

2019-02-11 Thread GitBox 
aledsage commented on issue #1037: tidy string/primitive coercion
URL: https://github.com/apache/brooklyn-server/pull/1037#issuecomment-462272662
 
 
   @ahgittin test failure looks related to changes 
(`TypeCoercionsTest.testCoercePrimitiveFailures`):
   ```
   java.lang.AssertionError: Error from type coercion of maybe to boolean 
failed with wrong exception; expected match of 
Predicates.and(containsLiteral("String"),containsLiteral("boolean"),containsLiteral("maybe"))
 but got: org.apache.brooklyn.util.javalang.coerce.ClassCoercionException: 
Cannot coerce type String to java.lang.Boolean (maybe): adapting failed
at 
org.apache.brooklyn.util.javalang.coerce.TypeCoercionsTest.assertCoercionFailsWithErrorMatching(TypeCoercionsTest.java:154)
at 
org.apache.brooklyn.util.javalang.coerce.TypeCoercionsTest.testCoercePrimitiveFailures(TypeCoercionsTest.java:140)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ahgittin commented on issue #1036: Fix session cleaner

2019-02-11 Thread GitBox 
ahgittin commented on issue #1036: Fix session cleaner
URL: https://github.com/apache/brooklyn-server/pull/1036#issuecomment-462268046
 
 
   two fixes.  also could you remove the `log.debug` i accidentally committed 
on line 218 ?  :)  thx


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services