Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/238#discussion_r151662204
--- Diff: guide/locations/_AWS.md ---
@@ -42,6 +42,21 @@ Below are examples of configuration options that use
values specific to AWS EC2
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/898
Add dockerfile for CI build
As per as the [ML
discussion](https://lists.apache.org/thread.html/c97846e172d327e72eb286e3c032c26fc0d6642dc553a4b47494177c@%3Cdev.brooklyn.apache.org%3E
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-library/pull/143
Add dockerfile for CI build
As per as the [ML
discussion](https://lists.apache.org/thread.html/c97846e172d327e72eb286e3c032c26fc0d6642dc553a4b47494177c@%3Cdev.brooklyn.apache.org%3E
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-dist/pull/115
Add dockerfile for CI build
As per as the [ML
discussion](https://lists.apache.org/thread.html/c97846e172d327e72eb286e3c032c26fc0d6642dc553a4b47494177c@%3Cdev.brooklyn.apache.org%3E
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/895
Add missing /v1/catalog/bundles REST endpoint for karaf distribution
Without this change, the `/v1/catalog/bundles` REST endpoint is now
available when launching through Karaf
You can
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/895#discussion_r150796771
--- Diff:
rest/rest-resources/src/main/resources/OSGI-INF/blueprint/service.xml ---
@@ -75,6 +75,7 @@ limitations under the License
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/895#discussion_r150797248
--- Diff:
rest/rest-resources/src/main/resources/OSGI-INF/blueprint/service.xml ---
@@ -74,18 +74,20 @@ limitations under the License
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn/pull/13
Add dockerfile for CI build
As per as the [ML
discussion](https://lists.apache.org/thread.html/c97846e172d327e72eb286e3c032c26fc0d6642dc553a4b47494177c@%3Cdev.brooklyn.apache.org%3E),
this adds
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-ui/pull/49
Add dockerfile for CI build
As per as the [ML
discussion](https://lists.apache.org/thread.html/c97846e172d327e72eb286e3c032c26fc0d6642dc553a4b47494177c@%3Cdev.brooklyn.apache.org%3E
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-dist/pull/112
Reuse bundle's catalog.bom from server-cli module
As https://github.com/apache/brooklyn-server/pull/882 now includes the
entities from `server-cli`, therefore they need to be removed from
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/882
Reuse bundle's catalog.bom from server-cli module
Some items were missing when I did the update of `catalog.bom` files to use
bundles. This fixes it by including this bundle within
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/882
@ahgittin demo items are not remove, there are added to the catalog in
`brooklyn-dist`. BTW, I did add them, there were always there, I just remove
the duplication with catalog items
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/225
Use gitbook-plugin-blueprint-tour to avoid rendering issue
I noticed that during the build, the rendering of pages could sometimes be
wrong if markdown syntax is wrapped around HTML code
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/884
I think you are right @aledsage, I clearly didn't think this through with
#882. I would remove this dependency and add those item into `brooklyn-library`
or `brooklyn-core` instead
---
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/234
Update YAML example to newer syntax
Does 3 things:
- update `serviceType` to `type`
- update `start.latch` to `latch.start`
- use backticks to have syntax highlighting on YAML
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-dist/pull/113
LGTM, thanks @ahgittin
---
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/889
Revert @JsonInclude annotations to what it was in 0.12.0 for backward
compatibility
As per as [the discussion on the
ML](https://lists.apache.org/thread.html
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/235
Update outdated blueprint examples
Updated example war's URL + fix wrong config key's name
You can merge this pull request into a Git repository by running:
$ git pull https
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/886
retest this please
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/885
@ahgittin attribution is nice indeed. Bear in ming that I'm not an expert
in licensing, @rdowner knows more than me on this topic, I'm sure he will be
able to provide a better answer.
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149640511
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/AdjunctTransformer.java
---
@@ -45,17 +45,24
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/886
LGTM, thanks @aledsage
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/886
Failed tests look not related
```
Results :
Failed tests:
LoopOverGroupMembersTestCaseTest.testMultipleChildrenWhichPass:99 »
EffectorCallPropagatedRuntime
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/140
LGTM, thanks @aledsage ð
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149632259
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/AdjunctTransformer.java
---
@@ -45,17 +45,24
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149647085
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/AdjunctTransformer.java
---
@@ -45,17 +45,24
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/885
@ahgittin My understanding was that if the licence is different than
`Apache-2.0`, then it needs to be included.
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149641924
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java ---
@@ -253,4 +253,12 @@ public Response setConfig
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149624824
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java ---
@@ -253,4 +253,12 @@ public Response setConfig
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/233
Update outdated blueprint examples
This update URL to the newest version of example wars, within example
blueprints. It also adds `# BROOKLYN_VERSION` tag so that links can be updated
when
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149653548
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java ---
@@ -253,4 +253,12 @@ public Response setConfig
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/885
@ahgittin Are we still using the @catalog annotation? I thought it was
deprecated.
Also, karaf uses exclusively the BOM file if I'm not mistaken
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149616675
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java ---
@@ -253,4 +253,12 @@ public Response setConfig
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/885#discussion_r149617400
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/AdjunctTransformer.java
---
@@ -45,17 +45,24
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/884
@aledsage I agree with your assessment, option 1 seems to be the best for
all the reasons you mentioned. I can do those changes if you want?
---
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/226
(WIP) Plugins for blueprint tour and features list
HTML should be keep at the minimum in `*.md` files. This PR creates 2
plugins to encapsulate reusable features:
- Blueprint/policy tour
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/232
Fix typo + syntax highlighting
Fix typo in the first YAML example (`:` at the end of the location) + add
syntax highlighting
You can merge this pull request into a Git repository
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/223
Add page title as part of the template rather than content
As the title said: rather than having the page title part of the markdown
file, this pushes it into the template
You can merge
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/224
Use colour from variables.less for blueprint tour
The policies page example was not using the colour defined within the
`variables.less` file, this fixes it.
You can merge this pull request
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/222
Thanks @m4rkmckenna !
However, can you hold off a wee bit more? I just realised that while
internal relative links are perfectly fine for the docs, it might cause issues
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/145
LGTM, thanks @aledsage
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/916#discussion_r158266008
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -799,6 +795,14 @@ protected Entity replaceMember
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/917#discussion_r158235800
--- Diff:
core/src/main/java/org/apache/brooklyn/core/entity/AbstractEntity.java ---
@@ -749,13 +756,15 @@ public Application getApplication
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/894
Reviewed by @duncangrant and tests passed, merging this. Thanks @aledsage
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/922
The build was aborted for some reason, but all tests passed:
```
[INFO] Installing
org/apache/brooklyn/brooklyn-commands/1.0.0-SNAPSHOT/brooklyn-commands-1.0.0-SNAPSHOT.jar
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/922
retest this please
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/962#discussion_r186256657
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
@@ -934,15 +937,17 @@ private void
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/962#discussion_r186256734
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/ConfigSummary.java
---
@@ -114,7 +116,8 @@ public ConfigSummary(ConfigKey
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/962#discussion_r186256748
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/ConfigSummary.java
---
@@ -114,7 +116,8 @@ public ConfigSummary(ConfigKey
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-library/pull/154
Use the settings.xml from Jenkins to deploy artifacts
Without it, the deploy fails as maven provided by docker doesn't have the
right credentials
You can merge this pull request
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/959
This LGTM, with a lot of new tests. However, I'm not very familiar with the
rebind code so it would be good if another set of eyes could also review this PR
---
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-dist/pull/121
[BROOKLYN-579] Add DNS TTL configuration via envvar
Before, java was not refreshing the DNS records, ever. This is due to the
default `networkaddress.cache.ttl` set to `-1`, i.e. cache
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/963#discussion_r190576983
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/provider/AwsEc2LocationLiveTest.java
---
@@ -28,6 +30,8
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/963#discussion_r190576874
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/provider/AbstractJcloudsLocationTest.java
---
@@ -48,7 +48,7
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/121#discussion_r191788710
--- Diff: karaf/apache-brooklyn/src/main/resources/bin/setenv ---
@@ -85,6 +89,9 @@ export
EXTRA_JAVA_OPTS="-Dbrooklyn.location.localhost.ad
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-dist/pull/121
@geomacy I added the comment, should be ok now.
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/153#discussion_r185456052
--- Diff: Jenkinsfile ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/153#discussion_r185455649
--- Diff: Jenkinsfile ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/961
Add .m2 folder in the list of ignore folders for the RAT plugin.
This is required for Jenkins build as we now use a local m2 cache
You can merge this pull request into a Git repository
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/961#discussion_r185490511
--- Diff: parent/pom.xml ---
@@ -1104,6 +1104,8 @@
https://brooklyn.incubator.apache.org
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-library/pull/153
Add Jenkinsfile for CI build
This capture the current Jenkins configuration, so that is repeatable and
documented.
You can merge this pull request into a Git repository by running
Github user tbouron closed the pull request at:
https://github.com/apache/brooklyn-library/pull/152
---
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-library/pull/152
Add Jenkinsfile for CI build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-library feature/docker
Alternatively
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-library/pull/151
Add Jenkinsfile for CI build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-library feature/docker
Alternatively
Github user tbouron closed the pull request at:
https://github.com/apache/brooklyn-library/pull/151
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/960
retest this please
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/960
Tests passed:
https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-server-pull-requests/2916
Thanks @geomacy, merging
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/960
retest this please
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/960
Looks sensible @geomacy but it seems adding but another test failed:
https://builds.apache.org/job/brooklyn-server-pull-requests/org.apache.brooklyn$brooklyn-software-base/2912/testReport
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/928
@aledsage Fixed conflicts and addressed your comment
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/927#discussion_r160116429
--- Diff:
rest/rest-resources/src/test/java/org/apache/brooklyn/rest/resources/BundleAndTypeResourcesTest.java
---
@@ -1095,4 +1110,268 @@ private
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/927#discussion_r160111321
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/BundleApi.java ---
@@ -88,6 +90,51 @@ public BundleSummary detail
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/927#discussion_r160111698
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java
---
@@ -107,6 +113,42 @@ protected
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/927#discussion_r160129168
--- Diff:
rest/rest-resources/src/test/java/org/apache/brooklyn/rest/resources/BundleAndTypeResourcesTest.java
---
@@ -1095,4 +1110,268 @@ private
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/927
Yep, the `latest` for bundles is not in the scope of this PR so I'm happy
if there is another one for this.
Merging
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/927#discussion_r160128983
--- Diff:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java
---
@@ -107,6 +113,42 @@ protected
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/928
retest this please
---
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/928
Allow deprecation as the catalog item level
In YAML, one can mark a catalog item as `deprecated` but it works only when
the flag it set as the `brooklyn.catalog` level
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/927
Actually @ahgittin, it seems the new endpoint is now available: I get a 404
and it does not appear on the swagger page. Not sure what's going on here
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/927
I did but looks like I messed up my env somehow. Everything is fine now,
sorry for the noise @ahgittin
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-docs/pull/243
Thanks @rdowner for this. Tested locally without an issue ð
Will merge now
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/940
Tested, works as advertised. All comments from @ahgittin have been
addressed and I have to say, it's really cool to have this extra information
@geomacy ð ð
Merging
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-library/pull/134
@bostko Sorry for the very late reply. It still miss an icon (see
https://github.com/apache/brooklyn-library/pull/134#discussion_r146811001).
After that, it should be good to go
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/948
LGTM, thanks @aledsage, merging
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/690
retest this please
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/916
@aledsage I agree with @nakomis and @sjcorbett. I this logic should be
implemented in the client (UI/CLI) to deal with a
`InsufficientCapacityException` by proposing to resize to the max
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/922
retest this please
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/921
Thanks for the detailed description @aledsage.
LGTM, merging
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/915
Tested, LGTM, thanks @aledsage
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/830#discussion_r158289019
--- Diff: locations/container/pom.xml ---
@@ -32,10 +32,50 @@
-1.4.27
+2.5.6
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/830#discussion_r158288981
--- Diff: locations/container/pom.xml ---
@@ -32,10 +32,50 @@
-1.4.27
+2.5.6
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/830#discussion_r158289882
--- Diff:
locations/container/src/main/java/org/apache/brooklyn/container/location/kubernetes/KubernetesLocation.java
---
@@ -347,8 +386,8
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/922
LGTM, will merge once Jenkins is happy
---
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/830#discussion_r158294318
--- Diff: locations/container/pom.xml ---
@@ -32,10 +32,50 @@
-1.4.27
+2.5.6
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/917
Thanks @aledsage. Tests passed, merging this now
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/920
LGTM, merging, thanks @aledsage
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/923
@aledsage Code-wise, this looks fine.
However, as I said in
https://github.com/apache/brooklyn-server/pull/916#discussion_r158266008, I
don't think this behaviour is the right
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/260
Use the official AWS CLI instead of s3cmd
Based on this comment:
https://github.com/apache/brooklyn-docs/pull/258#discussion_r197133399
Note: I checked the docs and this is the only
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-dist/pull/124
retest this please
---
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/974
Tested latest changes from @ahgittin: did a full build and works as
expected ð
---
401 - 500 of 655 matches
Mail list logo
