[GitHub] incubator-brooklyn pull request: tryLoadClass: return optional.abs...

2015-12-04 Thread ygy
Github user ygy commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1089#issuecomment-161929248 LGTM. Tested in a production setup scenario. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-brooklyn pull request: Hazelcast Cluster support

2015-12-13 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1108 Hazelcast Cluster support - Upgrade Hazelcast to v.3.5.4 - Small refactoring - Adding integration tests You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-brooklyn pull request: RabbitMQ upgrade

2015-12-30 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1123 RabbitMQ upgrade RabbitMQ to v.3.6.0 Erlang to v.18.2 RabbitMQ recommends Erlang 18. Release notes state: Minimum required Erlang version is R16B03 for plain ("jus

[GitHub] brooklyn-server issue #195: Sanitize effector parameters when reporting an e...

2016-06-10 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/195 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-brooklyn pull request: WinRM docs for correct preparatio...

2016-01-18 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1153 WinRM docs for correct preparation of windows templates - Short troubleshooting section that incorrect windows template can cause timeouts or fail some deployments - Settings

[GitHub] incubator-brooklyn pull request: Additional security for MySQL

2016-01-19 Thread ygy
Github user ygy commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1157#issuecomment-172791681 I think that we don't need to explicitly include ```NO_ENGINE_SUBSTITUTION``` and ```STRICT_TRANS_TABLES``` for now. Maybe, we can think of upgrading MySQL

[GitHub] brooklyn-library pull request: Fix: ElasticSearch used Java versio...

2016-03-25 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/brooklyn-library/pull/26 Fix: ElasticSearch used Java version Making ElasticSearch to use JavaSoftwareProcessDriver so the correct java version is installed. ElasticSearch used to install java via BashCommands

[GitHub] brooklyn-library pull request: CouchDB installation fixes

2016-05-03 Thread ygy
Github user ygy commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/32#discussion_r61858293 --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/couchdb/CouchDBNodeSshDriver.java --- @@ -129,7 +199,7 @@ public void customize

[GitHub] brooklyn-library pull request: CouchDB installation fixes

2016-04-19 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/brooklyn-library/pull/32 CouchDB installation fixes - CouchDB is installed from source now - CouchDB dependencies are installed by the official repos - Fixed SuSE Linux support You can merge this pull request

[GitHub] brooklyn-server pull request #285: [WIP] Adding HttpExecutor to be used for ...

2016-08-03 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/brooklyn-server/pull/285 [WIP] Adding HttpExecutor to be used for interchangeable implementations You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn

[GitHub] brooklyn-server issue #544: Prefer centos 7

2017-02-01 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/544 CentOS 7.3 has a bug which affects ssh daemon reloading - https://bugs.centos.org/view.php?id=12757 `CreateUserPolicy` is directly impaired, because it uses jclouds to reload the ssh daemon

[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

2016-08-22 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/285 @nakomis @neykov Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-02 Thread ygy
Github user ygy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77378577 --- Diff: core/src/test/java/org/apache/brooklyn/feed/http/HttpFeedTest.java --- @@ -71,12 +71,12 @@ private static final long TIMEOUT_MS

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-02 Thread ygy
Github user ygy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77385034 --- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java --- @@ -275,7 +294,23 @@ public HttpFeed() { protected HttpFeed(Builder

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-02 Thread ygy
Github user ygy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77386547 --- Diff: core/src/main/java/org/apache/brooklyn/location/byon/ByonLocationResolver.java --- @@ -108,6 +109,7 @@ protected ConfigBag extractConfig(Map

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-02 Thread ygy
Github user ygy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77386246 --- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java --- @@ -331,52 +365,54 @@ protected void preStart

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-03 Thread ygy
GitHub user ygy reopened a pull request: https://github.com/apache/brooklyn-server/pull/285 Adding HttpExecutor to be used for interchangeable implementations You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-server

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-03 Thread ygy
Github user ygy closed the pull request at: https://github.com/apache/brooklyn-server/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-05 Thread ygy
Github user ygy closed the pull request at: https://github.com/apache/brooklyn-server/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-05 Thread ygy
GitHub user ygy reopened a pull request: https://github.com/apache/brooklyn-server/pull/285 Adding HttpExecutor to be used for interchangeable implementations You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-server

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-05 Thread ygy
GitHub user ygy reopened a pull request: https://github.com/apache/brooklyn-server/pull/285 Adding HttpExecutor to be used for interchangeable implementations You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-server

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-05 Thread ygy
Github user ygy closed the pull request at: https://github.com/apache/brooklyn-server/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

2016-09-05 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/285 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-09-05 Thread ygy
Github user ygy closed the pull request at: https://github.com/apache/brooklyn-server/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server pull request #320: Package name change due to collision when...

2016-09-06 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/brooklyn-server/pull/320 Package name change due to collision when used inside OSGI You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-server fix/osgi

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-08-29 Thread ygy
Github user ygy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r76594227 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/http/executor/HttpRequest.java --- @@ -0,0 +1,128 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

2016-08-29 Thread ygy
Github user ygy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r76594668 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/http/executor/apacheclient/HttpExecutorImpl.java --- @@ -0,0 +1,106

[GitHub] brooklyn-library pull request #64: BROOKLYN-350 Curl will follow location re...

2016-09-26 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/brooklyn-library/pull/64 BROOKLYN-350 Curl will follow location redirects - externalizing the CURL command - adding default parameter so curl follows location redirects You can merge this pull request into a Git

[GitHub] brooklyn-server issue #360: BROOKLYN-354: Rebind failed (when an NingxContro...

2016-09-29 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/360 All tests are passing. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #441: Fixing HttpResponse headers value

2016-11-17 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/441 @aledsage @neykov The test has been simplified --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server pull request #441: Fixing HttpResponse headers value

2016-11-16 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/brooklyn-server/pull/441 Fixing HttpResponse headers value You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-server fix/http-response Alternatively you

[GitHub] brooklyn-server pull request #591: Fix ssh login when provider's image requi...

2017-03-13 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/brooklyn-server/pull/591 Fix ssh login when provider's image requires TTY You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-server fix/ssh-login

[GitHub] brooklyn-docs issue #204: Fix wrong indentation in Windows Azure ARM config

2017-08-01 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-docs/pull/204 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server issue #698: Fix type-coercion to Iterable

2017-05-25 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/698 @geomacy You can find at https://gist.github.com/ygy/59c793028457c1f1f5a1f027df047fa6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] brooklyn-server issue #698: Fix type-coercion to Iterable

2017-05-25 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/698 @aledsage LTGM. Tests are passing for me. Tested successfully with a BP which fails without it. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] brooklyn-server issue #714: BROOKLYN-513: fix coercion for jclouds reflectiv...

2017-06-01 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/714 I've successfully tested it with a manual build. It covers the use case for specifying ipOptions in jclouds. --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-docs pull request #196: Adding docs for Windows on Azure ARM

2017-06-12 Thread ygy
GitHub user ygy opened a pull request: https://github.com/apache/brooklyn-docs/pull/196 Adding docs for Windows on Azure ARM You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-docs docs/winrm Alternatively you can