[GitHub] brooklyn-library issue #160: jenkins: don't bind mount .m2

2018-09-25 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-library/pull/160
  
I've created 
https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-master-docker-pipeline/.
 The first run failed due to the rat check, which this PR fixes.

Merging this now, and will re-run the pipeline build.


---


[GitHub] brooklyn-library issue #160: jenkins: don't bind mount .m2

2018-09-25 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-library/pull/160
  
@tbouron I suspect that the `Jenkinsfile` has no effect, and that it just 
uses the configuration in 
https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-master-docker/configure.
e.g. the most recent build 
(https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-master-docker/336/consoleFull)
 has a docker command that matches the `/configure` page rather than the 
Jenkinsfile.

Am I missing something?

I'm going to create a new job (`brooklyn-library-master-docker-pipeline`) 
to try to set it up to use the Jenkinsfile (i.e. use pipelines).


---


[GitHub] brooklyn-library issue #160: jenkins: don't bind mount .m2

2018-09-24 Thread tbouron
Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-library/pull/160
  
This looks fine @aledsage but I can see 2 issues there:
1. what about the `settings.xml`? In the PR context, we don't care because 
we don't push artifacts to maven central but as soon as it is merged, the real 
jenkins job will try that and will then fail because the credentials are stored 
there
2. This means that we will need to add the same `...` 
lines to every brooklyn submodule


---