[GitHub] brooklyn-server issue #1000: Config constraints: add more tests

2018-09-26 Thread ahgittin 
Github user ahgittin commented on the issue:

https://github.com/apache/brooklyn-server/pull/1000
  
Thanks @kemitix @aledsage - merging


---

[GitHub] brooklyn-server issue #1000: Config constraints: add more tests

2018-09-26 Thread kemitix 
Github user kemitix commented on the issue:

https://github.com/apache/brooklyn-server/pull/1000
  
LGTM

Some of the assertion helper methods look like they might be useful outwith 
the class where they are defined. Possible candidates for refactoring later.


---

[GitHub] brooklyn-server issue #1000: Config constraints: add more tests

2018-09-25 Thread aledsage 
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/1000
  
retest this please

Jenkins failure was an environment problem I believe:
```
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress git://github.com/apache/brooklyn-server.git 
+refs/pull/*:refs/remotes/origin/pr/*" returned status code 128:
```


---