[GitHub] brooklyn-server issue #1003: Update IPTables save method

2018-11-23 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/1003 as @aledsage this is largely included in #1006 . @frogfather your call whether there is value in the recent comments here and if so update this PR, make sure to `git merge master` in to

[GitHub] brooklyn-server issue #1003: Update IPTables save method

2018-10-09 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/1003 LGTM; happy for this to be merged (once confusion with the identical-looking https://github.com/apache/brooklyn-server/pull/1005 is cleared up). ---

[GitHub] brooklyn-server issue #1003: Update IPTables save method

2018-10-02 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/1003 I think Jenkins is failing due to permissions, maybe on the ASF side? ---

[GitHub] brooklyn-server issue #1003: Update IPTables save method

2018-10-02 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/1003 Thanks @frogfather LGTM, will merge assuming tests pass ---

[GitHub] brooklyn-server issue #1003: Update IPTables save method

2018-10-02 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/1003 > Service iptables save doesn't work with Centos7 That is, doesn't work with the CentOS 7 AMI we use on EC2, which has a cut-down `service` command only supporting the standard