Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/358
Thanks, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/358
@neykov Ah ok, I didn't know. Squashed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/358
Unfortunately it doesn't work for Apache projects. The github repo is a
read-only copy of the Apache repo where this will get merged. Also can't use
the "share branch with committers"
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/358
@neykov You can do it from the [Github UI
directly](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-using-the-github-web-interface)
;)
---
If your project
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/358
Looks great @tbouron. Can you squash then good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/358
LGTM - very minor comments only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/358
@neykov Comments addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/358
In summary - looks good. Only concerned about introducing `constraints`
which breaks persistence compatibility. Suggest reverting all related changes
and making the predicate -> string
