Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/482
Actually I think my comments above are not worth holding this up for, and I
answered my question above myself with a bit of further inspection and running
tests, so happy to merge. LGTM.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/482
LGTM, once @geomacy 's comments addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/482
Decided to stick with `DslFunctionSource`. Address all other comments.
Merged with #486.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/482
nice. and good spot re errors. probably is worth keeping, not just for
errors, but also so that we have some hope of being able to propose
autocompletions / populate graphical editor.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/482
Did the removal of `DslCallable` locally. Works fine, but turns out we are
losing one important feature of the current approach - if you misspell a method
on `DslComponent` you won't find
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/482
Good idea about stopping once the function is available, will think about
it.
The `DDFC` chaining is started on the first non-`DslCallable`
`DeferredSupplier`. But said supplier could
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/482
makes sense although something niggles...
quick things:
* definitely `@DslAccessible` is clearer for methods
* maybe `DslFunctionSource` is a better name than `DslCallable`
