Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/484
Thanks @aledsage and @geomacy. I will merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/484
Looks good @sjcorbett, a useful tidy-up to this big class; have had a look
through PR but nothing to add to above comments.
---
If your project is set up for it, you can reply to this
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/484
Thanks @sjcorbett - looks great. Unfortunately there are merge conflicts
again (probably due to https://github.com/apache/brooklyn-server/pull/496).
Once those are resolved, and
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/484
@aledsage My intention was to avoid anything that was persisted. Of the
classes touched:
* `RebindToMachinePredicate` was a private static class that is created in
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/484
Thanks @sjcorbett - great to separate out this huge class, and improve this
code!
I haven't had a proper chance to review yet. Does it change the names of
any classes that might
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/484
P.S. to preempt Jenkins: tests pass locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
