[GitHub] brooklyn-server issue #535: Add jclouds AzureComputeRateLimitModule to suppo...

2017-01-25 Thread tbouron
Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-server/pull/535
  
@aledsage done



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #535: Add jclouds AzureComputeRateLimitModule to suppo...

2017-01-25 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/535
  
The test failure is unrelated, and should be investigated/fixed separately:

```
java.lang.AssertionError: entity=Application[802qtu86]; attribute=Sensor: 
service.state (org.apache.brooklyn.core.entity.lifecycle.Lifecycle) expected 
[running] but found [on-fire]
at 
org.apache.brooklyn.core.entity.ApplicationLifecycleStateTest.assertHealthContinually(ApplicationLifecycleStateTest.java:196)
at 
org.apache.brooklyn.core.entity.ApplicationLifecycleStateTest.testStartsThenChildFailsButWithQuorumCausesAppToSucceed(ApplicationLifecycleStateTest.java:170)
```

@tbouron can you trigger jenkins to build again please, e.g. by doing `git 
commit --amend; git push -f`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #535: Add jclouds AzureComputeRateLimitModule to suppo...

2017-01-25 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-server/pull/535
  
Thanks @tbouron - LGTM. Once jenkins has finished running the tests, I'll 
merge this.

I've created https://issues.apache.org/jira/browse/BROOKLYN-430 to track 
this in brooklyn, which just links to jclouds 
https://issues.apache.org/jira/browse/JCLOUDS-1229.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---