[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 Failed again, this time when running `org.apache.brooklyn.entity.machine.MachineEntityJcloudsRebindTest.testRebind`: ``` java.lang.AssertionError: failed succeeds-eventually, 75

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 Test failure looked unrelated, and I couldn't reproduce locally (or see why this would fail!): ``` java.lang.AssertionError: failed succeeds-eventually, 21 attempts, 3001ms

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/859 @aledsage Build failure seems related: ``` [ERROR]

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/859 Yup @aledsage, LGTM. ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 Thanks @tbouron - I've added back the location.getConfig method that I accidentally deleted. I squashed that commit, so we won't have a weird deletion in our history. I've also

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 I ran this test many times (`@Test(invocationCount=1000)`) and found the deadlock reported in https://issues.apache.org/jira/browse/BROOKLYN-544 (which is not related to this PR). ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/859 Apache jenkins failed with: ``` Build timed out (after 60 minutes). Marking the build as aborted. [ERROR] Failed to execute goal

[GitHub] brooklyn-server issue #859: Delete old deprecated code

Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-server/pull/859 retest this please ---