[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/112#issuecomment-218084476 @nakomis Didn't realise this can be used with $broolyn:object. That's enough YAML friendly for me :). --- If your project is set up for it, you can reply to

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user nakomis commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r62474640 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/FirstFromRemovalStrategy.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r62239950 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/FirstFromRemovalStrategy.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r62237872 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/SensorMatchingRemovalStrategy.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r62227937 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/SensorMatchingRemovalStrategy.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r62227490 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java --- @@ -151,12 +151,14 @@ public ZoneFailureDetector

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r59550901 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java --- @@ -151,12 +151,14 @@ public ZoneFailureDetector

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user sjcorbett commented on the pull request: https://github.com/apache/brooklyn-server/pull/112#issuecomment-208918399 Looks much cleaner. I'm wary that turning `defaultRemovalStrategy` from an anonymous inner class to a named inner class will be problematic for anyone with

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user nakomis commented on the pull request: https://github.com/apache/brooklyn-server/pull/112#issuecomment-208879479 Hadn't twigged that I wouldn't need to change the config key. Much nice without all the deprecation. Have close

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user sjcorbett commented on the pull request: https://github.com/apache/brooklyn-server/pull/112#issuecomment-208845961 Thinking about this a bit more closely, you've deprecated a `ConfigKey>` in favour of a `ConfigKey`, but the `RemovalStrategy`

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r59355280 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicCluster.java --- @@ -148,6 +148,11 @@ ConfigKey FACTORY =

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r59355178 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java --- @@ -151,12 +151,14 @@ public ZoneFailureDetector

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/112#discussion_r59354661 --- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicCluster.java --- @@ -148,6 +148,11 @@ ConfigKey FACTORY =

[GitHub] brooklyn-server pull request: Configurable removal strategies

Github user nakomis commented on the pull request: https://github.com/apache/brooklyn-server/pull/112#issuecomment-208827153 Depended on by https://github.com/apache/brooklyn-library/pull/31 to be merged at the same time --- If your project is set up for it, you can reply to this

[GitHub] brooklyn-server pull request: Configurable removal strategies

GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/112 Configurable removal strategies You can merge this pull request into a Git repository by running: $ git pull https://github.com/nakomis/brooklyn-server