GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/1014
[WIP] Subtype setting config val: use as keyâs default val **For review/feedback only - failing unit tests.** Otherwise if another blueprint uses this subtype, it does not see the config val for that key. Worst case, it says the blueprint is invalid because the config key has no value. --- My new unit tests pass, but it breaks existing unit tests (e.g. in `ConfigParametersYamlTest.java`). The logic is applied to a catalog item and also to a blueprint being deployed. Our assertions in existing tests check that the config keys of the app being deployed have particular default vals, but these are now being overridden by the blueprint. What do folk think (cc @ahgittin) - should we use this approach, and fix the tests, or do something else? You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server subtype-config-used-as-key-defaultval Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-server/pull/1014.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1014 ---- commit 80d4806bc2828bb1437a42e48320e59282c5e86d Author: Aled Sage <aled.sage@...> Date: 2018-11-15T09:57:21Z Subtype setting config val: use as keyâs default val Otherwise if another blueprint uses this subtype, it does not see the config val for that key. Worst case, it says the blueprint is invalid because the config key has no value. ---- ---