Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/358
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81334424
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java ---
@@ -375,12 +376,14 @@ public static WeightedParameter
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81334163
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java ---
@@ -375,12 +376,14 @@ public static WeightedParameter
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81333940
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java ---
@@ -422,15 +422,15 @@ public
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r8119
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EntityConfigSummary.java
---
@@ -18,43 +18,82 @@
*/
package
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81188720
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java ---
@@ -184,7 +192,7 @@ public String getDescription() {
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81185833
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EntityConfigSummary.java
---
@@ -18,43 +18,82 @@
*/
package
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81185580
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EntityConfigSummary.java
---
@@ -18,43 +18,82 @@
*/
package
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81185397
--- Diff:
rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EntityConfigSummary.java
---
@@ -18,43 +18,82 @@
*/
package
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81183657
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java ---
@@ -184,7 +192,7 @@ public String getDescription() {
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81181965
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java
---
@@ -66,19 +66,20 @@ public
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81174007
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java
---
@@ -66,19 +66,20 @@ public
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81173978
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java
---
@@ -66,19 +66,20 @@ public
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/358#discussion_r81173329
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java
---
@@ -66,19 +66,20 @@ public
14 matches
Mail list logo